From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64231 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: smtpmail.el: set-buffer-file-coding-system takes too many args Date: Sat, 06 Jan 2007 21:11:25 +0100 Message-ID: References: <87d55svxxu.fsf@latte.josefsson.org> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1168115227 14429 80.91.229.12 (6 Jan 2007 20:27:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 6 Jan 2007 20:27:07 +0000 (UTC) Cc: David Z Maze Original-X-From: ding-owner+M12754@lists.math.uh.edu Sat Jan 06 21:27:05 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1H3I84-0006mP-Hz for ding-account@gmane.org; Sat, 06 Jan 2007 21:27:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1H3I7R-00011G-MN; Sat, 06 Jan 2007 14:26:21 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1H3Htb-0000xK-DM for ding@lists.math.uh.edu; Sat, 06 Jan 2007 14:12:03 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1H3HtU-0000xd-B8 for ding@lists.math.uh.edu; Sat, 06 Jan 2007 14:12:03 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.1]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1H3HtT-0002XZ-00 for ; Sat, 06 Jan 2007 21:11:55 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.13.8/8.13.8) with ESMTP id l06KBSEZ007365; Sat, 6 Jan 2007 21:11:29 +0100 (MET) Original-Received: from viandante.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with SMTP id 623BC12529; Sat, 6 Jan 2007 21:11:26 +0100 (CET) Original-Received: (nullmailer pid 20481 invoked by uid 170); Sat, 06 Jan 2007 20:11:25 -0000 Original-To: ding@gnus.org X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+ Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64231 Archived-At: On Sat, Jan 06 2007, Simon Josefsson wrote: > Reiner Steib writes: >> IIRC, smtpmail.el is also included with XEmacs. Simon, is >> `smtpmail.el' (from Emacs CVS) supposed to work with XEmacs without >> modifications? > > No. There are several modifications between XEmacs and Emacs > smtpmail.el, alas. > >> If so `smtpmail.el' should probably not use the NOMODIFY argument or >> provide some compatibility code. > > XEmacs users should use the smtpmail.el from mail-lib, there should be > no reason to use the Emacs CVS stuff (if there is, a bug report would > be most welcome!). What do you suggest for contrib/smtpmail.el? As `contrib/smtpmail.el' should only be used with Emacs 21, we probably can simply remove the NOMODIFY argument (and add a comment to explain it). Suggestion (similar for the second location): --8<---------------cut here---------------start------------->8--- --- smtpmail.el 04 Dec 2006 23:32:00 +0100 7.5 +++ smtpmail.el 06 Jan 2007 20:58:24 +0100 @@ -248,7 +248,11 @@ ;; buffer, otherwise any write-region invocations (e.g., in ;; mail-do-fcc below) will annoy with asking for a suitable ;; encoding. - (set-buffer-file-coding-system smtpmail-code-conv-from nil t) + ;; (set-buffer-file-coding-system smtpmail-code-conv-from nil t) + (set-buffer-file-coding-system smtpmail-code-conv-from nil) + ;; This file (`gnus/contrib/smtpmail.el') is only useful for Emacs + ;; which doesn't support the thried argument (NOMODIFY) of + ;; `set-buffer-file-coding-system'. (insert-buffer-substring mailbuf) (goto-char (point-max)) ;; require one newline at the end. --8<---------------cut here---------------end--------------->8--- BTW: Is NOMODIFY really useful here? In both cases, `set-buffer-file-coding-system' is followed by `insert-buffer-substring' which will mark the buffer modified anyhow. What am I missing? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/