Re: spam.el/spam-report.el: Gmane spam reporting broken in No Gnus

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Sep 21 2005, Ted Zlatanov wrote:

> On Tue, 20 Sep 2005, reinersteib+gmane@imap.cc wrote:
[...]
> Great.  I'm debating whether I should complete remove the old-style
> gnus-group-*-exit-processor-* variables.  I say yes.  If I do that, I
> won't have to fix this bug :)

Which released version do have the old-style variables?  The whole
5.10.x series upto 5.10.6, I think?  And v5-10 doesn't have the new
style?

IMHO, Step 1 should be to update (info "(gnus)Spam ELisp Package
Configuration Examples") (in No Gnus) to the new syntax.

[ FYI: My settings described in "Using `spam.el' on an IMAP server
with a statistical filter on the server" still work correctly
(AFAICS); both with v5-10 (Gnus 5.11) and trunk (No Gnus). ]

Step 2: I'd suggest to change the manual as follows.  Don't describe
the obsolete stuff *first* and the say it's obsolete:

,----[ (info "(gnus)Blacklists and Whitelists") ]
|  -- Variable: gnus-group-spam-exit-processor-blacklist
|      Add this symbol to a group's `spam-process' parameter by
|      customizing the group parameters or the
|      `gnus-spam-process-newsgroups' variable.  When this symbol is
|      added to a group's `spam-process' parameter, the senders of
|      spam-marked articles will be added to the blacklist.
| 
|      _WARNING_
| 
|      Instead of the obsolete
|      `gnus-group-spam-exit-processor-blacklist', it is recommended that
|      you use `(spam spam-use-blacklist)'.  Everything will work the
|      same way, we promise.
`----

*First* describe the new recommended syntax.  I don't know if it makes
more sense to create a section "old-style vs. new-style" or to mention
the old-style after each "Variable:".

Step 3: `G c' probably should not offer the obsolete form.

[ Step 4: Remove the backward compatibility. ]

>> I'm a little confused about the obsolescence: In [v5-10]/lisp/spam.el
>> `spam-list-of-processors' does not seem to be obsolete (CMIIW,
>> please).  
>
> Well, the variable's docstring has as the first line:
>
>   "The OBSOLETE `spam-list-of-processors' list.

But *not* in the v5-10 branch: v5-10/texi/gnus.el says that it's
obsolete, but v5-10/lisp/spam*.el doesn't!

,----
| -*- mode: grep; default-directory: ".../v5-10/lisp/" -*-
| Grep started at Wed Sep 21 18:04:46
| 
| grep -nH -ie obsolete spam*.el
| 
| Grep finished with no matches found at Wed Sep 21 18:04:46
`----


> Should I mark it obsolete in some other way?  I recall Emacs Lisp has
> some properties for that...

`make-obsolete-variable'?  I don't know if this is suitable here.

> I just added the support to spam.el and spam-report.el.  I assume
> that registering as spam is the same as unregistering as ham, and
> vice versa; if that's not the case let me know and I'll correct the
> backend registration.  Please test the reporting, if you have a
> chance.

Would you mind the following change?  I don't think we changing the
syntax of the (previously) interactive function `spam-report-gmane' is
a good idea.

--8<---------------cut here---------------start------------->8---
--- spam-report.el	21 Sep 2005 18:39:41 +0200	7.23
+++ spam-report.el	21 Sep 2005 18:42:59 +0200	
@@ -119,15 +119,17 @@
   "Report ARTICLES as not-spam (unregister) through Gmane."
   (interactive (gnus-summary-work-articles current-prefix-arg))
   (dolist (article articles)
-    (spam-report-gmane t article)))
+    (spam-report-gmane-internal t article)))
 
 (defun spam-report-gmane-spam (&rest articles)
   "Report ARTICLES as spam through Gmane."
   (interactive (gnus-summary-work-articles current-prefix-arg))
   (dolist (article articles)
-    (spam-report-gmane nil article)))
+    (spam-report-gmane-internal nil article)))
 
-(defun spam-report-gmane (unspam article)
+(defalias 'spam-report-gmane 'spam-report-gmane-spam)
+
+(defun spam-report-gmane-internal (unspam article)
   "Report ARTICLE as spam or not-spam through Gmane, depending on UNSPAM."
   (when (and gnus-newsgroup-name
 	     (or (null spam-report-gmane-regex)
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/