From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/60999 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: spam.el/spam-report.el: Gmane spam reporting broken in No Gnus Date: Wed, 21 Sep 2005 18:51:03 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: <4nek7jk83j.fsf@lifelogs.com> <4nirwuiinm.fsf@lifelogs.com> Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1127324582 7076 80.91.229.2 (21 Sep 2005 17:43:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2005 17:43:02 +0000 (UTC) Original-X-From: ding-owner+m9531@lists.math.uh.edu Wed Sep 21 19:43:01 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EI8aI-0005Yy-5X for ding-account@gmane.org; Wed, 21 Sep 2005 19:40:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EI8a8-0007ap-00; Wed, 21 Sep 2005 12:40:32 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EI8VN-0007ak-00 for ding@lists.math.uh.edu; Wed, 21 Sep 2005 12:35:37 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1EI8VC-0006Ko-G9 for ding@lists.math.uh.edu; Wed, 21 Sep 2005 12:35:37 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EI8VA-0007yJ-00 for ; Wed, 21 Sep 2005 19:35:24 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EI8SL-0002w8-L7 for ding@gnus.org; Wed, 21 Sep 2005 19:32:29 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Sep 2005 19:32:29 +0200 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 21 Sep 2005 19:32:29 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 113 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Copies-To: nobody User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:0WSM44pbhDHlfwsWImwTwOI4yxg= X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:60999 Archived-At: On Wed, Sep 21 2005, Ted Zlatanov wrote: > On Tue, 20 Sep 2005, reinersteib+gmane@imap.cc wrote: [...] > Great. I'm debating whether I should complete remove the old-style > gnus-group-*-exit-processor-* variables. I say yes. If I do that, I > won't have to fix this bug :) Which released version do have the old-style variables? The whole 5.10.x series upto 5.10.6, I think? And v5-10 doesn't have the new style? IMHO, Step 1 should be to update (info "(gnus)Spam ELisp Package Configuration Examples") (in No Gnus) to the new syntax. [ FYI: My settings described in "Using `spam.el' on an IMAP server with a statistical filter on the server" still work correctly (AFAICS); both with v5-10 (Gnus 5.11) and trunk (No Gnus). ] Step 2: I'd suggest to change the manual as follows. Don't describe the obsolete stuff *first* and the say it's obsolete: ,----[ (info "(gnus)Blacklists and Whitelists") ] | -- Variable: gnus-group-spam-exit-processor-blacklist | Add this symbol to a group's `spam-process' parameter by | customizing the group parameters or the | `gnus-spam-process-newsgroups' variable. When this symbol is | added to a group's `spam-process' parameter, the senders of | spam-marked articles will be added to the blacklist. | | _WARNING_ | | Instead of the obsolete | `gnus-group-spam-exit-processor-blacklist', it is recommended that | you use `(spam spam-use-blacklist)'. Everything will work the | same way, we promise. `---- *First* describe the new recommended syntax. I don't know if it makes more sense to create a section "old-style vs. new-style" or to mention the old-style after each "Variable:". Step 3: `G c' probably should not offer the obsolete form. [ Step 4: Remove the backward compatibility. ] >> I'm a little confused about the obsolescence: In [v5-10]/lisp/spam.el >> `spam-list-of-processors' does not seem to be obsolete (CMIIW, >> please). > > Well, the variable's docstring has as the first line: > > "The OBSOLETE `spam-list-of-processors' list. But *not* in the v5-10 branch: v5-10/texi/gnus.el says that it's obsolete, but v5-10/lisp/spam*.el doesn't! ,---- | -*- mode: grep; default-directory: ".../v5-10/lisp/" -*- | Grep started at Wed Sep 21 18:04:46 | | grep -nH -ie obsolete spam*.el | | Grep finished with no matches found at Wed Sep 21 18:04:46 `---- > Should I mark it obsolete in some other way? I recall Emacs Lisp has > some properties for that... `make-obsolete-variable'? I don't know if this is suitable here. > I just added the support to spam.el and spam-report.el. I assume > that registering as spam is the same as unregistering as ham, and > vice versa; if that's not the case let me know and I'll correct the > backend registration. Please test the reporting, if you have a > chance. Would you mind the following change? I don't think we changing the syntax of the (previously) interactive function `spam-report-gmane' is a good idea. --8<---------------cut here---------------start------------->8--- --- spam-report.el 21 Sep 2005 18:39:41 +0200 7.23 +++ spam-report.el 21 Sep 2005 18:42:59 +0200 @@ -119,15 +119,17 @@ "Report ARTICLES as not-spam (unregister) through Gmane." (interactive (gnus-summary-work-articles current-prefix-arg)) (dolist (article articles) - (spam-report-gmane t article))) + (spam-report-gmane-internal t article))) (defun spam-report-gmane-spam (&rest articles) "Report ARTICLES as spam through Gmane." (interactive (gnus-summary-work-articles current-prefix-arg)) (dolist (article articles) - (spam-report-gmane nil article))) + (spam-report-gmane-internal nil article))) -(defun spam-report-gmane (unspam article) +(defalias 'spam-report-gmane 'spam-report-gmane-spam) + +(defun spam-report-gmane-internal (unspam article) "Report ARTICLE as spam or not-spam through Gmane, depending on UNSPAM." (when (and gnus-newsgroup-name (or (null spam-report-gmane-regex) --8<---------------cut here---------------end--------------->8--- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/