Gnus development mailing list
 help / color / mirror / Atom feed
* sort-by-random docstrings
@ 2008-01-12 11:25 jidanni
  2008-01-12 11:53 ` Reiner Steib
  0 siblings, 1 reply; 2+ messages in thread
From: jidanni @ 2008-01-12 11:25 UTC (permalink / raw)
  To: ding

Gentlemen, you have just copied docstrings without thinking.

(defsubst gnus-article-sort-by-number (h1 h2)
  "Sort articles by article number."
  (< (mail-header-number h1)
     (mail-header-number h2)))

(defun gnus-thread-sort-by-number (h1 h2)
  "Sort threads by root article number."
  (gnus-article-sort-by-number
   (gnus-thread-header h1) (gnus-thread-header h2)))

(defsubst gnus-article-sort-by-random (h1 h2)
  "Sort articles by article number." <===========Clodsburgers
  (zerop (random 2)))

(defun gnus-thread-sort-by-random (h1 h2)
  "Sort threads by root article number."  <===========Clodsburgers
  (gnus-article-sort-by-random
   (gnus-thread-header h1) (gnus-thread-header h2)))



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: sort-by-random docstrings
  2008-01-12 11:25 sort-by-random docstrings jidanni
@ 2008-01-12 11:53 ` Reiner Steib
  0 siblings, 0 replies; 2+ messages in thread
From: Reiner Steib @ 2008-01-12 11:53 UTC (permalink / raw)
  To: ding

On Sat, Jan 12 2008, jidanni@jidanni.org wrote:

> Gentlemen, you have just copied docstrings without thinking.
[...]
> (defsubst gnus-article-sort-by-random (h1 h2)
>   "Sort articles by article number." <===========Clodsburgers
[...]
> (defun gnus-thread-sort-by-random (h1 h2)
>   "Sort threads by root article number."  <===========Clodsburgers

Fixed in CVS (v5-10), thanks.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-12 11:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-12 11:25 sort-by-random docstrings jidanni
2008-01-12 11:53 ` Reiner Steib

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).