From: Reiner Steib <reinersteib+gmane@imap.cc>
To: ding@gnus.org
Subject: Avoiding compiler warnings (was: Changes committed gnus/lisp (6 files))
Date: Wed, 05 Dec 2007 21:10:45 +0100 [thread overview]
Message-ID: <v9wsrsucl6.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <E1IzjR8-0001ME-00@quimby.gnus.org>
On Wed, Dec 05 2007, Katsumi Yamaoka wrote on ding-patches:
> * gnus-art.el (gnus-use-idna): Don't directly refer to the value of
> idna-program in order to suppress byte compile warning issued by XEmacs that
> came to byte compile the default value section of defcustom forms recently.
> * gnus-start.el (gnus-site-init-file): Don't directly refer to the value of
> installation-directory.
> * message.el (message-use-idna): Don't directly refer to the value of
> idna-program.
> * mm-uu.el (mm-uu-hide-markers): Don't directly call defined-colors.
> * smiley.el (smiley-style): Don't directly call face-attribute.
[...]
> - (executable-find idna-program))
> + (executable-find (symbol-value 'idna-program)))
> - (directory-file-name installation-directory))
> + (directory-file-name (symbol-value 'installation-directory)))
> - (executable-find idna-program)
> + (executable-find (symbol-value 'idna-program))
> - (length (defined-colors)))
> + (length (eval '(defined-colors))))
> - (>= (face-attribute 'default :height) 160))
> + (>= (eval '(face-attribute 'default :height)) 160))
Hm, IIRC last time we discussed this on emacs-devel, we decided not
to obscurify the code for the sake of calming the byte compiler.
Additionally...
,----[ (info "(gnus)Emacs/XEmacs Code") ]
| This means that Gnus will byte-compile under Emacs with nary a
| warning, while XEmacs will pump out gigabytes of warnings while
| byte-compiling. [...]
`----
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next parent reply other threads:[~2007-12-05 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1IzjR8-0001ME-00@quimby.gnus.org>
2007-12-05 20:10 ` Reiner Steib [this message]
2007-12-05 23:25 ` Avoiding compiler warnings Katsumi Yamaoka
2007-12-07 4:34 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9wsrsucl6.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).