From: Reiner Steib <reinersteib+from-uce@imap.cc>
To: Sven Joachim <svenjoac@gmx.de>
Cc: <ding@gnus.org>, Katsumi Yamaoka <yamaoka@jpl.org>, bugs@gnus.org
Subject: Re: gnus-article-hide-headers beeps: Buffer is read-only
Date: Sat, 04 Aug 2007 22:33:59 +0200 [thread overview]
Message-ID: <v9wswb6nuw.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <87d4y3mf3z.fsf@gmx.de> (Sven Joachim's message of "Sat, 04 Aug 2007 18:36:16 +0200")
On Sat, Aug 04 2007, Sven Joachim wrote:
> Gnus v5.11
> GNU Emacs 22.1.50.1 (i486-pc-linux-gnu, GTK+ Version 2.10.13)
> of 2007-07-31 on debian, modified by Debian
> 200 news.gmane.org InterNetNews NNRP server INN 2.4.1 ready (posting ok).
>
> When typing "W W h" in a *Summary* buffer, Emacs beeps and displays
> the error message: "Buffer is read-only: #<buffer *Article*>" (in
> *Messages* this shows up as
> "article-hide-headers: Buffer is read-only: #<buffer *Article*>").
>
> Enabling debug-on-error does not enter the debugger in this case.
Thanks for your report. Does the following patch fix it?
--8<---------------cut here---------------start------------->8---
--- gnus-art.el 04 Aug 2007 20:35:29 +0200 1.125.2.5
+++ gnus-art.el 04 Aug 2007 22:14:56 +0200
@@ -1743,7 +1743,7 @@
(interactive)
;; This function might be inhibited.
(unless gnus-inhibit-hiding
- (let ((inhibit-read-only nil)
+ (let ((inhibit-read-only t)
(case-fold-search t)
(max (1+ (length gnus-sorted-header-list)))
(inhibit-point-motion-hooks t)
--8<---------------cut here---------------end--------------->8---
Katsumi, the problem was introduced by this change ...
--8<---------------cut here---------------start------------->8---
revision 6.381.2.6
date: 2004/08/26 09:59:42; author: yamaoka; state: Exp; lines: +55 -47
[...]
* gnus-art.el (article-hide-headers): Refer to the values for
gnus-ignored-headers and gnus-visible-headers in the summary
buffer since a user may have set them as group parameters.
(gnus-article-read-summary-keys): Restore new window-start and
hscroll to summary window.
(gnus-prev-page-map): Remove duplicated one.
--8<---------------cut here---------------end--------------->8---
... and fixed in the trunk by Lars:
--8<---------------cut here---------------start------------->8---
revision 7.185
date: 2006/06/21 18:14:23; author: larsi; state: Exp; lines: +1 -1
* gnus-art.el (article-hide-headers): Inhibit read-only stuff.
--8<---------------cut here---------------end--------------->8---
I think the wrong value of inhibit-read-only was just a mistake
(replacing "buffer-read-only" with "inhibit-read-only"?). But the
ChangeLog doesn't say anything about removing (save-excursion
(save-restriction ...)).
I doubt the other occurrence of "(inhibit-read-only nil)" in
`gnus-x-splash' is correct. Is it?
--8<---------------cut here---------------start------------->8---
revision 7.17
date: 2007/06/07 11:59:35; author: yamaoka; state: Exp; lines: +79 -34
* gnus-ems.el (gnus-x-splash): Make it work.
--8<---------------cut here---------------end--------------->8---
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next parent reply other threads:[~2007-08-04 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87d4y3mf3z.fsf@gmx.de>
2007-08-04 20:33 ` Reiner Steib [this message]
2007-08-04 21:17 ` Sven Joachim
2007-08-06 1:46 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9wswb6nuw.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+from-uce@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=bugs@gnus.org \
--cc=ding@gnus.org \
--cc=svenjoac@gmx.de \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).