Re: Sticky article buffers

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Wed, Jul 25 2007, Tassilo Horn wrote:

> my assignment papers have arrived at the FSF. Here's my patch, [...]

Thank you.

> One thing that I'm aware of it that the binding `C-c s' is not too good,
> because bindings with `C-c' should be reserved for the user. 

We should not install it with `C-c s'.  If we can't find a better
binding, we can install it without a key binding first and add a
binding later.

> But what other free binding could be used?

If we stay with the term "sticky article buffer", I'd suggest `A S'.
Did you think about menu entries?  Sometimes this helps to find
similar command and key bindings.

> diff -r7.66 gnus.el
> 911a912,923

Oh, please use unified diff (-u) (or context diff (-c)).

> 4360a4373,4378
>> 
>> ;; Local Variables:
>> ;; coding: iso-8859-1
>> ;; indent-tabs-mode: t
>> ;; tab-width: 8
>> ;; End:

Please don't submit proposals that include unrelated changes.

>>     (define-key gnus-sticky-article-mode-map k nil))
>>   (define-key gnus-sticky-article-mode-map "q" 'gnus-sticky-article-kill-buffer)

I'd expect `k' for kill buffer and `q' for quit (bury buffer).

>>   (define-key gnus-sticky-article-mode-map "\C-hc" 'describe-key-briefly)
>>   (define-key gnus-sticky-article-mode-map "\C-hk" 'describe-key))

Why do we need to treat these two command specially?

>> (defun gnus-sticky-article-kill-buffer (&optional buffer)
>>   "Kills the given sticky article buffer. If none is given, it'll
>> assume the current buffer and kill it if it has
>> `gnus-sticky-article-mode'."
[...]
>> (defun gnus-summary-make-sticky-article (arg)
>>   "Make the current article sticky. If a prefix arg is given you
>> will be asked for a name for this sticky buffer."

The doc strings needs a little improvement.  Cf. `M-x checkdoc-defun
RET'.  But I may do this after installing the patch.

> 8089a8119,8124
>> 
>> ;; Local Variables:
>> ;; coding: iso-8859-1
>> ;; indent-tabs-mode: t
>> ;; tab-width: 8
>> ;; End:

Please don't include unrelated changes.  (Same for other
indent-tabs-mode/tab-width hunks below.)

> 1770a1771
>>   "\C-cs" gnus-summary-make-sticky-article

Should be removed/change.  See above.

> 2446a2448
>> 	     ["Make article buffer sticky" gnus-summary-make-sticky-article t]

Okay, a menu entry.  I'd too lazy to check where it would end up.  In
unified/context diff it would be easier to guess.  ;-)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/