EasyPG menu to mml.el update breaks XEmacs

EasyPG menu to mml.el update breaks XEmacs

[Dave Goldberg]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

After a fresh CVS update this morning I now get the attached backtrace
any time I try to send a mail (e.g. enter message-mode) on either

XEmacs 21.4 (patch 20) "Double Solitaire" [Lucid] (i686-pc-linux, Mule) of Mon Oct 22 2007 on dsg-laptop

It also happens with 21.4.21.

Unfortunately, I do not understand the easymenu-define function - my
one attempt to patch this also broke - so I cannot suggest a fix other
than, for now, backing out to CVS version 7.62 of mml.el.  If nothing
happens in the mean time, I will try again later when I'm done with
work.

Thanks,
-- 
Dave Goldberg
david.goldberg6@verizon.net

[-- Attachment #2: Type: text/plain, Size: 5673 bytes --]


Debugger entered--Lisp error: (error "unknown menu item keyword" :visible ["Externalize Attachments" (lambda nil (interactive) (setq gnus-gcc-externalize-attachments (not gnus-gcc-externalize-attachments)) (message "gnus-gcc-externalize-attachments is `%s'." gnus-gcc-externalize-attachments)) :visible (and (boundp (quote gnus-gcc-externalize-attachments)) (memq gnus-gcc-externalize-attachments (quote (all t nil)))) :style toggle :selected gnus-gcc-externalize-attachments])
  signal(error ("unknown menu item keyword" :visible ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ... ...) :style toggle :selected gnus-gcc-externalize-attachments]))
  check-menu-syntax(("Attachments" ["Attach File..." mml-attach-file t] ["Attach Buffer..." mml-attach-buffer t] ["Attach External..." mml-attach-external t] ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ... ...) :style toggle :selected gnus-gcc-externalize-attachments] "----" ("Change Security Method" ["PGP/MIME" ... :style radio :selected ...] ["S/MIME" ... :style radio :selected ...] ["Inline PGP" ... :style radio :selected ...]) ["Sign Message" mml-secure-message-sign t] ["Encrypt Message" mml-secure-message-encrypt t] ["Sign and Encrypt Message" mml-secure-message-sign-encrypt t] ["Encrypt/Sign off" mml-unsecure-message t] ["Sign Part" mml-secure-sign t] ["Encrypt Part" mml-secure-encrypt t] "----" ["Insert Part..." mml-insert-part :active (message-in-body-p)] ["Insert Multipart..." mml-insert-multipart :active (message-in-body-p)] ["Quote MML in region" mml-quote-region :active (message-mark-active-p)] ["Validate MML" mml-validate t] ["Preview" mml-preview t] "----" ["Emacs MIME manual" (lambda nil ... ...) t] ["PGG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t] ["EasyPG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t]) nil)
  add-submenu(nil ("Attachments" ["Attach File..." mml-attach-file t] ["Attach Buffer..." mml-attach-buffer t] ["Attach External..." mml-attach-external t] ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ... ...) :style toggle :selected gnus-gcc-externalize-attachments] "----" ("Change Security Method" ["PGP/MIME" ... :style radio :selected ...] ["S/MIME" ... :style radio :selected ...] ["Inline PGP" ... :style radio :selected ...]) ["Sign Message" mml-secure-message-sign t] ["Encrypt Message" mml-secure-message-encrypt t] ["Sign and Encrypt Message" mml-secure-message-sign-encrypt t] ["Encrypt/Sign off" mml-unsecure-message t] ["Sign Part" mml-secure-sign t] ["Encrypt Part" mml-secure-encrypt t] "----" ["Insert Part..." mml-insert-part :active (message-in-body-p)] ["Insert Multipart..." mml-insert-multipart :active (message-in-body-p)] ["Quote MML in region" mml-quote-region :active (message-mark-active-p)] ["Validate MML" mml-validate t] ["Preview" mml-preview t] "----" ["Emacs MIME manual" (lambda nil ... ...) t] ["PGG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t] ["EasyPG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t]) nil)
  add-menu(nil "Attachments" (["Attach File..." mml-attach-file t] ["Attach Buffer..." mml-attach-buffer t] ["Attach External..." mml-attach-external t] ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ... ...) :style toggle :selected gnus-gcc-externalize-attachments] "----" ("Change Security Method" ["PGP/MIME" ... :style radio :selected ...] ["S/MIME" ... :style radio :selected ...] ["Inline PGP" ... :style radio :selected ...]) ["Sign Message" mml-secure-message-sign t] ["Encrypt Message" mml-secure-message-encrypt t] ["Sign and Encrypt Message" mml-secure-message-sign-encrypt t] ["Encrypt/Sign off" mml-unsecure-message t] ["Sign Part" mml-secure-sign t] ["Encrypt Part" mml-secure-encrypt t] "----" ["Insert Part..." mml-insert-part :active (message-in-body-p)] ["Insert Multipart..." mml-insert-multipart :active (message-in-body-p)] ["Quote MML in region" mml-quote-region :active (message-mark-active-p)] ["Validate MML" mml-validate t] ["Preview" mml-preview t] "----" ["Emacs MIME manual" (lambda nil ... ...) t] ["PGG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t] ["EasyPG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t]))
  easy-menu-add(("Attachments" ["Attach File..." mml-attach-file t] ["Attach Buffer..." mml-attach-buffer t] ["Attach External..." mml-attach-external t] ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ... ...) :style toggle :selected gnus-gcc-externalize-attachments] "----" ("Change Security Method" ["PGP/MIME" ... :style radio :selected ...] ["S/MIME" ... :style radio :selected ...] ["Inline PGP" ... :style radio :selected ...]) ["Sign Message" mml-secure-message-sign t] ["Encrypt Message" mml-secure-message-encrypt t] ["Sign and Encrypt Message" mml-secure-message-sign-encrypt t] ["Encrypt/Sign off" mml-unsecure-message t] ["Sign Part" mml-secure-sign t] ["Encrypt Part" mml-secure-encrypt t] "----" ["Insert Part..." mml-insert-part :active (message-in-body-p)] ["Insert Multipart..." mml-insert-multipart :active (message-in-body-p)] ["Quote MML in region" mml-quote-region :active (message-mark-active-p)] ["Validate MML" mml-validate t] ["Preview" mml-preview t] "----" ["Emacs MIME manual" (lambda nil ... ...) t] ["PGG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t] ["EasyPG manual" (lambda nil ... ...) :visible (equal mml2015-use ...) t]) #<keymap size 1 0x3213>)
  mml-mode()
  message-mode()
  message-pop-to-buffer("*mail*" nil)
  message-mail()
  gnus-summary-mail-other-window(nil)
  call-interactively(gnus-summary-mail-other-window)

Re: EasyPG menu to mml.el update breaks XEmacs

[Reiner Steib]

On Thu, Mar 20 2008, Dave Goldberg wrote:

> After a fresh CVS update this morning I now get the attached backtrace
> any time I try to send a mail (e.g. enter message-mode) on either
>
> XEmacs 21.4 (patch 20) "Double Solitaire" [Lucid] (i686-pc-linux,
> Mule) of Mon Oct 22 2007 on dsg-laptop
>
> It also happens with 21.4.21.

Please ask the XEmacs guys about updating their easymenu package.

> Unfortunately, I do not understand the easymenu-define function - my
> one attempt to patch this also broke - so I cannot suggest a fix other
> than, for now, backing out to CVS version 7.62 of mml.el.  If nothing
> happens in the mean time, I will try again later when I'm done with
> work.

I tried to add a fix.  Please try again.  I don't have an XEmacs
installation of Gnus available to test it properly.  My simple test
"byte compile and load, M-x mml-mode RET, click on the Attachment
menu" ended in XEmacs (21.5.27) core dumping. :-/

If someone can come up with a better fix: Patches welcome.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: EasyPG menu to mml.el update breaks XEmacs

[Dave Goldberg]

>>>>> On Thu, 20 Mar 2008 19:19:51 +0100, Reiner Steib <reinersteib+gmane@imap.cc> said:

> On Thu, Mar 20 2008, Dave Goldberg wrote:
>> After a fresh CVS update this morning I now get the attached backtrace
>> any time I try to send a mail (e.g. enter message-mode) on either
>> 
>> XEmacs 21.4 (patch 20) "Double Solitaire" [Lucid] (i686-pc-linux,
>> Mule) of Mon Oct 22 2007 on dsg-laptop
>> 
>> It also happens with 21.4.21.

> Please ask the XEmacs guys about updating their easymenu package.

Hmm.  It's been some months since I downloaded a new sumo.  Perhaps that is my problem.  I will check that first.

>> Unfortunately, I do not understand the easymenu-define function - my
>> one attempt to patch this also broke - so I cannot suggest a fix other
>> than, for now, backing out to CVS version 7.62 of mml.el.  If nothing
>> happens in the mean time, I will try again later when I'm done with
>> work.

> I tried to add a fix.  Please try again.  I don't have an XEmacs
> installation of Gnus available to test it properly.  My simple test
> "byte compile and load, M-x mml-mode RET, click on the Attachment
> menu" ended in XEmacs (21.5.27) core dumping. :-/

> If someone can come up with a better fix: Patches welcome.

> Bye, Reiner.
> -- 
>        ,,,
>       (o o)
> ---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/


Thanks,

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: EasyPG menu to mml.el update breaks XEmacs

[Dave Goldberg]

>>>>> On Thu, 20 Mar 2008 16:26:31 -0400, Dave Goldberg <david.goldberg6@verizon.net> said:

>>>>> On Thu, 20 Mar 2008 19:19:51 +0100, Reiner Steib <reinersteib+gmane@imap.cc> said:
>> On Thu, Mar 20 2008, Dave Goldberg wrote:
>>> After a fresh CVS update this morning I now get the attached backtrace
>>> any time I try to send a mail (e.g. enter message-mode) on either
>>> 
>>> XEmacs 21.4 (patch 20) "Double Solitaire" [Lucid] (i686-pc-linux,
>>> Mule) of Mon Oct 22 2007 on dsg-laptop
>>> 
>>> It also happens with 21.4.21.

>> Please ask the XEmacs guys about updating their easymenu package.

> Hmm.  It's been some months since I downloaded a new sumo.  Perhaps
> that is my problem.  I will check that first.

Well so much for that - easymenu is not part of a separate package.

I will see how to get a message to the xemacs developers about
easymenu being out of date.  I don't follow their mailing lists.

The fix you committed to CVS has solved the problem for me, though.

Thanks,

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: EasyPG menu to mml.el update breaks XEmacs

[Reiner Steib]

On Thu, Mar 20 2008, Dave Goldberg wrote:

> Well so much for that - easymenu is not part of a separate package.

Probably it is in the xemacs-base package.  If you have a new sumo, it
should be the most recent one the maintainers provide.

> I will see how to get a message to the xemacs developers about
> easymenu being out of date.

On a second though, I'm not sure if it is outdated our an (intended)
incompatibility.  It would be nice to be able to remove all these
workarounds in Gnus (and AUCTeX) WRT easymenu someday, though.

> The fix you committed to CVS has solved the problem for me, though.

Good.  Thanks for your report.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: EasyPG menu to mml.el update breaks XEmacs

[Katsumi Yamaoka]

>>>>> Reiner Steib wrote:
> On Thu, Mar 20 2008, Dave Goldberg wrote:

>> Well so much for that - easymenu is not part of a separate package.

> Probably it is in the xemacs-base package.

No, it's in lisp/ .  But I tried the most recent No Gnus on
XEmacs 21.4.21 and have no such problem.

>>>>> Dave Goldberg wrote:
[...]
> Debugger entered--Lisp error: (error "unknown menu item keyword" :visible...
>   signal(error ("unknown menu item keyword" :visible ["Externalize Attach...
[...]
>   easy-menu-add(("Attachments" ["Attach File..." mml-attach-file t] ["Attac\
> h Buffer..." mml-attach-buffer t] ["Attach External..." mml-attach-external\
>  t] ["Externalize Attachments" (lambda nil ... ... ...) :visible (and ...
>   mml-mode()
>   message-mode()

I don't know why, but `:visible' should not appear there because
the source code has been designed so as not to use it as follows:

(easy-menu-define
  mml-menu mml-mode-map ""
[...]
     ,@(if (featurep 'xemacs) nil
	 '(:visible (and (boundp 'gnus-gcc-externalize-attachments)
			 (memq gnus-gcc-externalize-attachments
			       '(all t nil)))))

My guess is that your mml.elc was compiled by ?macs that returns
nil for (featurep 'xemacs).

Re: EasyPG menu to mml.el update breaks XEmacs

[Reiner Steib]

On Mon, Mar 24 2008, Katsumi Yamaoka wrote:

>>>>>> Dave Goldberg wrote:
> [...]
>> Debugger entered--Lisp error: (error "unknown menu item keyword" :visible...
>>   signal(error ("unknown menu item keyword" :visible ["Externalize Attach...
[...]
> I don't know why, but `:visible' should not appear there because
> the source code has been designed so as not to use it as follows:
>
> (easy-menu-define
>   mml-menu mml-mode-map ""
> [...]
>      ,@(if (featurep 'xemacs) nil
> 	 '(:visible (and (boundp 'gnus-gcc-externalize-attachments)

But that was after my 2008-03-20 change...

	* mml.el (mml-menu): Add workarounds for XEmacs.

... which fixed the problem for David as well.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/