From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64854 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Patch to change mouse binding for html view in gnus Date: Sun, 01 Jul 2007 23:48:19 +0200 Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1183326532 17530 80.91.229.12 (1 Jul 2007 21:48:52 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2007 21:48:52 +0000 (UTC) Cc: Emacs Hackers To: tromey@redhat.com, Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 01 23:48:49 2007 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I57Hh-0004B6-Td for ged-emacs-devel@m.gmane.org; Sun, 01 Jul 2007 23:48:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I57Hh-0001tT-E8 for ged-emacs-devel@m.gmane.org; Sun, 01 Jul 2007 17:48:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I57HW-0001qW-Vz for emacs-devel@gnu.org; Sun, 01 Jul 2007 17:48:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I57HV-0001pY-2U for emacs-devel@gnu.org; Sun, 01 Jul 2007 17:48:34 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I57HU-0001pV-Uv for emacs-devel@gnu.org; Sun, 01 Jul 2007 17:48:32 -0400 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I57HU-0007jP-8a for emacs-devel@gnu.org; Sun, 01 Jul 2007 17:48:32 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id l61LmSsZ018290; Sun, 1 Jul 2007 23:48:28 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.10.123]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id D4A3612A9C; Sun, 1 Jul 2007 23:48:27 +0200 (CEST) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T; w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv, vbL^XF1nIp\:F=$Ei2o&mEe:%N~, :3]vtQ~s9u$9izmX$IF@VgGl7/, ^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: tromey@redhat.com, , Emacs Hackers In-Reply-To: (Tom Tromey's message of "Sun, 01 Jul 2007 14:42:29 -0600") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) X-DCC-CTc-dcc2-Metrics: poseidon 1031; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-detected-kernel: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:74158 gmane.emacs.gnus.general:64854 Archived-At: [ Cc-ing the Gnus list; full quote. ] On Sun, Jul 01 2007, Tom Tromey wrote: > I have w3m installed, and so when Gnus sees an HTML message it is > displayed via w3m. This is quite nice. > > However, if I click on a link in an HTML message rendered this way, > the target is displayed using w3m. I generally don't want this; I > only use w3m in Emacs for specialized things and in other cases I'd > rather use my external web browser. I'm not sure if doing this unconditionally is a good idea. Shouldn't it be customizable? > This patch changes Gnus to use browse-url rather than w3m for links in > buffers it renders. > > Tom > > 2007-07-01 Tom Tromey > > * mm-view.el (mm-inline-text-html-render-with-w3m): Locally set > w3m-goto-article-function. > > cvs diff: Diffing . > Index: mm-view.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/gnus/mm-view.el,v > retrieving revision 1.29 > diff -u -r1.29 mm-view.el > --- mm-view.el 19 Apr 2007 12:08:53 -0000 1.29 > +++ mm-view.el 1 Jul 2007 20:58:45 -0000 > @@ -252,6 +252,7 @@ > (let ((w3m-safe-url-regexp mm-w3m-safe-url-regexp) > w3m-force-redisplay) > (w3m-region (point-min) (point-max) nil charset)) > + (set (make-local-variable 'w3m-goto-article-function) #'browse-url) > (when (and mm-inline-text-html-with-w3m-keymap > (boundp 'w3m-minor-mode-map) > w3m-minor-mode-map) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/