Highlighting of different citation levels in message-mode

Highlighting of different citation levels in message-mode

[Reiner Steib]

Hi,

I've added code from Oliver Scholz to highlight different citation
levels in message-mode, see `gnus-message-highlight-citation' in the
trunk.

After using it for a while, I'm not sure if we should let
`gnus-message-highlight-citation' default to t (in Emacs).  Sometimes
the headers weren't fontified correctly for me.  If it's on by
default, more people will find it and fix bugs.  But if there are too
many problems, we should disable it by default.

I'd like to hear other opinions on this: Should this feature be on or
off by default?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Highlighting of different citation levels in message-mode

[Norbert Koch]

* Reiner Steib <reinersteib+gmane@imap.cc>:

Hello Reiner,

> I've added code from Oliver Scholz to highlight different citation
> levels in message-mode, see `gnus-message-highlight-citation' in the
> trunk.


I'm not sure this change has caused it, but I now get a 

Debugger entered--Lisp error: (void-variable gnus-message-citation-mode)
  byte-code("..." [gnus-message-citation-mode define-minor-mode "Toggle `gnus-message-citation-mode' in current buffer.\nThis buffer local minor mode provides additional font-lock support for\nnested citations.\nWith prefix ARG, turn `gnus-message-citation-mode' on if and only if ARG is\npositive." nil "" gnus-message-add-citation-keywords gnus-message-remove-citation-keywords font-lock-fontify-buffer] 8)
  load-internal("gnus-cite" nil nil nil binary)
  load("gnus-cite" nil nil nil)
  gnus-article-highlight-citation()
  gnus-treat-article(nil 1 1)
  gnus-display-mime()
  gnus-article-prepare-display()
  gnus-article-prepare(19806 nil)
  gnus-summary-display-article(19806 nil)
  gnus-summary-select-article(nil nil pseudo)
  gnus-summary-scroll-up(1)
  call-interactively(gnus-summary-scroll-up)

when I look at a message.

Best regards,
norbert.

Re: Highlighting of different citation levels in message-mode

[Dave Goldberg]

I can confirm that this happened to me as well.  I backed out
gnus-cite.el and gnus-msg.el to the prior versions to fix it.
-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: Highlighting of different citation levels in message-mode

[Reiner Steib]

On Fri, Dec 29 2006, Dave Goldberg wrote:

> I can confirm that this happened to me as well.  I backed out
> gnus-cite.el and gnus-msg.el to the prior versions to fix it.

Especially when using a development version, it would make much more
sense to report the problem instead of silently reverting to older
revisions.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Highlighting of different citation levels in message-mode

[Dave Goldberg]

>>>>> On Sat, 30 Dec 2006 14:48:46 +0100, Reiner Steib <reinersteib+gmane@imap.cc> said:

> On Fri, Dec 29 2006, Dave Goldberg wrote:
>> I can confirm that this happened to me as well.  I backed out
>> gnus-cite.el and gnus-msg.el to the prior versions to fix it.

> Especially when using a development version, it would make much more
> sense to report the problem instead of silently reverting to older
> revisions.

Sorry, but I was at work and did not have time to try to trouble shoot
it any further so just got myself functional, fully intending to dig
into it and file a proper bug report (and hopefully a suggested fix)
when I got home.  When I did, I found that someone had already beaten
me to the report so I just confirmed it and noted my temporary
workaround in case it helps anyone else.

-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: Highlighting of different citation levels in message-mode

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

* Norbert Koch <viteno@xemacs.org> writes:

* Reiner Steib <reinersteib+gmane@imap.cc>:
  > Hello Reiner,

  >> I've added code from Oliver Scholz to highlight different citation
  >> levels in message-mode, see `gnus-message-highlight-citation' in the
  >> trunk.


  > I'm not sure this change has caused it, but I now get a 

  > Debugger entered--Lisp error: (void-variable gnus-message-citation-mode)

This should be fixed in CVS now.  Though I don't think
`gnus-message-citation-mode' will actually work in (S)XEmacs yet, but
at least it won't error anymore. :-)

-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|       SXEmacs - The only _______ you'll ever need.       |
|         Fill in the blank, yes, it's THAT good!          |
|------------------------------------<steve@sxemacs.org>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 312 bytes --]

Re: Highlighting of different citation levels in message-mode

[Norbert Koch]

* Steve Youngs <steve@sxemacs.org>:

Hi Steve!

> This should be fixed in CVS now.  Though I don't think
> `gnus-message-citation-mode' will actually work in (S)XEmacs yet, but
> at least it won't error anymore. :-)

Erm, I still get the same error message ... has your patch really made
it?

Thanks,
norbert.

Re: Highlighting of different citation levels in message-mode

[Steve Youngs]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

* Norbert Koch <viteno@xemacs.org> writes:

* Steve Youngs <steve@sxemacs.org>:
  > Hi Steve!

  >> This should be fixed in CVS now.  Though I don't think
  >> `gnus-message-citation-mode' will actually work in (S)XEmacs yet, but
  >> at least it won't error anymore. :-)

  > Erm, I still get the same error message ... has your patch really made
  > it?

Hmm, that's odd.  According to CVS it is in.  Check the top of
gnus-cite.el, it should have...

,----[ gnus-cite.el ]
| (eval-when-compile
|   (when (featurep 'xemacs)
|     (require 'easy-mmode))) ; for `define-minor-mode'
`----


-- 
|---<Steve Youngs>---------------<GnuPG KeyID: A94B3003>---|
|       SXEmacs - The only _______ you'll ever need.       |
|         Fill in the blank, yes, it's THAT good!          |
|------------------------------------<steve@sxemacs.org>---|

[-- Attachment #2: Type: application/pgp-signature, Size: 312 bytes --]

Re: Highlighting of different citation levels in message-mode

[Reiner Steib]

[ Resent ]

On Fri, Dec 29 2006, Norbert Koch wrote:

> * Reiner Steib <reinersteib+gmane@imap.cc>:
>> I've added code from Oliver Scholz to highlight different citation
>> levels in message-mode, see `gnus-message-highlight-citation' in the
>> trunk.
>
> I'm not sure this change has caused it, but I now get a 
>
> Debugger entered--Lisp error: (void-variable gnus-message-citation-mode)
>   byte-code("..." [gnus-message-citation-mode define-minor-mode
>   "Toggle `gnus-message-citation-mode' in current buffer. [...]
>   font-lock-fontify-buffer] 8)
>   load-internal("gnus-cite" nil nil nil binary)
>   load("gnus-cite" nil nil nil)
>   gnus-article-highlight-citation()
[...]
> when I look at a message.

It's surely this change that caused the problem.  Sorry for the
inconvenience.

I don't understand why, but `define-minor-mode' doesn't seem to work
as documented in XEmacs (21.4.15/Mule from SUSE 9.2) when
byte-compiling the file.  (Byte-compiling and loading a test file even
crashed XEmacs).

As a quick work-around, I'll wrap the code in (unless (featurep
'xemacs) ...) since the code doesn't work in XEmacs anyhow because it
needs `font-lock-add-keywords'.  Please report back if it fixed the
problem.

Maybe some (S)XEmacs user wants to implement this for (S)XEmacs?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/