Re: New GNOME icons

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Mar 14 2006, Bill Wohler wrote:

> Thanks. I've committed the updated image-load-path-for-library 

I've seen your changes on emacs-diffs:

,----
| ;; Avoid errors on Emacsen without `image-load-path'.
| (if (not (boundp 'image-load-path)) (defvar image-load-path nil))
`----

Please don't recommend to bind `image-load-path'.  Other packages
might test if `image-load-path' is bound only in Emacs versions that
really use it:

,----
| ELISP> (if (not (boundp 'image-load-path)) (defvar image-load-path nil))
| 
| image-load-path
| ELISP> (boundp 'image-load-path)
| t
`----

I'd suggest the following where the `image-load-path' won't be bound
outside the let expression.

(let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
       (image-load-path (cons (car load-path)
			      (when (boundp 'image-load-path)
				image-load-path))))
  (mh-tool-bar-folder-buttons-init))

,----
| ELISP> emacs-version
| "21.3.1"
| ELISP> (boundp 'image-load-path)
| nil
| ELISP> (defun image-load-path-for-library (&rest ignore)
| 	 load-path)
| image-load-path-for-library
| ELISP> (let* ((load-path (image-load-path-for-library "mh-e" "mh-logo.xpm"))
| 	      (image-load-path (cons (car load-path)
| 				     (when (boundp 'image-load-path)
| 				       image-load-path))))
| 	 image-load-path)
| ("/usr/share/emacs/site-lisp/xslide")
| 
| ELISP> (boundp 'image-load-path)
| nil
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642