* PGG: "NotDashEscaped: You need GnuPG to verify this message"
@ 2008-01-06 9:58 Reiner Steib
2008-01-06 12:23 ` Daiki Ueno
0 siblings, 1 reply; 6+ messages in thread
From: Reiner Steib @ 2008-01-06 9:58 UTC (permalink / raw)
To: Daiki Ueno; +Cc: ding
Hi,
when displaying Steve Young's message [1] in emacs-devel, I see the
following line at the top of the article buffer:
,----[ gnus-buttonized-mime-types -> nil ]
| NotDashEscaped: You need GnuPG to verify this message
`----
... or with (setq gnus-buttonized-mime-types '(".*/signed")):
,----[ gnus-buttonized-mime-types -> (".*/signed") ]
| [[PGP Signed Part:Undecided]]
| NotDashEscaped: You need GnuPG to verify this message
`----
According to the thread "NotDashEscaped, what?" in August 2007 [2]
the change [3] should have fixed this. I'm not sure if "fixed"
includes _not_ displaying the line "NotDashEscaped: You need GnuPG to
verify this message", but I think Gnus should hide it (same as hiding
"Hash: SHA1") in the normal display.
I'm using gpg (GnuPG) 1.4.5 and current Gnus trunk.
Bye, Reiner.
[1] <news:microsoft-free.86ve67n5vq.fsf@youngs.au.com>,
<news://news.gmane.org/gmane.emacs.devel/86268>
or your message <87ps141bsv.fsf@broken.deisui.org>.
[2] <http://thread.gmane.org/gmane.emacs.gnus.general/65087/focus=65109>
[3]
,----
| 2007-08-31 Daiki Ueno <ueno@unixuser.org>
|
| * mml2015.el (mml2015-extract-cleartext-signature): New function.
| (mml2015-mailcrypt-clear-verify): Use it.
| (mml2015-gpg-clear-verify): Use it.
| (mml2015-pgg-clear-verify): Use it.
| (mml2015-epg-clear-verify): Replace the current part with the output
| from GnuPG; don't extract the plaintext by itself.
|
| * mm-uu.el (mm-uu-pgp-beginning-signature): Abolish.
| (mm-uu-pgp-signed-extract-1): Bind coding-system-for-read when calling
| mml2015-clear-verify-function; don't touch the armor headers or
| dash-escaped text here.
`----
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PGG: "NotDashEscaped: You need GnuPG to verify this message"
2008-01-06 9:58 PGG: "NotDashEscaped: You need GnuPG to verify this message" Reiner Steib
@ 2008-01-06 12:23 ` Daiki Ueno
2008-01-06 14:10 ` Reiner Steib
0 siblings, 1 reply; 6+ messages in thread
From: Daiki Ueno @ 2008-01-06 12:23 UTC (permalink / raw)
To: Reiner Steib, ding
2008/1/6, Reiner Steib <reinersteib+gmane@imap.cc>:
> ,----[ gnus-buttonized-mime-types -> nil ]
> | NotDashEscaped: You need GnuPG to verify this message
> `----
[...]
> According to the thread "NotDashEscaped, what?" in August 2007 [2]
> the change [3] should have fixed this. I'm not sure if "fixed"
> includes _not_ displaying the line "NotDashEscaped: You need GnuPG to
> verify this message", but I think Gnus should hide it (same as hiding
> "Hash: SHA1") in the normal display.
As I recall, I did fix it for the EasyPG backend of mml2015 but didn't
touch the behavior of the PGG backend.
Regards,
--
Daiki Ueno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PGG: "NotDashEscaped: You need GnuPG to verify this message"
2008-01-06 12:23 ` Daiki Ueno
@ 2008-01-06 14:10 ` Reiner Steib
2008-01-07 3:22 ` Daiki Ueno
0 siblings, 1 reply; 6+ messages in thread
From: Reiner Steib @ 2008-01-06 14:10 UTC (permalink / raw)
To: Daiki Ueno; +Cc: ding
On Sun, Jan 06 2008, Daiki Ueno wrote:
> 2008/1/6, Reiner Steib <reinersteib+gmane@imap.cc>:
>> ,----[ gnus-buttonized-mime-types -> nil ]
>> | NotDashEscaped: You need GnuPG to verify this message
>> `----
> [...]
>> According to the thread "NotDashEscaped, what?" in August 2007 [2]
>> the change [3] should have fixed this. I'm not sure if "fixed"
>> includes _not_ displaying the line "NotDashEscaped: You need GnuPG to
>> verify this message", but I think Gnus should hide it (same as hiding
>> "Hash: SHA1") in the normal display.
>
> As I recall, I did fix it for the EasyPG backend of mml2015 but didn't
> touch the behavior of the PGG backend.
I don't known. The OP in, Michaël Cadilhac, didn't mention that he
uses EasyPG and the ChangeLog says you changed `mml2015-pgg-clear-verify'
as well.
Anyhow, I think it should be fixed for PGG as well (in v5-10/Emacs_22
and trunk/Emacs_23). Could you fix it, please?
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PGG: "NotDashEscaped: You need GnuPG to verify this message"
2008-01-06 14:10 ` Reiner Steib
@ 2008-01-07 3:22 ` Daiki Ueno
2008-01-07 22:02 ` Reiner Steib
0 siblings, 1 reply; 6+ messages in thread
From: Daiki Ueno @ 2008-01-07 3:22 UTC (permalink / raw)
To: Reiner Steib, Daiki Ueno, ding
2008/1/6, Reiner Steib <reinersteib+gmane@imap.cc>:
> > As I recall, I did fix it for the EasyPG backend of mml2015 but didn't
> > touch the behavior of the PGG backend.
>
> I don't known. The OP in, Michaël Cadilhac, didn't mention that he
> uses EasyPG and the ChangeLog says you changed `mml2015-pgg-clear-verify'
> as well.
I think that my ChangeLog entry is not clear.
* mml2015.el (mml2015-extract-cleartext-signature): New function.
(mml2015-mailcrypt-clear-verify): Use it.
(mml2015-gpg-clear-verify): Use it.
(mml2015-pgg-clear-verify): Use it.
(mml2015-epg-clear-verify): Replace the current part with the output
from GnuPG; don't extract the plaintext by itself.
should be:
* mml2015.el (mml2015-extract-cleartext-signature): New function which
is extracted from mm-uu-pgp-signed-extract-1 to keep the original
behavior of mailcrypt, gpg, pgg backends.
(mml2015-mailcrypt-clear-verify): Use it.
(mml2015-gpg-clear-verify): Use it.
(mml2015-pgg-clear-verify): Use it.
(mml2015-epg-clear-verify): Replace the current part with the output
from GnuPG; don't extract the plaintext by itself; note that this
function does not use mml2015-extract-cleartext-signature.
> Anyhow, I think it should be fixed for PGG as well (in v5-10/Emacs_22
> and trunk/Emacs_23). Could you fix it, please?
Since this seems not a critical problem, I think it is not so bad to
remain as it is, in order to encourage people to transition from PGG
to EasyPG. I don't mind if you work on fixing
mml2015-extract-cleartext-signature, though.
Regards,
--
Daiki Ueno
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PGG: "NotDashEscaped: You need GnuPG to verify this message"
2008-01-07 3:22 ` Daiki Ueno
@ 2008-01-07 22:02 ` Reiner Steib
2008-01-08 9:42 ` Daiki Ueno
0 siblings, 1 reply; 6+ messages in thread
From: Reiner Steib @ 2008-01-07 22:02 UTC (permalink / raw)
To: Daiki Ueno; +Cc: ding
On Mon, Jan 07 2008, Daiki Ueno wrote:
> I think that my ChangeLog entry is not clear.
Could you please install the improved text?
> I don't mind if you work on fixing
> mml2015-extract-cleartext-signature, though.
Is this (very naive) patch correct?
--8<---------------cut here---------------start------------->8---
--- mml2015.el.~7.49.~ 2007-12-16 14:25:36.000000000 +0100
+++ mml2015.el 2008-01-07 22:48:48.000000000 +0100
@@ -161,6 +161,8 @@
;; message.
(while (looking-at "Hash:") ; The only header allowed in cleartext
(forward-line)) ; signatures according to RFC2440.
+ (when (looking-at "NotDashEscaped: You need GnuPG to verify this message$")
+ (forward-line))
(when (looking-at "[\t ]*$")
(forward-line))
(delete-region (point-min) (point))
--8<---------------cut here---------------end--------------->8---
I'm not familiar with the mml2015.el code at all. After some my very
limited code read and test, I conclude that
`mml2015-extract-cleartext-signature' is only used to massage the
displayed text of the article buffer. Verification
(e.g. `mml2015-pgg-clear-verify') is done using the original
("un-massaged" text). Is that correct?
Could you please add a doc string to this function?
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PGG: "NotDashEscaped: You need GnuPG to verify this message"
2008-01-07 22:02 ` Reiner Steib
@ 2008-01-08 9:42 ` Daiki Ueno
0 siblings, 0 replies; 6+ messages in thread
From: Daiki Ueno @ 2008-01-08 9:42 UTC (permalink / raw)
To: Reiner Steib, ding
2008/1/8, Reiner Steib <reinersteib+gmane@imap.cc>:
> > I think that my ChangeLog entry is not clear.
>
> Could you please install the improved text?
I thought again, and concluded that the one I previously posted is too
descriptive.
> Is this (very naive) patch correct?
>
> + (when (looking-at "NotDashEscaped: You need GnuPG to verify this message$")
> + (forward-line))
Not exactly. You should disable unescaping dashes in this case.
Please read http://thread.gmane.org/gmane.emacs.gnus.general/65087/focus=65109
> I'm not familiar with the mml2015.el code at all. After some my very
> limited code read and test, I conclude that
> `mml2015-extract-cleartext-signature' is only used to massage the
> displayed text of the article buffer. Verification
> (e.g. `mml2015-pgg-clear-verify') is done using the original
> ("un-massaged" text). Is that correct?
Yes, but if the displayed text is different from the verified text,
what the purpose of digital signatures.
> Could you please add a doc string to this function?
I still believe that the right way is to use the plaintext output from
GnuPG as it is, and
mml2015-extract-cleartext-signature is just a kludge for misdesigned
libraries like PGG, which have no ability to do that. So, I think it
should not have descriptive documentation.
Regards,
--
Daiki Ueno
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-01-08 9:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-06 9:58 PGG: "NotDashEscaped: You need GnuPG to verify this message" Reiner Steib
2008-01-06 12:23 ` Daiki Ueno
2008-01-06 14:10 ` Reiner Steib
2008-01-07 3:22 ` Daiki Ueno
2008-01-07 22:02 ` Reiner Steib
2008-01-08 9:42 ` Daiki Ueno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).