From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65456 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Warning: `mapcar' called for effect; use `mapc' or `dolist' Date: Wed, 24 Oct 2007 21:28:56 +0200 Message-ID: References: <200710200643.l9K6h9gk021348@oogie-boogie.ics.uci.edu> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193254222 24107 80.91.229.12 (24 Oct 2007 19:30:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Oct 2007 19:30:22 +0000 (UTC) Cc: ding@gnus.org, emacs-devel@gnu.org To: Katsumi Yamaoka Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 24 21:30:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iklvk-0004Gf-Lw for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2007 21:30:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iklvc-0007Dr-3s for ged-emacs-devel@m.gmane.org; Wed, 24 Oct 2007 15:30:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IklvD-0006s9-Cz for emacs-devel@gnu.org; Wed, 24 Oct 2007 15:29:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IklvB-0006qC-MC for emacs-devel@gnu.org; Wed, 24 Oct 2007 15:29:42 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IklvB-0006pz-F1 for emacs-devel@gnu.org; Wed, 24 Oct 2007 15:29:41 -0400 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IklvA-00040u-Vc for emacs-devel@gnu.org; Wed, 24 Oct 2007 15:29:41 -0400 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.1/8.14.1) with ESMTP id l9OJTatP019464; Wed, 24 Oct 2007 21:29:37 +0200 (MEST) Original-Received: from localhost (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id C3B841C456; Wed, 24 Oct 2007 21:29:36 +0200 (CEST) X-Face: /U7=m^"/-Dn61mAl{g9e3>\G5Tp,oEX|V)g2I1hBk\ML; )7A?6cmB-y7y?'NA^J<=oz7syB =(McAwIHgLX!.B?R3X}98d@?>CrT094KLWh]WU4gDpnL/")MS(XoQTv`Oq225uL>+; CpPXo$N5e>N> $tPd-gbB^F{gQS#1ase]XO~D4p4M"3+F-7~u]dy3I?Pb8RO*H-EFeWDUf?Rf, d]pv\Jvh2Cht!A=im yKAS2Z%Ao^;}W/qzMvMm Mail-Followup-To: Katsumi Yamaoka , ding@gnus.org, In-Reply-To: (Katsumi Yamaoka's message of "Mon, 22 Oct 2007 21:13:39 +0900") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-DCC-HP_X86_64_8CPU-Metrics: poseidon 1245; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81659 gmane.emacs.gnus.general:65456 Archived-At: On Mon, Oct 22 2007, Katsumi Yamaoka wrote: >>>>>> Dan Nicolaescu wrote: >> Assuming that all emacs versions that gnus wants to support have >> either mapc or dolist, can somebody please take care of these >> warnings? [...] > With No Gnus v0.7 I did `cd lisp; make warn' and tried replacing > of `mapcar' with `mapc', `dolist', or `while' loops for a while, > and realized it's not easy and not safe. Ones who do it will > need to study what things using `mapcar' do in all cases. Thank you for working on this. However, you also committed it to v5-10. As using `mapcar' is not a bug and the changes might break the code, I'd prefer to install these changes only in Gnus trunk (which will eventually be synced to Emacs trunk), but not in v5-10 (and Emacs 22) unless there are other arguments. An argument could be to keep the code in trunk and v5-10 as close as possible. A counter argument is that Lars suggested not to break compatibility (with Emacs 20.7) actively: ,----[ http://thread.gmane.org/gmane.emacs.gnus.general/62286/focus=62770 ] | Reiner Steib imap.cc> writes: | | > Do you suggest to rip out Emacs 20/XEmacs 21.1 stuff systematically | > like it was done after the start of No Gnus (mostly by Jesper and | > Katsumi [2]) or only drop it on occasion? | | For 5.10, I think it's better to just let it decay instead of removing | it actively. `---- Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/