message-remove-duplicates and gnus-remove-duplicates (was: Changes committed gnus/lisp (ChangeLog gnus-art.el message.el))

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Sep 27 2005, Simon Josefsson committed:

> 2005-09-27  Arne Jørgensen  <arne@arnested.dk>
>
> 	* message.el (message-remove-duplicates): New function.
> 	Implementation borrowed from `gnus-remove-duplicates'.
[...]
> +(defun message-remove-duplicates (list)
> +  (let (new)
> +    (while list
> +      (or (member (car list) new)
> +	  (setq new (cons (car list) new)))
> +      (setq list (cdr list)))
> +    (nreverse new)))

Shouldn't we drop (or defalias) `gnus-remove-duplicates' in favor of
`message-remove-duplicates'?  (We can safely require `message.el' in
Gnus code but not the other way round.)

,----
| grep -nH -e "[se]-remove-duplicates" *.el
| gnus-util.el:1033:(defun gnus-remove-duplicates (list)
| message.el:2093:(defun message-remove-duplicates (list)
| message.el:5041:	       (message-remove-duplicates
| nnmail.el:1144:	      (setq split (gnus-remove-duplicates split))
`----

nnmail.el (the only use of gnus-remove-duplicates) already requires
message.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/