From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61037 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: message-remove-duplicates and gnus-remove-duplicates (was: Changes committed gnus/lisp (ChangeLog gnus-art.el message.el)) Date: Wed, 28 Sep 2005 16:25:25 +0200 Organization: Dept. of Theoretical Physics, University of Ulm Message-ID: References: Reply-To: Reiner Steib NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1127918206 3107 80.91.229.2 (28 Sep 2005 14:36:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2005 14:36:46 +0000 (UTC) Original-X-From: ding-owner+m9569@lists.math.uh.edu Wed Sep 28 16:36:45 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EKd2U-0005JB-Lk for ding-account@gmane.org; Wed, 28 Sep 2005 16:36:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EKd2M-0004fq-00; Wed, 28 Sep 2005 09:35:58 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EKcxL-0004fl-00 for ding@lists.math.uh.edu; Wed, 28 Sep 2005 09:30:47 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1EKcxH-0000KM-3P for ding@lists.math.uh.edu; Wed, 28 Sep 2005 09:30:47 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EKcxF-0000bV-00 for ; Wed, 28 Sep 2005 16:30:41 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EKcuV-0002T4-8v for ding@gnus.org; Wed, 28 Sep 2005 16:27:51 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de ([134.60.10.123]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Sep 2005 16:27:51 +0200 Original-Received: from Reiner.Steib by bridgekeeper.physik.uni-ulm.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 28 Sep 2005 16:27:51 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-To: ding@gnus.org Original-Lines: 35 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: bridgekeeper.physik.uni-ulm.de X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Copies-To: nobody User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:WzIavu5rC9OfXsZDYTufYIOq2po= X-Spam-Score: -2.3 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61037 Archived-At: On Tue, Sep 27 2005, Simon Josefsson committed: > 2005-09-27 Arne Jørgensen > > * message.el (message-remove-duplicates): New function. > Implementation borrowed from `gnus-remove-duplicates'. [...] > +(defun message-remove-duplicates (list) > + (let (new) > + (while list > + (or (member (car list) new) > + (setq new (cons (car list) new))) > + (setq list (cdr list))) > + (nreverse new))) Shouldn't we drop (or defalias) `gnus-remove-duplicates' in favor of `message-remove-duplicates'? (We can safely require `message.el' in Gnus code but not the other way round.) ,---- | grep -nH -e "[se]-remove-duplicates" *.el | gnus-util.el:1033:(defun gnus-remove-duplicates (list) | message.el:2093:(defun message-remove-duplicates (list) | message.el:5041: (message-remove-duplicates | nnmail.el:1144: (setq split (gnus-remove-duplicates split)) `---- nnmail.el (the only use of gnus-remove-duplicates) already requires message. Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/