Re: spam.el mega patch

[Reiner Steib <4.uce.03.r.s@nurfuerspam.de>]

On Mon, Nov 24 2003, Ted Zlatanov wrote:

>  ;;;; Spam-report glue
> -(defun spam-report-gmane-register-routine ()
> -  (spam-generic-register-routine
> -   'spam-report-gmane
> -   nil))
> +(defun spam-report-gmane-register-routine (articles)
> +  (apply 'spam-report-gmane articles))

`apply' fails here when `articles' is nil:

,----
| ELISP> (defun rs-1 (arg)
| 	 t)
| rs-1
| ELISP> (rs-1 nil)
| t
| ELISP> (apply 'rs-1 nil)
| *** Eval error ***  Wrong number of arguments: (lambda (arg) t), 0
| ELISP> 
`----

I don't know what's better: Calling `spam-report-gmane' only if
`articles' is non-nil[1], making `articles' in `spam-report-gmane'
optional[2] or use something else (what?) instead of `apply'.

[1]
(defun spam-report-gmane-register-routine (articles)
  (when articles
    (apply 'spam-report-gmane articles)))

[2]
(defun spam-report-gmane (&optional article)
  "Report an article as spam through Gmane"
  (interactive "nEnter the article number: ")
  (when (and article
	     gnus-newsgroup-name
  [...])))

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/