Gnus development mailing list
 help / color / mirror / Atom feed
* 0.27, gnus-summary-move-article
@ 1996-01-17 16:34 Kai Grossjohann
  0 siblings, 0 replies; only message in thread
From: Kai Grossjohann @ 1996-01-17 16:34 UTC (permalink / raw)


Hi,

why did the function change from 0.26 to 0.27?  I reverted the change
and everything was dandy.  In the diff below, search for `;;-' to see
what I'm talking about.  Seems like (car (car marks)) has been
replaced with (cadr marks) but should have been (caar marks).

        kai
--
   |      _,,,---,,_
   /,`.-'`'    -.  ;-;;,_
  |,4-  ) )-,_..; (  `'-'
 '---''(_/--'  `-'_)  fL


C-u M-! diff -bwc gnus.el gnus.el-orig

*** /usr/local/ls6/share/emacs/site-lisp/sgnus-0.27/gnus.el	Wed Jan 17 17:22:07 1996
--- /usr/local/ls6/src/emacs-lisp/sgnus-0.27/lisp/gnus.el	Tue Jan 16 21:38:20 1996
***************
*** 10729,10735 ****
    (gnus-summary-select-article)
    (gnus-eval-in-buffer-window gnus-article-buffer (widen)))
  
- 
  (defun gnus-summary-move-article (&optional n to-newsgroup select-method action)
    "Move the current article to a different newsgroup.
  If N is a positive number, move the N next articles.
--- 10729,10734 ----
***************
*** 10747,10758 ****
    (gnus-set-global-variables)
    ;; Check whether the source group supports the required functions.
    (cond ((and (eq action 'move)
! 	      (not (gnus-check-backend-function
!                     'request-move-article gnus-newsgroup-name)))
  	 (error "The current group does not support article moving"))
  	((and (eq action 'crosspost)
! 	      (not (gnus-check-backend-function
!                     'request-replace-article gnus-newsgroup-name)))
  	 (error "The current group does not support article editing")))
    (let ((articles (gnus-summary-work-articles n))
  	(prefix (gnus-group-real-prefix gnus-newsgroup-name))
--- 10746,10757 ----
    (gnus-set-global-variables)
    ;; Check whether the source group supports the required functions.
    (cond ((and (eq action 'move)
! 	      (gnus-check-backend-function
! 	       'request-move-article gnus-newsgroup-name))
  	 (error "The current group does not support article moving"))
  	((and (eq action 'crosspost)
! 	      (gnus-check-backend-function
! 	       'request-replace-article gnus-newsgroup-name))
  	 (error "The current group does not support article editing")))
    (let ((articles (gnus-summary-work-articles n))
  	(prefix (gnus-group-real-prefix gnus-newsgroup-name))
***************
*** 10867,10873 ****
  				       (intern (format "gnus-newsgroup-%s"
  						       (caar marks)))))
  		    (gnus-add-marked-articles
! 		     (gnus-info-group info) (car (car marks)) ;;-(cadr marks)
  		     (list to-article) info))
  		  (setq marks (cdr marks)))))
  
--- 10866,10872 ----
  				       (intern (format "gnus-newsgroup-%s"
  						       (caar marks)))))
  		    (gnus-add-marked-articles
! 		     (gnus-info-group info) (cadr marks)
  		     (list to-article) info))
  		  (setq marks (cdr marks)))))
  
***************
*** 10886,10892 ****
  
  	(gnus-summary-goto-subject article)
  	(gnus-summary-mark-article article gnus-canceled-mark))
!       (and (car articles) (gnus-summary-remove-process-mark (car articles))))
      (gnus-kill-buffer copy-buf)
      (gnus-set-mode-line 'summary)))
  
--- 10885,10891 ----
  
  	(gnus-summary-goto-subject article)
  	(gnus-summary-mark-article article gnus-canceled-mark))
!       (gnus-summary-remove-process-mark (car articles)))
      (gnus-kill-buffer copy-buf)
      (gnus-set-mode-line 'summary)))
  
***************
*** 13132,13144 ****
  			   (mail-fetch-field "newsgroups"))
  		(gnus-article-hide-header "followup-to")))
  	     ((eq elem 'reply-to)
!               ;;- Kai added stringp tests here
! 	      (when (and (stringp (mail-fetch-field "from"))
!                          (stringp (mail-fetch-field "reply-to"))
!                          (equal (nth 1 (mail-extract-address-components
                                          (mail-fetch-field "from")))
                                  (nth 1 (mail-extract-address-components
!                                         (mail-fetch-field "reply-to")))))
  		(gnus-article-hide-header "reply-to")))
  	     ((eq elem 'date)
  	      (let ((date (mail-fetch-field "date")))
--- 13131,13140 ----
  			   (mail-fetch-field "newsgroups"))
  		(gnus-article-hide-header "followup-to")))
  	     ((eq elem 'reply-to)
! 	      (when (equal (nth 1 (mail-extract-address-components
  				   (mail-fetch-field "from")))
  			   (nth 1 (mail-extract-address-components
! 				   (mail-fetch-field "reply-to"))))
  		(gnus-article-hide-header "reply-to")))
  	     ((eq elem 'date)
  	      (let ((date (mail-fetch-field "date")))


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~1996-01-17 16:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-01-17 16:34 0.27, gnus-summary-move-article Kai Grossjohann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).