Untabify...?

Untabify...?

[Hrvoje Niksic]

After upgrading to pgnus-0.76, I've noticed an "untabify: done"
modeline message after an article has been shipped off.  When was this 
"untabification" added, and why?  Can I turn it off?

(It might be a good idea to untabify articles before sending them, but 
it might not be what I want to do, and it got added pretty silently,
so it kind of worries me.)

Re: Untabify...?

[Andreas Jaeger]

>>>>> Hrvoje Niksic writes:

 > After upgrading to pgnus-0.76, I've noticed an "untabify: done"
 > modeline message after an article has been shipped off.  When was this 
 > "untabification" added, and why?  Can I turn it off?

 > (It might be a good idea to untabify articles before sending them, but 
 > it might not be what I want to do, and it got added pretty silently,
 > so it kind of worries me.)

I just noticed the same - and it's annoying for me since I insert
(without any mime headers) often program diff's which contain a number
of tabs.  Untabifying those doesn't let others apply my diff file
cleanly:-(.

Please add a flag to turn this off and on.

Andreas

P.S. Here's the ChangeLog entry:
1999-02-03 00:31:21  Lars Magne Ingebrigtsen  <larsi@gnus.org>

      * gnus-start.el: Ignore some groups.
      (gnus-setup-news): Bind nnmail-fetched-sources.

      * message.el (message-send-mail): Remove all tabs.

-- 
 Andreas Jaeger   aj@arthur.rhein-neckar.de    jaeger@informatik.uni-kl.de
  for pgp-key finger ajaeger@aixd1.rhrk.uni-kl.de

Re: Untabify...?

[Edward J. Sabol]

Excerpts from mail: (15-Feb-99) Re: Untabify...? by Stainless Steel Rat
> * Andreas Jaeger <aj@arthur.rhein-neckar.de> 15 Feb 1999 09:33:51 +0100
> | Untabifying those doesn't let others apply my diff file cleanly:-(.
>
> It is also bad in that it can corrupt PGP/GPG signatures, which have been
> made before untabify is called.
>
> | Please add a flag to turn this off and on.
>
> Rather, please make it off by default so as not to seriously break things
> that have been known to work.

I'm in total agreement here. I don't like the untabifying for mail either. (I
think news requires it?) Lars, please either get rid of it or make it
optional.

Thanks,
Ed

Re: Untabify...?

[Per Abrahamsen]

Stainless Steel Rat <ratinox@peorth.gweep.net> writes:

> Rather, please make it off by default so as not to seriously break things
> that have been known to work.

I agree it should be off by default, or should not even be an option.

However, message mode should turn off indent-tabs-mode, so the user is
less likely to accidentally add tabs to the message (which will most
likely be displayed wrong on other newsreaders).  Explictly inserted
tabs (with C-q TAB), and tabs in included files, will (and should)
still be there.

Here is a patch for both.

1999-02-17  Per Abrahamsen  <abraham@dina.kvl.dk>

	* message.el (message-send-mail): Don't untabify.
	(message-mode): Don't use tabs for indentation.

cd ~/emacs/pgnus-0.76/lisp/
diff -c message-old.el message.el
*** message-old.el	Thu Feb 11 06:02:23 1999
--- message.el	Wed Feb 17 12:06:25 1999
***************
*** 1444,1449 ****
--- 1444,1451 ----
  	(concat "[ \t]*[-a-z0-9A-Z]*>+[ \t]*\\|"
  		adaptive-fill-first-line-regexp))
    (mm-enable-multibyte)
+   (make-local-variable 'indent-tabs-mode) ;Turn off tabs for indentation.
+   (setq indent-tabs-mode nil)
    (run-hooks 'text-mode-hook 'message-mode-hook))
  
  \f
***************
*** 2093,2099 ****
        (let ((message-deletable-headers
  	     (if news nil message-deletable-headers)))
  	(message-generate-headers message-required-mail-headers))
-       (untabify (point-min) (point-max))
        (let ((mail-parse-charset message-posting-charset))
  	(mail-encode-encoded-word-buffer))
        ;; Let the user do all of the above.
--- 2095,2100 ----

Compilation exited abnormally with code 1 at Wed Feb 17 12:06:53

Re: Untabify...?

[Kai.Grossjohann]

Per Abrahamsen <abraham@dina.kvl.dk> writes:

  > [...] add tabs to the message (which will most likely be displayed
  > wrong on other newsreaders). [...]

Why?  In what way will they be displayed?

kai
-- 
I like _\bb_\bo_\bt_\bh kinds of music.

Re: Untabify...?

[Steinar Bang]

>>>>> Kai.Grossjohann@CS.Uni-Dortmund.DE:

> Per Abrahamsen <abraham@dina.kvl.dk> writes:
>> [...] add tabs to the message (which will most likely be displayed
>> wrong on other newsreaders). [...]

> Why?  In what way will they be displayed?

In some newsreaders as 4 column indentations, in others as 8 column
indentations, in yet others as <undisplayablecharacter> (blackened
square, open square, whatever...), I'd guess...

Re: Untabify...?

[Hrvoje Niksic]

Per Abrahamsen <abraham@dina.kvl.dk> writes:
[...]
> Compilation exited abnormally with code 1 at Wed Feb 17 12:06:53

Is this an Emacs bug, or is there an (ir)ration explanation how this
got in your message?

Re: Untabify...?

[Per Abrahamsen]

Hrvoje Niksic <hniksic@srce.hr> writes:

> Per Abrahamsen <abraham@dina.kvl.dk> writes:
> [...]
> > Compilation exited abnormally with code 1 at Wed Feb 17 12:06:53
> 
> Is this an Emacs bug, or is there an (ir)ration explanation how this
> got in your message?

I always use `compile' to generate patches, and `insert-buffer' to
insert the patch in the message buffer.  Since `patch' has no problems
with trailing text, and I'm likely to break something if I fiddle with
the text manually, I don't.

Re: Untabify...?

[Lars Magne Ingebrigtsen]

Stainless Steel Rat <ratinox@peorth.gweep.net> writes:

> | Please add a flag to turn this off and on.
> 
> Rather, please make it off by default so as not to seriously break things
> that have been known to work.

I've now removed the untabify.  I can't really recall why I added it
-- it seems like a, er, not-very-smart thing to do.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen