citation and flow-filling

citation and flow-filling

[Paul Jarc]

When flow-filling an article with quoted material, Gnus treats space
as a non-quote character, even when it is followed by a quote
character (">") and is preceded by only quote characters.  This is
what RFC 2646 says it ought to do, but in practice, it breaks.  Gnus
actually breaks this itself, because when quoting, "> " is prepended
to each line.  If the line already starts with a quoting character,
then only ">" should be prepended.

Can either of these already be configured the way I want them?  I see
message-cite-prefix-regexp, but I don't think it's used for
flow-filling, or citation in replies.  If not, I'd be happy to add the
code, if someone can point me in the right direction.

Also, is there an existing function I can add to message-send-hook or
some such to make my messages format=flowed?


paul

Re: citation and flow-filling

[Kai Großjohann]

If you want to replace "> > " in multi-level quoting with ">> ", then
may I suggest Trivial Cite (tc.el) which does this?

kai
-- 
~/.signature: No such file or directory

Re: citation and flow-filling

[Simon Josefsson]

prj@po.cwru.edu (Paul Jarc) writes:

> When flow-filling an article with quoted material, Gnus treats space
> as a non-quote character, even when it is followed by a quote
> character (">") and is preceded by only quote characters.  This is
> what RFC 2646 says it ought to do, but in practice, it breaks.  Gnus
> actually breaks this itself, because when quoting, "> " is prepended
> to each line.  If the line already starts with a quoting character,
> then only ">" should be prepended.

Yes.  Try attached patch.

> I see message-cite-prefix-regexp, but I don't think it's used for
> flow-filling, or citation in replies.  If not, I'd be happy to add
> the code, if someone can point me in the right direction.

I don't think it should be used in flow-filling (it has it's own hard
coded rules to match rfc2646), but the patch below makes use of it
when indenting messages.

> Also, is there an existing function I can add to message-send-hook or
> some such to make my messages format=flowed?

Until emacs support visual cues for soft and hard line breaks, I see
little point of adding support for it in Gnus -- I mean, how would you
know if a paragraph contained soft or hard line breaks when you edit
it?

I do find it quite amazing that emacs doesn't support visual cues for
TAB, soft/hard linebreaks etc though.  I mean, I bet even vi supports
this.  (Lete the flame war begin... :-))

--- message.el.~6.82.~	Wed May 16 20:52:26 2001
+++ message.el	Wed May 23 21:33:16 2001
@@ -523,6 +523,12 @@
   :type 'string
   :group 'message-insertion)
 
+(defcustom message-yank-cited-prefix ">"
+  "*Prefix inserted on cited lines of yanked messages.
+Fix `message-cite-prefix-regexp' if it is set to an abnormal value."
+  :type 'string
+  :group 'message-insertion)
+
 (defcustom message-indentation-spaces 3
   "*Number of spaces to insert at the beginning of each cited line.
 Used by `message-yank-original' via `message-yank-cite'."
@@ -2074,7 +2080,9 @@
       (save-excursion
 	(goto-char start)
 	(while (< (point) (mark t))
-	  (insert message-yank-prefix)
+	  (if (looking-at message-cite-prefix-regexp)
+	      (insert message-yank-cited-prefix)
+	    (insert message-yank-prefix))
 	  (forward-line 1))))
     (goto-char start)))
 

Re: citation and flow-filling

[Paul Jarc]

Simon Josefsson <simon@josefsson.org> writes:
> prj@po.cwru.edu (Paul Jarc) writes:
>> If the line already starts with a quoting character, then only ">"
>> should be prepended.
> 
> Yes.  Try attached patch.

Works nicely.  Will this be committed?

>> I see message-cite-prefix-regexp, but I don't think it's used for
>> flow-filling, or citation in replies.  If not, I'd be happy to add
>> the code, if someone can point me in the right direction.
> 
> I don't think it should be used in flow-filling (it has it's own hard
> coded rules to match rfc2646),

Well, I'd like to be able to make Gnus violate 2646 in this way.  I
guess I would have to hack fill-flowed to do this, hm?

>> Also, is there an existing function I can add to message-send-hook or
>> some such to make my messages format=flowed?
> 
> Until emacs support visual cues for soft and hard line breaks, I see
> little point of adding support for it in Gnus -- I mean, how would you
> know if a paragraph contained soft or hard line breaks when you edit
> it?

I'd be satisfied with something that added a space at the end of each
body line not followed by a blank line, and which added
"Content-Type: text/plain; format=flowed" to the header.

If any part of a message would suffer from this treatment, then I'd
disable the hook entirely for just that message and send it as
format=fixed.


paul

Re: citation and flow-filling

[Kai Großjohann]

On 23 May 2001, Simon Josefsson wrote:

> Until emacs support visual cues for soft and hard line breaks, I see
> little point of adding support for it in Gnus -- I mean, how would
> you know if a paragraph contained soft or hard line breaks when you
> edit it?

Other editors also provide editing this kind of file, without any
visual cues.  As an example, see xpostit.

kai
-- 
~/.signature: No such file or directory

Re: citation and flow-filling

[Lloyd Zusman]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> On 23 May 2001, Lloyd Zusman wrote:
> 
> > Does anyone know where the latest, official version of `tc.el' can
> > be found?  The latest one I was able to find on the net is
> > `tc.v0.11.6.el' from March, 1998.  Are there any newer versions?
> 
> No, that version isn't from March, 1998.  The first version of tc.el
> is from that date (that's when tc.el was created).  The header doesn't
> say how old tc.el 0.11.6 is.
> 
> This is the most recent official version, afaik.  I have a patch to
> make it work with transient mark mode in Emacs (see below signature).

Thanks.  I'll apply this patch.


> Btw, your msg was addressed to me only, but `Does anyone know...'
> suggests that you intended to send it to the list.
> 
> kai

Yes, that indeed was my intention.  It seems that in recent CVS
versions of Gnus (as of a couple days ago), the "To Address" and "To
List" "Gnus Customize" variables no longer work.

Any ideas as to why?

I'm manually sending this to the group.


> -- 
> ~/.signature: No such file or directory
>
> [ ... ]

-- 
 Lloyd Zusman
 ljz@asfast.com
 God bless you.

Re: citation and flow-filling

[Lloyd Zusman]

Lloyd Zusman <ljz@asfast.com> writes:

> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
> [ ... ]
>
> > Btw, your msg was addressed to me only, but `Does anyone know...'
> > suggests that you intended to send it to the list.
> > 
> > kai
> 
> Yes, that indeed was my intention.  It seems that in recent CVS
> versions of Gnus (as of a couple days ago), the "To Address" and "To
> List" "Gnus Customize" variables no longer work.
> 
> Any ideas as to why?

I'm answering my own question: it was due to an error in my
`.gnus.el', which I have now fixed.  "To Address" and "To List" work
just fine.

As Emily Latella would say ... "Never mind".


> [ ... ]

-- 
 Lloyd Zusman
 ljz@asfast.com

Re: citation and flow-filling

[Simon Josefsson]

prj@po.cwru.edu (Paul Jarc) writes:

>>> If the line already starts with a quoting character, then only ">"
>>> should be prepended.
>> 
>> Yes.  Try attached patch.
> 
> Works nicely.  Will this be committed?

Committed.

>> I don't think it should be used in flow-filling (it has it's own hard
>> coded rules to match rfc2646),
> 
> Well, I'd like to be able to make Gnus violate 2646 in this way.  I
> guess I would have to hack fill-flowed to do this, hm?

Yes.  If you think it would be useful for others, perhaps you could
submit a patch to make it customizable?

> I'd be satisfied with something that added a space at the end of each
> body line not followed by a blank line, and which added
> "Content-Type: text/plain; format=flowed" to the header.
> 
> If any part of a message would suffer from this treatment, then I'd
> disable the hook entirely for just that message and send it as
> format=fixed.

It shouldn't be hard to write a hook and attach it to
`message-send-mail-hook' or something, I think.

Re: citation and flow-filling

[Hal Snyder]

simon@josefsson.org (Simon Josefsson) writes:

> prj@po.cwru.edu (Paul Jarc) writes:
> 
>>>> If the line already starts with a quoting character, then only ">"
>>>> should be prepended.
>>> 
>>> Yes.  Try attached patch.
>> 
>> Works nicely.  Will this be committed?
> 
> Committed.

Just wanted to say thanks. I've been using the citation patch for a
few days. Nice work!