C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Neil Crellin]

In one of the recent CVS releases, I seem to have lost the ability to
use mml-attach-file from the C-c C-a binding.  C-h m claims that C-c C-a
is mml-attach-file, but C-h k says it's mail-interactive-insert-alias.
Any ideas on what changed and how to revert it?

-- 
Neil Crellin <neilc@wallaby.cc>

Re: C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Andreas Fuchs]

Today, Neil Crellin <neilc@wallaby.cc> wrote:
> In one of the recent CVS releases, I seem to have lost the ability to
> use mml-attach-file from the C-c C-a binding.  C-h m claims that C-c C-a
> is mml-attach-file, but C-h k says it's mail-interactive-insert-alias.
> Any ideas on what changed and how to revert it?

Could it be that you have
(add-hook 'message-setup-hook 'bbdb-define-all-aliases)
(or something similar) in your config file? In the C-h k docs to C-c
C-a, mail-abbrevs is named as the origin of
mail-interactive-insert-alias.

I'd say that you could add:

(add-hook 'message-mode-hook
          (lambda () (define-key message-mode-map
                                "\C-c\C-a" 'mml-attach-file)))

(had the same problem as you, tried this out, works for me, YMMV. (-:)

regards,
-- 
Andreas Stefan Fuchs                             in Real Life aka
asf@acm.org, asfuchs@gmx.at, asf@ycom.at         in NNTP and SMTP,
antifuchs                                        in IRCNet and
Relf Herbstfresser, Male 1/2 Elf Priest          in AD&D

Re: C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Kai Großjohann]

You can type `M-m f' (`mml-attach-file') instead.  Just in case you
didn't know...
kai
-- 
I like BOTH kinds of music.

Re: C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Karl Kleinpaste]

This was discussed a couple months ago.  It seems that a change to the
how, where, & when of (require 'mail-abbrevs) has induced this change
as an inadvertent side effect, because the message mode keymap has
already been set up when mail-abbrevs is subsequently sucked in,
changing the keymap.  Or maybe it was the other way around; I forget.

Anyhow, "Someone With CVS Write Access" (i.e. not me) ought to take a
peek at the revision history again, or just dig out the previous
discussion on this subject, and apply the small patch to be found
somewhere in that discussion to make the keymap work the right way
again.

In the meantime, learn to love `M-m f'.

Re: C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Neil Crellin]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

Karl Kleinpaste <karl@charcoal.com> writes:
> This was discussed a couple months ago.  It seems that a change to the
> how, where, & when of (require 'mail-abbrevs) has induced this change
> as an inadvertent side effect, because the message mode keymap has
> already been set up when mail-abbrevs is subsequently sucked in,
> changing the keymap.  Or maybe it was the other way around; I forget.

> Anyhow, "Someone With CVS Write Access" (i.e. not me) ought to take a
> peek at the revision history again, or just dig out the previous
> discussion on this subject, and apply the small patch to be found
> somewhere in that discussion to make the keymap work the right way
> again.

> In the meantime, learn to love `M-m f'.

Karl, thanks for jogging my memory and pointing me in the right
direction.  I don't have CVS write privs either, but I went back through
the cvs revision history of message.el and can confirm that Dave Love's
checking (5.118) deleted the lines in question.  Below is essentially the
same patch that torkel proposed when he looked into this when you and
David Goldberg brought it up in July.  Can someone with CVS write privs
please commit it?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: revert Dave Love's excision of mail-abbrev require for Xemacsen --]
[-- Type: text/x-patch, Size: 554 bytes --]

Index: message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 5.126
diff -u -r5.126 message.el
--- message.el	2000/08/25 03:52:08	5.126
+++ message.el	2000/09/05 16:47:39
@@ -35,6 +35,9 @@
   (defvar gnus-list-identifiers))	; gnus-sum is required where necessary
 (require 'mailheader)
 (require 'nnheader)
+(if (string-match "XEmacs\\|Lucid" emacs-version)
+    (require 'mail-abbrevs)
+      (require 'mailabbrev))
 (require 'mail-parse)
 (require 'mml)
 

[-- Attachment #3: Type: text/plain, Size: 39 bytes --]


-- 
Neil Crellin <neilc@wallaby.cc>

Re: C-c C-a was mml-attach-file, now mail-interactive-insert-alias?

[Dave Love]

>>>>> "NC" == Neil Crellin <neilc@wallaby.cc> writes:

 NC> the cvs revision history of message.el and can confirm that Dave
 NC> Love's checking (5.118) deleted the lines in question.  Below is
 NC> essentially the same patch that torkel proposed when he looked
 NC> into this when you and David Goldberg brought it up in July.

I missed this.  Reporting it to the bug address or direct to me as I
made tha change might have been better.

I've no idea what's up, as the relevant stuff seems to be autoloaded
in XEmacs -- anyone know?  I'll revert the XEmacs part anyway, but not
the Emacs one, which is just confusing.