From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/32869
Path: main.gmane.org!not-for-mail
From: Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai =?iso-8859-1?q?Gro=DFjoha?=  =?iso-8859-1?q?nn?=)
Newsgroups: gmane.emacs.gnus.general
Subject: Re: (concat "/dir/name/" "foo") --> (expand-file-name "foo" "/dir/name/")
Date: 14 Oct 2000 00:19:50 +0200
Sender: owner-ding@hpc.uh.edu
Message-ID: <vafk8bco03d.fsf@lucy.cs.uni-dortmund.de>
References: <vaf66mwqx4r.fsf@lucy.cs.uni-dortmund.de>
	<m3r95kzboy.fsf@multivac.student.cwru.edu>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Trace: main.gmane.org 1035169079 22188 80.91.224.250 (21 Oct 2002 02:57:59 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 02:57:59 +0000 (UTC)
Cc: ding@gnus.org
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from spinoza.math.uh.edu (spinoza.math.uh.edu [129.7.128.18])
	by mailhost.sclp.com (Postfix) with ESMTP id 49F8DD051E
	for <jason@mastaler.com>; Fri, 13 Oct 2000 18:22:12 -0400 (EDT)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by spinoza.math.uh.edu (8.9.1/8.9.1) with ESMTP id RAB00696;
	Fri, 13 Oct 2000 17:21:50 -0500 (CDT)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Fri, 13 Oct 2000 17:20:15 -0500 (CDT)
Original-Received: from mailhost.sclp.com (postfix@66-209.196.61.interliant.com [209.196.61.66] (may be forged))
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id RAA10526
	for <ding@hpc.uh.edu>; Fri, 13 Oct 2000 17:20:04 -0500 (CDT)
Original-Received: from waldorf.cs.uni-dortmund.de (waldorf.cs.uni-dortmund.de [129.217.4.42])
	by mailhost.sclp.com (Postfix) with ESMTP id 1D620D051E
	for <ding@gnus.org>; Fri, 13 Oct 2000 18:20:29 -0400 (EDT)
Original-Received: from marcy.cs.uni-dortmund.de (marcy.cs.uni-dortmund.de [129.217.20.159]) by waldorf.cs.uni-dortmund.de  with ESMTP id AAA15067; Sat, 14 Oct 2000 00:19:50 +0200 (MES)
Original-Received: from lucy.cs.uni-dortmund.de (lucy [129.217.20.160])
	by marcy.cs.uni-dortmund.de id AAA14155; Sat, 14 Oct 2000 00:19:50 +0200 (MET DST)
Original-Received: (from grossjoh@localhost)
	by lucy.cs.uni-dortmund.de (8.9.3/8.9.3/Debian 8.9.3-21) id AAA08070;
	Sat, 14 Oct 2000 00:19:50 +0200
Original-To: prj@po.cwru.edu (Paul Jarc)
X-Face: /B3twq_DELA4]7alR?%xv(/f1N;bi:NN=UlA=(1a"pKte&5/Y/9*z&8q[P}+}YgJX_9*}k_
 0E|EJBC~yEok<#VOw:9GQWq1-;PCR-hd;3|Vk]~"|EM{Q5ir5nr!HzZ,W4\k5G|QWHw45gQ*tWydTR
 ,<Jt~vfW&wP^oKocL*Si?qoJhx];jnpP6K!&D|v#NX-H-EILF/Z|onfJMcsN9
In-Reply-To: <m3r95kzboy.fsf@multivac.student.cwru.edu>
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.0.90
Original-Lines: 27
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:32869
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:32869

On 13 Oct 2000, Paul Jarc wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Gro=DFjohann) writes:
>> In the Gnus source code, we often have constructs like this:
>>=20
>>     (concat "/dir/name/" "file-name")
>>=20
>> I think this should be replaced with:
>>=20
>>     (expand-file-name "file-name" "/dir/name/")
>>=20
>> What do you think?
>=20
> It depends on the contents of "file-name".  If it might contain
> something that really needs to be normalized, then it should be
> handed to expand-file-name.  If it should be interpreted literally,
> then expand-file-name might do something unintended.  Consider,
> e.g., "foo/../bar", where foo is a symlink.

Ah.  Right.  Okay, I won't go into a frenzy to change all them concats
to expand-file-name, then :-)

Your comment about expanding a file name once and to reuse the
expanded file name also makes sense.  Hm.

kai
--=20
I like BOTH kinds of music.