message-tab is broken

message-tab is broken

[Didier Verna]

	The bug probably comes from this:

 ,----
| 2001-07-16 12:00:00  ShengHuo ZHU  <zsh@cs.rochester.edu>
|         From:  Stefan Monnier  <monnier@cs.yale.edu>
| 
|         * message.el (message-mode): Use define-derived-mode.
|         (message-tab): message-completion-alist.
`-----

	The function has been (gratuitously ?) changed to call
`indent-line-function ' instead of `tab-to-tab-stop'. As a consequence,
hitting tab in the message body doesn't insert the expected tabulation because
what's really done is `indent-to-left-margin'.

Why has this change been made ? Are there any objections if I change it back ?

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 53 14 59 47
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 44 08 01 99   didier@xemacs.org

Re: message-tab is broken

[Kai Großjohann]

Didier Verna <didier@lrde.epita.fr> writes:

> 	The function has been (gratuitously ?) changed to call
> `indent-line-function ' instead of `tab-to-tab-stop'. As a
> consequence, hitting tab in the message body doesn't insert the
> expected tabulation because what's really done is
> `indent-to-left-margin'.
> 
> Why has this change been made ? Are there any objections if I change
> it back ?

Why not change indent-line-function to indent-relative-maybe, for
example?  Or to tab-to-tab-stop, if you like.

kai
-- 
~/.signature: No such file or directory

Re: message-tab is broken

[Didier Verna]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote:

> Didier Verna <didier@lrde.epita.fr> writes:
>
>> 	The function has been (gratuitously ?) changed to call
>> `indent-line-function ' instead of `tab-to-tab-stop'. As a
>> consequence, hitting tab in the message body doesn't insert the
>> expected tabulation because what's really done is
>> `indent-to-left-margin'.
>> 
>> Why has this change been made ? Are there any objections if I change
>> it back ?
>
> Why not change indent-line-function to indent-relative-maybe, for
> example?  Or to tab-to-tab-stop, if you like.

	The problem with the `relative' family is that if the previous non
blank line is not indented, you wouldn't get the tab. Maybe
`indent-for-tab-command' would be the best choice ?

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 53 14 59 47
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 44 08 01 99   didier@xemacs.org

Re: message-tab is broken

[Kai Großjohann]

Didier Verna <didier@lrde.epita.fr> writes:

> 	The problem with the `relative' family is that if the previous non
> blank line is not indented, you wouldn't get the tab. Maybe
> `indent-for-tab-command' would be the best choice ?

Whatever.  My point was, rather than calling a different function,
change the value of indent-line-function.  Do you agree?

kai
-- 
~/.signature: No such file or directory

Re: message-tab is broken

[Didier Verna]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote:

> Didier Verna <didier@lrde.epita.fr> writes:
>
>> 	The problem with the `relative' family is that if the previous non
>> blank line is not indented, you wouldn't get the tab. Maybe
>> `indent-for-tab-command' would be the best choice ?
>
> Whatever.  My point was, rather than calling a different function,
> change the value of indent-line-function.  Do you agree?

        Huh, why not, but that sounds over complicated to me. message-tab
already handles its special cases (in headers). Why does it need to do complex
stuff just to get tabs otherwise ?

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 53 14 59 47
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 44 08 01 99   didier@xemacs.org

Re: message-tab is broken

[Karl Eichwalder]

Didier Verna <didier@lrde.epita.fr> writes:

>         Huh, why not, but that sounds over complicated to
> me. message-tab already handles its special cases (in headers). Why
> does it need to do complex stuff just to get tabs otherwise ?

Please, change it back as it ever was; it used to work perfect--the
current behavior is annoying.  Thanks for trying to cure this "feature"!

-- 
ke@suse.de (work) / keichwa@gmx.net (home):              |
http://www.suse.de/~ke/                                  |      ,__o
Free Translation Project:                                |    _-\_<,
http://www.iro.umontreal.ca/contrib/po/HTML/             |   (*)/'(*)

Re: message-tab is broken

[ShengHuo ZHU]

Didier Verna <didier@lrde.epita.fr> writes:

> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) wrote:
>
>> Didier Verna <didier@lrde.epita.fr> writes:
>>
>>> 	The function has been (gratuitously ?) changed to call
>>> `indent-line-function ' instead of `tab-to-tab-stop'. As a
>>> consequence, hitting tab in the message body doesn't insert the
>>> expected tabulation because what's really done is
>>> `indent-to-left-margin'.
>>> 
>>> Why has this change been made ? Are there any objections if I change
>>> it back ?
>>
>> Why not change indent-line-function to indent-relative-maybe, for
>> example?  Or to tab-to-tab-stop, if you like.
>
> 	The problem with the `relative' family is that if the previous non
> blank line is not indented, you wouldn't get the tab. Maybe
> `indent-for-tab-command' would be the best choice ?

I've bind it to indent-relative, to which TAB is bound in text mode.

ShengHuo