Re: [bug] Mark limit score

[Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)]

Frank Schmitt <usereplyto@Frank-Schmitt.net> writes:

> Simon Josefsson <jas@extundo.com> writes:
>  
>>> Then: /v calls gnus-summary-limit-to-score. This function is the one I
>>> want, but it doesn't ask for the score I wish to limit the summary
>>> to. It limits the summary to articles with a score bigger or equal than
>>> gnus-summary-default-score which is quite senseless.
>> 
>> Maybe it is possible to use a prefix, e.g. '100 / v'.
> 
> What do you think about this:
> 
> 
> --- lisp/gnus-sum.el	Thu Oct 18 20:03:02 2001
> +++ /cygdrive/c/Programme/XEmacs/xemacs-packages/lisp/gnus/gnus-sum.el	Thu Oct 18 22:26:50 2001
> @@ -6958,9 +6958,12 @@
>  (defun gnus-summary-limit-to-score (&optional score)
>    "Limit to articles with score at or above SCORE."
>    (interactive "P")
> -  (setq score (if score
> -		  (prefix-numeric-value score)
> -		(or gnus-summary-default-score 0)))
> +  (if (not score)
> +      (setq score 
> +	    (string-to-number (read-from-minibuffer 
> +			       "Limit to articles with a score bigger or equal than: " 
> +			       (number-to-string (or gnus-summary-default-score 0)))))
> +    (setq score (prefix-numeric-value score)))
>    (let ((data gnus-newsgroup-data)
>  	articles)
>      (while data

How about the more simple-minded:

(defun gnus-summary-limit-to-score (score)
  "..."
  (interactive "NLimit to articles with score greater or equal to: ")
  ...)

Note how the argument is not optional anymore (callers can supply
gnus-summary-default-score if they like) and how the N spec for
interactive uses the prefix arg, if supplied, but prompts for a number
if no prefix arg is supplied.

Maybe we would like to make the argument optional, so that you don't
have to supply it when calling from Lisp.  But OTOH, there is no call
to this function from Lisp, so maybe this is pointless.

Thoughts?

kai
-- 
Lisp is kinda like tpircstsoP