* citation and flow-filling
@ 2001-05-23 19:22 Paul Jarc
2001-05-23 19:40 ` Kai Großjohann
2001-05-23 19:45 ` Simon Josefsson
0 siblings, 2 replies; 9+ messages in thread
From: Paul Jarc @ 2001-05-23 19:22 UTC (permalink / raw)
When flow-filling an article with quoted material, Gnus treats space
as a non-quote character, even when it is followed by a quote
character (">") and is preceded by only quote characters. This is
what RFC 2646 says it ought to do, but in practice, it breaks. Gnus
actually breaks this itself, because when quoting, "> " is prepended
to each line. If the line already starts with a quoting character,
then only ">" should be prepended.
Can either of these already be configured the way I want them? I see
message-cite-prefix-regexp, but I don't think it's used for
flow-filling, or citation in replies. If not, I'd be happy to add the
code, if someone can point me in the right direction.
Also, is there an existing function I can add to message-send-hook or
some such to make my messages format=flowed?
paul
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-23 19:22 citation and flow-filling Paul Jarc
@ 2001-05-23 19:40 ` Kai Großjohann
[not found] ` <ygewv77ikji.fsf@asfast.com>
2001-05-23 19:45 ` Simon Josefsson
1 sibling, 1 reply; 9+ messages in thread
From: Kai Großjohann @ 2001-05-23 19:40 UTC (permalink / raw)
If you want to replace "> > " in multi-level quoting with ">> ", then
may I suggest Trivial Cite (tc.el) which does this?
kai
--
~/.signature: No such file or directory
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-23 19:22 citation and flow-filling Paul Jarc
2001-05-23 19:40 ` Kai Großjohann
@ 2001-05-23 19:45 ` Simon Josefsson
2001-05-23 23:11 ` Paul Jarc
2001-05-24 9:47 ` Kai Großjohann
1 sibling, 2 replies; 9+ messages in thread
From: Simon Josefsson @ 2001-05-23 19:45 UTC (permalink / raw)
prj@po.cwru.edu (Paul Jarc) writes:
> When flow-filling an article with quoted material, Gnus treats space
> as a non-quote character, even when it is followed by a quote
> character (">") and is preceded by only quote characters. This is
> what RFC 2646 says it ought to do, but in practice, it breaks. Gnus
> actually breaks this itself, because when quoting, "> " is prepended
> to each line. If the line already starts with a quoting character,
> then only ">" should be prepended.
Yes. Try attached patch.
> I see message-cite-prefix-regexp, but I don't think it's used for
> flow-filling, or citation in replies. If not, I'd be happy to add
> the code, if someone can point me in the right direction.
I don't think it should be used in flow-filling (it has it's own hard
coded rules to match rfc2646), but the patch below makes use of it
when indenting messages.
> Also, is there an existing function I can add to message-send-hook or
> some such to make my messages format=flowed?
Until emacs support visual cues for soft and hard line breaks, I see
little point of adding support for it in Gnus -- I mean, how would you
know if a paragraph contained soft or hard line breaks when you edit
it?
I do find it quite amazing that emacs doesn't support visual cues for
TAB, soft/hard linebreaks etc though. I mean, I bet even vi supports
this. (Lete the flame war begin... :-))
--- message.el.~6.82.~ Wed May 16 20:52:26 2001
+++ message.el Wed May 23 21:33:16 2001
@@ -523,6 +523,12 @@
:type 'string
:group 'message-insertion)
+(defcustom message-yank-cited-prefix ">"
+ "*Prefix inserted on cited lines of yanked messages.
+Fix `message-cite-prefix-regexp' if it is set to an abnormal value."
+ :type 'string
+ :group 'message-insertion)
+
(defcustom message-indentation-spaces 3
"*Number of spaces to insert at the beginning of each cited line.
Used by `message-yank-original' via `message-yank-cite'."
@@ -2074,7 +2080,9 @@
(save-excursion
(goto-char start)
(while (< (point) (mark t))
- (insert message-yank-prefix)
+ (if (looking-at message-cite-prefix-regexp)
+ (insert message-yank-cited-prefix)
+ (insert message-yank-prefix))
(forward-line 1))))
(goto-char start)))
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-23 19:45 ` Simon Josefsson
@ 2001-05-23 23:11 ` Paul Jarc
2001-05-27 9:29 ` Simon Josefsson
2001-05-24 9:47 ` Kai Großjohann
1 sibling, 1 reply; 9+ messages in thread
From: Paul Jarc @ 2001-05-23 23:11 UTC (permalink / raw)
Simon Josefsson <simon@josefsson.org> writes:
> prj@po.cwru.edu (Paul Jarc) writes:
>> If the line already starts with a quoting character, then only ">"
>> should be prepended.
>
> Yes. Try attached patch.
Works nicely. Will this be committed?
>> I see message-cite-prefix-regexp, but I don't think it's used for
>> flow-filling, or citation in replies. If not, I'd be happy to add
>> the code, if someone can point me in the right direction.
>
> I don't think it should be used in flow-filling (it has it's own hard
> coded rules to match rfc2646),
Well, I'd like to be able to make Gnus violate 2646 in this way. I
guess I would have to hack fill-flowed to do this, hm?
>> Also, is there an existing function I can add to message-send-hook or
>> some such to make my messages format=flowed?
>
> Until emacs support visual cues for soft and hard line breaks, I see
> little point of adding support for it in Gnus -- I mean, how would you
> know if a paragraph contained soft or hard line breaks when you edit
> it?
I'd be satisfied with something that added a space at the end of each
body line not followed by a blank line, and which added
"Content-Type: text/plain; format=flowed" to the header.
If any part of a message would suffer from this treatment, then I'd
disable the hook entirely for just that message and send it as
format=fixed.
paul
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-23 23:11 ` Paul Jarc
@ 2001-05-27 9:29 ` Simon Josefsson
2001-05-27 22:20 ` Hal Snyder
0 siblings, 1 reply; 9+ messages in thread
From: Simon Josefsson @ 2001-05-27 9:29 UTC (permalink / raw)
prj@po.cwru.edu (Paul Jarc) writes:
>>> If the line already starts with a quoting character, then only ">"
>>> should be prepended.
>>
>> Yes. Try attached patch.
>
> Works nicely. Will this be committed?
Committed.
>> I don't think it should be used in flow-filling (it has it's own hard
>> coded rules to match rfc2646),
>
> Well, I'd like to be able to make Gnus violate 2646 in this way. I
> guess I would have to hack fill-flowed to do this, hm?
Yes. If you think it would be useful for others, perhaps you could
submit a patch to make it customizable?
> I'd be satisfied with something that added a space at the end of each
> body line not followed by a blank line, and which added
> "Content-Type: text/plain; format=flowed" to the header.
>
> If any part of a message would suffer from this treatment, then I'd
> disable the hook entirely for just that message and send it as
> format=fixed.
It shouldn't be hard to write a hook and attach it to
`message-send-mail-hook' or something, I think.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-27 9:29 ` Simon Josefsson
@ 2001-05-27 22:20 ` Hal Snyder
0 siblings, 0 replies; 9+ messages in thread
From: Hal Snyder @ 2001-05-27 22:20 UTC (permalink / raw)
simon@josefsson.org (Simon Josefsson) writes:
> prj@po.cwru.edu (Paul Jarc) writes:
>
>>>> If the line already starts with a quoting character, then only ">"
>>>> should be prepended.
>>>
>>> Yes. Try attached patch.
>>
>> Works nicely. Will this be committed?
>
> Committed.
Just wanted to say thanks. I've been using the citation patch for a
few days. Nice work!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: citation and flow-filling
2001-05-23 19:45 ` Simon Josefsson
2001-05-23 23:11 ` Paul Jarc
@ 2001-05-24 9:47 ` Kai Großjohann
1 sibling, 0 replies; 9+ messages in thread
From: Kai Großjohann @ 2001-05-24 9:47 UTC (permalink / raw)
On 23 May 2001, Simon Josefsson wrote:
> Until emacs support visual cues for soft and hard line breaks, I see
> little point of adding support for it in Gnus -- I mean, how would
> you know if a paragraph contained soft or hard line breaks when you
> edit it?
Other editors also provide editing this kind of file, without any
visual cues. As an example, see xpostit.
kai
--
~/.signature: No such file or directory
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2001-05-27 22:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-05-23 19:22 citation and flow-filling Paul Jarc
2001-05-23 19:40 ` Kai Großjohann
[not found] ` <ygewv77ikji.fsf@asfast.com>
[not found] ` <vaf1ypfrss1.fsf@lucy.cs.uni-dortmund.de>
2001-05-24 11:37 ` Lloyd Zusman
2001-05-24 11:57 ` Lloyd Zusman
2001-05-23 19:45 ` Simon Josefsson
2001-05-23 23:11 ` Paul Jarc
2001-05-27 9:29 ` Simon Josefsson
2001-05-27 22:20 ` Hal Snyder
2001-05-24 9:47 ` Kai Großjohann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).