Re: article expiry and "B del"

Re: article expiry and "B del"

[Simon Josefsson]

(CC'ing this to ding since someone had reported the bug discussed in
the last thread..)

Adrian Kubala <adrian@sixfingeredman.net> writes:

> The behaviour of "B del" is poorly documented and confusing. 
> Specifically, the "expiry-target" settings are NOT respected, but the
> nnmail-expiry-target IS. The reason is that the nnmail-expiry-target
> is overridden to use the group's expiry-target only in the function
> `gnus-group-expire-articles-1', and not in
> `gnus-request-expire-articles' where one would think it should be.

This was fixed recently by Nevin Kapur, I think.

> If it were up to me, I'd want one command to force expiration of
> selected articles (respecting expiry-target), and another to actually
> DELETE them, so that I can delete rather than expiring.

Doesn't `gnus-summary-expire-articles-now' expire such articles
correctly?  Maybe B DEL should be reverted to not respect
expiry-target at all then.

Yes, looking at g-s-e-a-n, it seems the last patch was not sufficient;
variables like expiry-wait should also be searched from group
parameters.

I suggest this, making B DEL really delete articles.  Opinions?

--- gnus-sum.el.~6.216.~	Tue Jul  9 15:15:09 2002
+++ gnus-sum.el	Tue Jul  9 15:23:04 2002
@@ -8826,9 +8826,7 @@
     (error "Couldn't open server"))
   ;; Compute the list of articles to delete.
   (let ((articles (sort (copy-sequence (gnus-summary-work-articles n)) '<))
-	(nnmail-expiry-target
-	 (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target)
-	     nnmail-expiry-target))
+	(nnmail-expiry-target)
 	not-deleted)
     (if (and gnus-novice-user
 	     (not (gnus-yes-or-no-p

Re: article expiry and "B del"

[Kai Großjohann]

Simon Josefsson <jas@extundo.com> writes:

> Doesn't `gnus-summary-expire-articles-now' expire such articles
> correctly?  Maybe B DEL should be reverted to not respect
> expiry-target at all then.

I think gnus-summary-expire-articles-now expires all articles that
are marked as expirable, I think.

B DEL only works on one article.

I guess we want to have both commands: (a) put this article through
expiry process, regardless of age, and (b) delete this article from
the group, circumventing the usual expiry process.

kai
-- 
A large number of young women don't trust men with beards.  (BFBS Radio)

Re: article expiry and "B del"

[Nevin Kapur]

Simon Josefsson <jas@extundo.com> writes:

[...]

> I suggest this, making B DEL really delete articles.  Opinions?

That gets my vote.  Making B DEL delete articles would make its
behavior consistent with its description and the manual.

-Nevin

Re: article expiry and "B del"

[Frank Schmitt]

Simon Josefsson <jas@extundo.com> writes:

> I suggest this, making B DEL really delete articles.  Opinions?
[...]

Yes, it makes much more sense this way.

-- 
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them
In the Land of Mordor where the Shadows lie.

Re: article expiry and "B del"

[Amos Gouaux]

>>>>> On Tue, 09 Jul 2002 15:49:21 +0200,
>>>>> Frank Schmitt <usereplyto@Frank-Schmitt.net> (fs) writes:

fs> Simon Josefsson <jas@extundo.com> writes:
>> I suggest this, making B DEL really delete articles.  Opinions?
fs> [...]

fs> Yes, it makes much more sense this way.

Here's a "me too".

-- 
Amos