[patch] choose best looking alternative

[patch] choose best looking alternative

[Colin Rafferty]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

According to some RFC, a multipart/alternative is supposed to be in
order of human readable, and reverse order of prettiness when
displayed.

I just upgraded from 0.80 to 0.83, and the implied precedence order
was is reversed.


[-- Attachment #2.1: Type: text/plain, Size: 84 bytes --]

An example is this line.  It *should* be in text/enriched, but it's in
text/plain.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.2: Type: text/enriched, Size: 95 bytes --]

An example is this line.  It <bold>should</bold> be in text/enriched,
but it's in text/plain.


[-- Attachment #3: Type: text/plain, Size: 714 bytes --]


Anyway, here is the patch:

1999-04-22  Colin Rafferty  <colin@xemacs.org>

	* mm-decode.el (mm-preferred-alternative-precedence): Later
	handles are nicer than earlier handles.

--- mm-decode.el~	Sun Apr 18 08:44:10 1999
+++ mm-decode.el	Thu Apr 22 11:10:19 1999
@@ -586,7 +586,7 @@
 
 (defun mm-preferred-alternative-precedence (handles)
   "Return the precedence based on HANDLES and mm-discouraged-alternatives."
-  (let ((seq (mapcar (lambda (h) (car (mm-handle-type h))) handles)))
+  (let ((seq (mapcar (lambda (h) (car (mm-handle-type h))) (reverse handles))))
     (dolist (disc (reverse mm-discouraged-alternatives))
       (dolist (elem (copy-sequence seq))
 	(when (string-match disc elem)

-- 
Colin

Re: [patch] choose best looking alternative

[paul stevenson]

François Pinard <pinard@IRO.UMontreal.CA> writes:

> Colin Rafferty <craffert@ms.com> writes:
> 
> > An example is this line.  It should be in text/enriched, but it's in
> > text/plain.
> 
> How do we know?  Both are rendered exactly the same way :-) :-)

That's odd -  I see the asterisks. I don't *think* I've done anything to
turn off the emboldening.  Has a default changed here from 0.80 to 0.83?

Re: [patch] choose best looking alternative

[François Pinard]

Colin Rafferty <craffert@ms.com> writes:

> An example is this line.  It should be in text/enriched, but it's in
> text/plain.

How do we know?  Both are rendered exactly the same way :-) :-)

-- 
François Pinard                            mailto:pinard@iro.umontreal.ca
Join the free Translation Project!    http://www.iro.umontreal.ca/~pinard

Re: [patch] choose best looking alternative

[Alexandre Oliva]

On Apr 22, 1999, paul stevenson <spaul@mail.phy.ornl.gov> wrote:

> François Pinard <pinard@IRO.UMontreal.CA> writes:
>> Colin Rafferty <craffert@ms.com> writes:
>> 
>> > An example is this line.  It should be in text/enriched, but it's in
>> > text/plain.
>> 
>> How do we know?  Both are rendered exactly the same way :-) :-)

> That's odd -  I see the asterisks. I don't *think* I've done anything to
> turn off the emboldening.  Has a default changed here from 0.80 to 0.83?

Nope, in your message they show up.  It's probably a bug in
emboldening text/plain within multipart/alternative.

-- 
Alexandre Oliva http://www.dcc.unicamp.br/~oliva IC-Unicamp, Brasil
{oliva,Alexandre.Oliva}@dcc.unicamp.br  aoliva@{acm.org,computer.org}
oliva@{gnu.org,kaffe.org,{egcs,sourceware}.cygnus.com,samba.org}
*** E-mail about software projects will be forwarded to mailing lists

Re: [patch] choose best looking alternative

[Colin Rafferty]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

paul stevenson writes:
> François Pinard <pinard@IRO.UMontreal.CA> writes:
>> Colin Rafferty <craffert@ms.com> writes:

>> > An example is this line.  It should be in text/enriched, but it's in
>> > text/plain.

>> How do we know?  Both are rendered exactly the same way :-) :-)

> That's odd -  I see the asterisks. I don't *think* I've done anything to
> turn off the emboldening.  Has a default changed here from 0.80 to 0.83?

I think that this is a bug in Gnus handling text/plain within
multipart/alternative.

It doesn't seem to handle *bold* or smilies (like François's).

-- 
Colin

Re: [patch] choose best looking alternative

[Colin Rafferty]

François Pinard writes:

> Colin Rafferty <craffert@ms.com> writes:
>> An example is this line.  It should be in text/enriched, but it's in
>> text/plain.

> How do we know?  Both are rendered exactly the same way :-) :-)

That was the point.

Actually, did you get the bold in the text/plain part?  In 0.83, I
didn't (and neither did paul stevenson).

-- 
Colin

Re: [patch] choose best looking alternative

[Raja R Harinath]

François Pinard <pinard@IRO.UMontreal.CA> writes:
> Colin Rafferty <craffert@ms.com> writes:
> > An example is this line.  It should be in text/enriched, but it's in
> > text/plain.
> 
> How do we know?  Both are rendered exactly the same way :-) :-)

Use `K b' (gnus-summary-display-buttonized) and see which of the
multipart/alternatives is being shown.  It uses text/plain for me.
 
- Hari
-- 
Raja R Harinath ------------------------------ harinath@cs.umn.edu
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash

Re: [patch] choose best looking alternative

[François Pinard]

Colin Rafferty <craffert@ms.com> écrit:

> >> An example is this line.  It should be in text/enriched, but it's in
> >> text/plain.

> > How do we know?  Both are rendered exactly the same way :-) :-)

> That was the point.  Actually, did you get the bold in the text/plain part?
> In 0.83, I didn't (and neither did paul stevenson).

I did not see a difference.  But maybe I do not know how to select
alternatives for the whole message.  I `C-d'ed and looked at each part
separately, and they looked alike.  I then `C-u g'ed the whole message,
to see how it was coded, and then saw the difference.

-- 
François Pinard                            mailto:pinard@iro.umontreal.ca
Join the free Translation Project!    http://www.iro.umontreal.ca/~pinard

Re: [patch] choose best looking alternative

[François Pinard]

Raja R Harinath <harinath@cs.umn.edu> écrit:

> François Pinard <pinard@IRO.UMontreal.CA> writes:
> > Colin Rafferty <craffert@ms.com> writes:
> > > An example is this line.  It should be in text/enriched, but it's in
> > > text/plain.
> > 
> > How do we know?  Both are rendered exactly the same way :-) :-)

> Use `K b' (gnus-summary-display-buttonized) and see which of the
> multipart/alternatives is being shown.  It uses text/plain for me.

OK, thanks!

This adds buttons all over the place, with the capability of selecting
between alternatives.  Gadgets only useful to show bugs, probably :-).

It displayed the text/enriched part initially for me.  If I then click
the text/plain button, then the stars appear and the word is not bolded.

-- 
François Pinard                            mailto:pinard@iro.umontreal.ca
Join the free Translation Project!    http://www.iro.umontreal.ca/~pinard

Re: [patch] choose best looking alternative

[Colin Rafferty]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

François Pinard écrit:
> Colin Rafferty <craffert@ms.com> écrit:

>> That was the point.  Actually, did you get the bold in the text/plain part?
>> In 0.83, I didn't (and neither did paul stevenson).

> I did not see a difference.  But maybe I do not know how to select
> alternatives for the whole message.  


[-- Attachment #2.1: Type: text/plain, Size: 154 bytes --]

If you type `K b' in this message, you will see the buttons.  Then,
type `2 b' to toggle which part you see.

Let me know if you see the *bold* in both.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.2: Type: text/enriched, Size: 195 bytes --]

If you type <italic>K b</italic> in this message, you will see the buttons.  Then,
type <italic>2 b</italic> to toggle which part you see.

Let me know if you see the <bold>bold</bold> in both.


[-- Attachment #3: Type: text/plain, Size: 11 bytes --]


-- 
Colin