Re: problem with fancy-split's ! operator; bug?

[Colin Rafferty <colin@xemacs.org>]

Matt Swift writes:
> Colin Rafferty wrote:
>> Matt Swift writes:

>>> The following doesn't work.  You get an error when you try to trace
>>> the split.  The same thing works with the `:' operator as expected.
>>> What am I missing, or is this a bug?

>>> (defun test-split (dummy)
>>> '(& "one" "two"))
>>> (setq nnmail-split-fancy '(! test-split "dummy"))

>> It looks good to me.  What is the error (traceback, please)?

> You mean it works for you?

Oops, no it doesn't.  It simply looked correct to me, given the
documentation.

The problem is that the documentation does not match the code.

Here is the doc for `!':

  (! FUNCTION SPLIT): Call FUNCTION with the result of SPLIT.  The
    return value FUNCTION should be a split, which is then recursively
    processed.

However, here is the code:

     ;; Builtin ! operation.
     ((eq (car split) '!)
      (funcall (cadr split) (nnmail-split-it (caddr split))))

It should be this (to match `:'):

     ;; Builtin ! operation.
     ((eq (car split) '!)
      (nnmail-split-it (save-excursion (funcall (cadr split) (nnmail-split-it (caddr split))))))

I'm not sure that Lars should change the code to match documentation,
since there may be many people out there who depend on this.  Although
the documented method is much more useful.

-- 
Colin