* [patch] mode checking against picons
@ 1999-01-12 15:36 Colin Rafferty
1999-01-12 15:57 ` Lars Magne Ingebrigtsen
1999-01-12 16:42 ` Wes Hardaker
0 siblings, 2 replies; 4+ messages in thread
From: Colin Rafferty @ 1999-01-12 15:36 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 542 bytes --]
Similar to yesterday's patch, I have noticed that in a check for
gnus-article-mode, we should be checking for gnus-picons-mode.
On the other hand, I'm not sure why there is a gnus-picons-mode. Does
it actually give us anything?
Maybe it should be a minor mode, and then the major-mode can still be
gnus-article-mode, and gnus-art.el doesn't need to know about picons,
and we may even be able to put picons in non-gnus-article-mode
buffers.
Anyway, here is my patch. The line numbers may be off slightly
because of my previous patches.
[-- Attachment #2: patch for gnus-article-check-buffer --]
[-- Type: text/plain, Size: 578 bytes --]
1999-01-12 Colin Rafferty <colin@xemacs.org>
* gnus-art.el (gnus-article-check-buffer): Also check for
picons-mode.
--- lisp/gnus-art.el~ Sun Jan 3 08:36:04 1999
+++ lisp/gnus-art.el Tue Jan 12 10:26:49 1999
@@ -2994,7 +2997,7 @@
(defun gnus-article-check-buffer ()
"Beep if not in an article buffer."
- (unless (equal major-mode 'gnus-article-mode)
+ (unless (memq major-mode '(gnus-article-mode gnus-picons-mode))
(error "Command invoked outside of a Gnus article buffer")))
(defun gnus-article-read-summary-keys (&optional arg key not-restore-window)
[-- Attachment #3: Type: text/plain, Size: 10 bytes --]
;; Colin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] mode checking against picons
1999-01-12 15:36 [patch] mode checking against picons Colin Rafferty
@ 1999-01-12 15:57 ` Lars Magne Ingebrigtsen
1999-01-12 20:20 ` Colin Rafferty
1999-01-12 16:42 ` Wes Hardaker
1 sibling, 1 reply; 4+ messages in thread
From: Lars Magne Ingebrigtsen @ 1999-01-12 15:57 UTC (permalink / raw)
Colin Rafferty <craffert@ms.com> writes:
> On the other hand, I'm not sure why there is a gnus-picons-mode.
There shouldn't be. Fix in Pterodactyl Gnus v0.70.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] mode checking against picons
1999-01-12 15:36 [patch] mode checking against picons Colin Rafferty
1999-01-12 15:57 ` Lars Magne Ingebrigtsen
@ 1999-01-12 16:42 ` Wes Hardaker
1 sibling, 0 replies; 4+ messages in thread
From: Wes Hardaker @ 1999-01-12 16:42 UTC (permalink / raw)
Cc: GNUS Mailing List
>>>>> On 12 Jan 1999 10:36:42 -0500, Colin Rafferty <craffert@ms.com> said:
Colin> On the other hand, I'm not sure why there is a
Colin> gnus-picons-mode. Does it actually give us anything?
No reason... It was created solely for the "*picons*" buffer, if
people used that. Actually, I don't think I created it, I think
someone else did.
--
"Ninjas aren't dangerous. They're more afraid of you than you are of them."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] mode checking against picons
1999-01-12 15:57 ` Lars Magne Ingebrigtsen
@ 1999-01-12 20:20 ` Colin Rafferty
0 siblings, 0 replies; 4+ messages in thread
From: Colin Rafferty @ 1999-01-12 20:20 UTC (permalink / raw)
Lars Magne Ingebrigtsen writes:
> Colin Rafferty <craffert@ms.com> writes:
>> On the other hand, I'm not sure why there is a gnus-picons-mode.
> There shouldn't be. Fix in Pterodactyl Gnus v0.70.
Then watch out for my patch from yesterday. One of the pieces does a
check for gnus-picons-mode. The other pieces, however, are correct.
--
Colin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~1999-01-12 20:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-01-12 15:36 [patch] mode checking against picons Colin Rafferty
1999-01-12 15:57 ` Lars Magne Ingebrigtsen
1999-01-12 20:20 ` Colin Rafferty
1999-01-12 16:42 ` Wes Hardaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).