From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/5174 Path: main.gmane.org!not-for-mail From: Mark Borges Newsgroups: gmane.emacs.gnus.general Subject: Re: September Gnus 0.39 is released Date: 20 Feb 1996 14:06:19 -0700 Organization: CIRES, University of Colorado Sender: mdb@cdc.noaa.gov Message-ID: References: <9602201737.AA09246@revelle.cdc.noaa.gov> NNTP-Posting-Host: coloc-standby.netfonds.no X-Trace: main.gmane.org 1035145817 32054 80.91.224.250 (20 Oct 2002 20:30:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 20:30:17 +0000 (UTC) Return-Path: ding-request@ifi.uio.no Original-Received: from ifi.uio.no (ifi.uio.no [129.240.64.2]) by deanna.miranova.com (8.7.3/8.6.9) with SMTP id NAA03535 for ; Tue, 20 Feb 1996 13:57:08 -0800 Original-Received: from cdc.noaa.gov ([128.138.218.210]) by ifi.uio.no with ESMTP (8.6.11/ifi2.4) id for ; Tue, 20 Feb 1996 22:06:29 +0100 Original-Received: from revelle by cdc.noaa.gov (SMI-8.6/SMI-SVR4) id OAA02557; Tue, 20 Feb 1996 14:06:19 -0700 Original-Received: by revelle (5.0) id AA13930; Tue, 20 Feb 1996 14:06:20 -0700 Original-To: ding@ifi.uio.no X-Attribution: mb In-Reply-To: Steven L Baur's message of 20 Feb 1996 09:53:23 -0800 Original-Lines: 60 Xref: main.gmane.org gmane.emacs.gnus.general:5174 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:5174 >> On 20 Feb 1996 09:53:23 -0800, >> Steven L Baur(sb) wrote: >>>>>> "mb" == Mark Borges writes: mb> Warning: I don't have v0.39 yet (it hasn't propagated to mb> pilgrim.umass.edu yet), so the comments below may not be mb> appropriate. mb> But in v0.38, the overload of set-text-properties is done in mb> gnus-xmas.el, and is done conditionally only for XEmacs-19.13 and mb> below. In other words, this patch should not be applied. sb> Gnus-xmas.el does not redefine set-text-properties if 19.14 is sb> being run. Aye, but it used to. That was my caveat above. I just downloaded v0.39, and gnus-xmas.el has changed: $ diff -c ~/gnu/lib/xemacs/site-lisp/gnus/gnus-xmas.el gnus-xmas.el [elided] *************** *** 304,310 **** (require 'text-props) (if (< emacs-minor-version 14) ! (fset 'set-text-properties 'gnus-xmas-set-text-properties)) (fset 'nnheader-find-file-noselect 'gnus-xmas-find-file-noselect) --- 304,310 ---- (require 'text-props) (if (< emacs-minor-version 14) ! (fset 'gnus-set-text-properties 'gnus-xmas-set-text-properties)) (fset 'nnheader-find-file-noselect 'gnus-xmas-find-file-noselect) And since XEmacs-19.13 doesn't have set-text-properties() (or one which is broken, which is the root of all this mess) you get the failure noted. This defalias sb> Gnus-ems.el aliases gnus-set-text-properties to be sb> set-text-properties. is then pointless, as you've noted. But I think it would have been OK had gnus-xmas.el not changed. Lars will (of course) ultimately have to sort out what is the right thing to do -- overload set-text-properties() for versions of XEmacs prior to 19.14, as done in v0.38 and before (and possibly incur the wrath of other elisp hackers) or use his own rolled version and call gnus-set-text-properties eerywhere, i.e., apply the patch you submitted. That said, for 19.14 and beyond I think it should definitely use what is provided by 'text-props. And complain to the XEmacs developers if it's broken. -mb-