Re: Statistics'R'Us

[visigoth@naiad.fac.cs.cmu.edu]

Hmm.

(nnmail-date-to-time "21 Jan 1997 14:00:00")       => (13029  4656)
(nnmail-date-to-time "21 Jan 1997 14:00:00 +0000") => (13028 52192)
(nnmail-date-to-time "21 Jan 1997 13:00:00 -0100") => (13028 48692)
(nnmail-date-to-time "21 Jan 1997 12:00:00 -0200") => (13028 45192)

Hmm.  Those numbers shouldn't be changing...  But they are, and in
increments of 3500...  I wonder...

(nnmail-date-to-time "21 Jan 1997 14:00:00 +0001") => (13028 52191)

Oho!

It looks like you are counting the timezone delta in SECONDS, and
that's just not right.  :)  One moment...

(nnmail-date-to-time "21 Jan 1997 13:00:00 -3600") => (13028 52192)

Let's see if I can get you a fix:


Lars Magne Ingebrigtsen <larsi@ifi.uio.no> writes:

> (defun nnmail-date-to-time (date)
>   "Convert DATE into time."
>   (condition-case ()
>       (let* ((d1 (timezone-parse-date date))
> 	       (t1 (timezone-parse-time (aref d1 3)))
---insert
<              (tz (aref d1 4))
<              (tzh (substr tz 0 2))
<              (tzm (substr tz 2 4))
<              (tzs (concat (+ (* 3600 tzh) (* 60 tzm))))
---done
>)
> 	(apply 'encode-time
> 	       (mapcar (lambda (el)
> 			 (and el (string-to-number el)))
> 		       (list
> 			(aref t1 2) (aref t1 1) (aref t1 0)
> 			(aref d1 2) (aref d1 1) (aref d1 0)
---Replace the below
> 			(aref d1 4)))))
----------------------
<			tzs))))
---done replacing
>     ;; If we get an error, then we just return a 0 time.
>     (error (list 0 0))))
> 
> What's wrong here?

The above is correct, I believe, but probably not optimal.  For one
thing, I can't recall another way to turn a number into a string, and
for another, I'm working around the mapcar by doing it.

This is a nice bug to fix, BTW.  :) It must result in some interesting
date comparisons.

John.