[PATCH] bugfix: always reply to 1 article only with "F"

[PATCH] bugfix: always reply to 1 article only with "F"

[Matthieu Moy]

Hi,

Don't know if this has been fixed in the CVS version, but I have very
odd behavior with No Gnus v0.3 : Sometimes, `F' followup to all the
articles in the same summary buffer (like when marking several
articles).

The following patch solves the problem:

--- gnus-msg.el~	2005-03-09 01:58:34.000000000 +0100
+++ gnus-msg.el	2005-05-31 10:57:05.000000000 +0200
@@ -741,7 +741,7 @@
 The text in the region will be yanked.  If the region isn't
 active, the entire article will be yanked."
   (interactive "P")
-  (gnus-summary-followup (gnus-summary-work-articles n) force-news))
+  (gnus-summary-followup (gnus-summary-work-articles (or n 1)) force-news))
 
 (defun gnus-summary-followup-to-mail (&optional arg)
   "Followup to the current mail message via news."

-- 
Matthieu

Re: [PATCH] bugfix: always reply to 1 article only with "F"

[Katsumi Yamaoka]

>>>>> In <vpqis0zg46n.fsf@ecrins.imag.fr> Matthieu Moy wrote:

> Don't know if this has been fixed in the CVS version, but I have very
> odd behavior with No Gnus v0.3 : Sometimes, `F' followup to all the
> articles in the same summary buffer (like when marking several
> articles).

Wasn't the region active in the summary buffer then?  An easy
way to check whether the region is active is to set the
transient-mark-mode variable to t.

Re: [PATCH] bugfix: always reply to 1 article only with "F"

[Matthieu Moy]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Wasn't the region active in the summary buffer then?  An easy
> way to check whether the region is active is to set the
> transient-mark-mode variable to t.

Woops. My mistake: I don't like transient-mark-mode, but I like being
able to cite only part of a message by selecting it with mouse and
pressing `F'.

OGnus did the right thing for me, but with No Gnus, the only way to do
this I could find was to redefine `gnus-region-active-p' to

(defun gnus-region-active-p ()
  (and (boundp 'mark-active)
       mark-active))

I didn't think this could have this unpleasant side effect ...

I'm now using the following workaround for those transient-mark-mode
"problems" (I mean, this gives me the behavior I like):

(defadvice mouse-drag-region
  (before moy-activate-transient activate)
  (transient-mark-mode 1))

(defadvice keyboard-quit
  (before moy-deactivate-transient activate)
  (transient-mark-mode -1))

So, transient-mark-mode is activated on mouse drag, and desactivated
on C-g.

-- 
Matthieu