horrid color choices in 5.4.25

[Karl Kleinpaste <karl@jprc.com>]

I haven't been watching the ding list for a few days -- too busy and
out of town -- so please take the following with salt as needed.

I upgraded 5.4.15 -> 5.4.25 this morning.  I use a black-on-white
emacs, and the new color selections are _dreadful_.

Notably, please consider:

Item			5.4.15		5.4.25

from content		midnight blue	indianred
subject content		firebrick	firebrick (no change)
header names		dark green	maroon
header content		dark green	indianred4
newsgroups content	indianred	midnight blue

Please observe in 5.4.25 that in, e.g., mail with no "Newsgroups:"
header, the _entire_ header is in some flavor of red...and even with
such a header present, it stays indianred4 unless it's a crosspost to
get the midnight blue.

Do anyone have any idea how annoying an _all-red header_ is?  And how
uninformative it is, compared to the interesting variations present in
the older version?  It all just blurs into a red blob.

What strikes me as particularly gratuitous in this change was that
"from" went from midnight blue to indianred while "newsgroups" went
from indianred to midnight blue.  What was the imagined benefit of
inverting these two?

Below is a diff -u to recover the previous color scheme in the
(background light) case.  I never use a dark background, so I didn't
address that at all.

--karl

--- gnus-5.4.25/gnus-art.el.~1~	Sat Mar  8 20:26:56 1997
+++ gnus-5.4.25/gnus-art.el	Mon Mar 10 09:30:56 1997
@@ -419,13 +419,13 @@
 (defface gnus-header-from-face
   '((((class color)
       (background dark))
      (:foreground "spring green" :bold t :italic t))
     (((class color)
       (background light))
-     (:foreground "indianred" :bold t :italic t))
+     (:foreground "MidnightBlue" :bold t :italic t))
     (t
      (:bold t :italic t)))
   "Face used for displaying from headers."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
@@ -445,39 +445,39 @@
 (defface gnus-header-newsgroups-face
   '((((class color)
       (background dark))
      (:foreground "yellow" :bold t :italic t))
     (((class color)
       (background light))
-     (:foreground "MidnightBlue" :bold t :italic t))
+     (:foreground "indianred" :bold t :italic t))
     (t
      (:bold t :italic t)))
   "Face used for displaying newsgroups headers."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defface gnus-header-name-face
   '((((class color)
       (background dark))
      (:foreground "SeaGreen"))
     (((class color)
       (background light))
-     (:foreground "maroon"))
+     (:foreground "DarkGreen"))
     (t
      (:bold t)))
   "Face used for displaying header names."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defface gnus-header-content-face
   '((((class color)
       (background dark))
      (:foreground "forest green" :italic t))
     (((class color)
       (background light))
-     (:foreground "indianred4" :italic t))
+     (:foreground "DarkGreen" :italic t))
     (t
      (:italic t)))  "Face used for displaying header content."
   :group 'gnus-article-headers
   :group 'gnus-article-highlight)
 
 (defcustom gnus-header-face-alist