fix for bad temporary value for gnus-buffer-configuration

fix for bad temporary value for gnus-buffer-configuration

[Karl Kleinpaste]

Consequent to needing a frame-width-sensitive change to my
gnus-buffer-configuration choices due to using a really small display
(65x15), I discovered that gnus-buffer-configuration causes trouble if
the 'article selection element displays no Summary.  Code in gnus-art.el
needs a visible summary, and if that's not available, it inserts a
temporary value.  The problem is that the temporary value is missing a
needed level of parenthesization.  It looks like this code was never
tested.

This can be checked by seeing what happens after...
  (gnus-add-configuration
   '(article
     (vertical 1.0 (article 1.0 point))))       ;; no summary displayed
...if you then try to update an already-displayed article using `W w' or
switch its MIMEd plain -vs- html displays with `b'.

Would someone review to make sure this is sane, and commit it if so?

diff -u -r7.293 gnus-art.el
--- lisp/gnus-art.el	12 Aug 2009 08:27:50 -0000	7.293
+++ lisp/gnus-art.el	30 Aug 2009 18:58:31 -0000
@@ -6361,9 +6361,9 @@
 		 (gnus-configure-windows 'article)
 		 (unless (setq win (get-buffer-window summary-buffer 'visible))
 		   (let ((gnus-buffer-configuration
-			  '(article ((vertical 1.0
-					       (summary 0.25 point)
-					       (article 1.0))))))
+			  '((article ((vertical 1.0
+						(summary 0.25 point)
+						(article 1.0)))))))
 		     (gnus-configure-windows 'article))
 		   (setq win (get-buffer-window summary-buffer 'visible)))
 		 (gnus-select-frame-set-input-focus (window-frame win))

Re: fix for bad temporary value for gnus-buffer-configuration

[Katsumi Yamaoka]

>>>>> Karl Kleinpaste wrote:
> Consequent to needing a frame-width-sensitive change to my
> gnus-buffer-configuration choices due to using a really small display
> (65x15), I discovered that gnus-buffer-configuration causes trouble if
> the 'article selection element displays no Summary.  Code in gnus-art.el
> needs a visible summary, and if that's not available, it inserts a
> temporary value.  The problem is that the temporary value is missing a
> needed level of parenthesization.  It looks like this code was never
> tested.

> This can be checked by seeing what happens after...
>   (gnus-add-configuration
>    '(article
>      (vertical 1.0 (article 1.0 point))))       ;; no summary displayed
> ...if you then try to update an already-displayed article using `W w' or
> switch its MIMEd plain -vs- html displays with `b'.

> Would someone review to make sure this is sane, and commit it if so?

[...]

I've confirmed the bug and installed your patch in the Gnus trunk.
Thanks!