From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68944 Path: news.gmane.org!not-for-mail From: Karl Kleinpaste Newsgroups: gmane.emacs.gnus.general Subject: fix for bad temporary value for gnus-buffer-configuration Date: Sun, 30 Aug 2009 15:08:30 -0400 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251659352 25459 80.91.229.12 (30 Aug 2009 19:09:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 30 Aug 2009 19:09:12 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M17363@lists.math.uh.edu Sun Aug 30 21:09:05 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mhplu-0005sW-9v for ding-account@gmane.org; Sun, 30 Aug 2009 21:09:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1MhplV-0004jv-Si; Sun, 30 Aug 2009 14:08:37 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1MhplU-0004ja-0C for ding@lists.math.uh.edu; Sun, 30 Aug 2009 14:08:36 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1MhplS-0007bE-Ib for ding@lists.math.uh.edu; Sun, 30 Aug 2009 14:08:35 -0500 Original-Received: from zimbs2.srv.cs.cmu.edu ([128.2.220.246] helo=mesquite.kleinpaste.org) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1Mhpm2-0007co-00 for ; Sun, 30 Aug 2009 21:09:10 +0200 Original-Received: from awol.kleinpaste.org.kleinpaste.org (localhost [127.0.0.1]) by mesquite.kleinpaste.org (8.14.2/8.14.2) with ESMTP id n7UJ8U6p015031 for ; Sun, 30 Aug 2009 15:08:31 -0400 X-Face: ?=p^Gj2JkX~UU_@W}[q/'Dxn19x-zfIQ](y<&ky/?1-&Nz&,!W}R.Gp+"LeGojoR =RF>?!XVs{a:`Yt(gqM<#$Zy(C@]'dR4Hy4S1.I(n3:2"R:=Uy!)K9>U!gNTyH{p +_w#F[gt).$Vyvo5=9LF^PeQ(@H#}QLAbfyYxX/8t:TDR5nA\|RmJO"EwjL8tWyvM User-Agent: Gnus/5.110011 (No Gnus v0.11) XEmacs/21.5-b29 (linux) X-Virus-Scanned: ClamAV 0.93.3/9759/Sat Aug 29 23:12:45 2009 on mesquite.kleinpaste.org X-Virus-Status: Clean X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68944 Archived-At: Consequent to needing a frame-width-sensitive change to my gnus-buffer-configuration choices due to using a really small display (65x15), I discovered that gnus-buffer-configuration causes trouble if the 'article selection element displays no Summary. Code in gnus-art.el needs a visible summary, and if that's not available, it inserts a temporary value. The problem is that the temporary value is missing a needed level of parenthesization. It looks like this code was never tested. This can be checked by seeing what happens after... (gnus-add-configuration '(article (vertical 1.0 (article 1.0 point)))) ;; no summary displayed ...if you then try to update an already-displayed article using `W w' or switch its MIMEd plain -vs- html displays with `b'. Would someone review to make sure this is sane, and commit it if so? diff -u -r7.293 gnus-art.el --- lisp/gnus-art.el 12 Aug 2009 08:27:50 -0000 7.293 +++ lisp/gnus-art.el 30 Aug 2009 18:58:31 -0000 @@ -6361,9 +6361,9 @@ (gnus-configure-windows 'article) (unless (setq win (get-buffer-window summary-buffer 'visible)) (let ((gnus-buffer-configuration - '(article ((vertical 1.0 - (summary 0.25 point) - (article 1.0)))))) + '((article ((vertical 1.0 + (summary 0.25 point) + (article 1.0))))))) (gnus-configure-windows 'article)) (setq win (get-buffer-window summary-buffer 'visible))) (gnus-select-frame-set-input-focus (window-frame win))