Gnus development mailing list
 help / color / mirror / Atom feed
From: Karl Kleinpaste <karl@charcoal.com>
Subject: Re: message-add-action problem
Date: Thu, 21 Apr 2005 23:00:15 -0400	[thread overview]
Message-ID: <vxkacnra534.fsf@mesquite.charcoal.com> (raw)
In-Reply-To: <b9yy8bbzlik.fsf@jpl.org> (Katsumi Yamaoka's message of "Fri, 22 Apr 2005 09:46:11 +0900")

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> I found out Lars had changed `message-mode' so as to set
> those variables as nil.
> 	* message.el (message-inserted-headers): New variable.
> 	(message-mode): Make local.
> 	(message-mode): Set all the local action variables to nil.	
> I guess Lars considered there may be those who invoke the
> message-mail command from the message-mode buffer.

It seems unwise to nil them out because then no user settings are ever
useful, which raises the question of why the variables should exist at
all, other than temporary, local items.

> I think it can be improved as follows:
>   (set (make-local-variable 'message-*-actions)
>        (default-value 'message-*-actions))
> I don't think we should do that because the doc-strings for
> those variables don't begin with "*", though.

On that reasoning, would we not also make oodles of -hook variables
equally untouchable?  I doubt that was the intent.  I think such a fix
would be appropriate.

In any event, my particular problem is gone because I have tried your
message-multiple-frames.el and it works quite nicely.  I suggest you
include
        (provide 'message-multiple-frames)
at its end, so that it sits well with the rest of the require/provide
framework used elsewhere in Gnus.

Thank you very much.

--karl



      reply	other threads:[~2005-04-22  3:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-21  4:03 Karl Kleinpaste
2005-04-21  6:20 ` Katsumi Yamaoka
2005-04-21 15:53   ` Karl Kleinpaste
2005-04-22  0:46     ` Katsumi Yamaoka
2005-04-22  3:00       ` Karl Kleinpaste [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vxkacnra534.fsf@mesquite.charcoal.com \
    --to=karl@charcoal.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).