[patch] `gnus-agent-braid-nov'

[patch] `gnus-agent-braid-nov'

[Mike McEwan]

  Following my previous patch to `gnus-agent-braid-nov',
`gnus-agent-copy-nov-line' is now being called more
regularly. However, this has been resulting in "Invalid read syntax"
messages. I think this happens when an article has been cancelled and
hence does not exist in ` *Gnus agent overview*', but I'm not sure. I
don't really know why `gnus-agent-copy-nov-line' is being called in
the first place.  

  Anyway, the following patch takes care of this situation.

  Whilst I'm here. Lars, are you going to remove the:

"This manual corresponds to Gnus 5.6.33." 

from the texi file? I keep thinking I've messed up my upgrades :-). 

-- 
Mike.

--- ChangeLog~	Sat Aug 22 09:30:37 1998
+++ ChangeLog	Sun Aug 23 03:32:39 1998
@@ -1,3 +1,9 @@
+1998-08-23  Mike McEwan  <mike@lotusland.demon.co.uk>
+
+	* gnus-agent.el (gnus-agent-copy-nov-line): Return to beginning of 
+	line before next read.
+	(gnus-agent-braid-nov): Remove redundant `let'. 
+
 Sat Aug 22 10:28:25 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
 
 	* gnus.el: Gnus v5.6.39 is released.
--- gnus-agent.el.orig	Sun Aug 23 03:19:27 1998
+++ gnus-agent.el	Sun Aug 23 03:21:05 1998
@@ -790,47 +790,48 @@
     (setq b (point))
     (if (eq article (read (current-buffer)))
 	(setq e (progn (forward-line 1) (point)))
-      (setq e b))
+      (progn
+	(beginning-of-line)
+	(setq e b)))
     (set-buffer nntp-server-buffer)
     (insert-buffer-substring gnus-agent-overview-buffer b e)))
 
 (defun gnus-agent-braid-nov (group articles file)
-  (let (beg end)
-    (set-buffer gnus-agent-overview-buffer)
-    (goto-char (point-min))
-    (set-buffer nntp-server-buffer)
-    (erase-buffer)
-    (insert-file-contents file)
-    (goto-char (point-max))
-    (if (or (= (point-min) (point-max))
-	    (progn
-	      (forward-line -1)
-	      (< (read (current-buffer)) (car articles))))
-	;; We have only headers that are after the older headers,
-	;; so we just append them.
-	(progn
-	  (goto-char (point-max))
-	  (insert-buffer-substring gnus-agent-overview-buffer))
-      ;; We do it the hard way.
-      (nnheader-find-nov-line (car articles))
-      (gnus-agent-copy-nov-line (car articles))
-      (pop articles)
-      (while (and articles
-		  (not (eobp)))
-	(while (and (not (eobp))
-		    (< (read (current-buffer)) (car articles)))
-	  (forward-line 1))
-	(beginning-of-line)
-	(unless (eobp)
-	  (gnus-agent-copy-nov-line (car articles))
-	  (setq articles (cdr articles))))
-      (when articles
-	(let (b e)
-	  (set-buffer gnus-agent-overview-buffer)
-	  (setq b (point)
-		e (point-max))
-	  (set-buffer nntp-server-buffer)
-	  (insert-buffer-substring gnus-agent-overview-buffer b e))))))
+  (set-buffer gnus-agent-overview-buffer)
+  (goto-char (point-min))
+  (set-buffer nntp-server-buffer)
+  (erase-buffer)
+  (insert-file-contents file)
+  (goto-char (point-max))
+  (if (or (= (point-min) (point-max))
+	  (progn
+	    (forward-line -1)
+	    (< (read (current-buffer)) (car articles))))
+      ;; We have only headers that are after the older headers,
+      ;; so we just append them.
+      (progn
+	(goto-char (point-max))
+	(insert-buffer-substring gnus-agent-overview-buffer))
+    ;; We do it the hard way.
+    (nnheader-find-nov-line (car articles))
+    (gnus-agent-copy-nov-line (car articles))
+    (pop articles)
+    (while (and articles
+		(not (eobp)))
+      (while (and (not (eobp))
+		  (< (read (current-buffer)) (car articles)))
+	(forward-line 1))
+      (beginning-of-line)
+      (unless (eobp)
+	(gnus-agent-copy-nov-line (car articles))
+	(setq articles (cdr articles))))
+    (when articles
+      (let (b e)
+	(set-buffer gnus-agent-overview-buffer)
+	(setq b (point)
+	      e (point-max))
+	(set-buffer nntp-server-buffer)
+	(insert-buffer-substring gnus-agent-overview-buffer b e)))))
 
 (defun gnus-agent-load-alist (group &optional dir)
   "Load the article-state alist for GROUP."

Re: [patch] `gnus-agent-braid-nov'

[Karl Kleinpaste]

Mike McEwan <mike@lotusland.demon.co.uk> writes:
> Whilst I'm here. Lars, are you going to remove the:
> "This manual corresponds to Gnus 5.6.33." 
> from the texi file?

Similarly, the postscript manual's cover page under
http://www.gnus.org/documents/ still claims to be for 5.6.5, even
though the announcement on August 12th said it corresponds to 5.6.34.