gnus-score-customize should accept universal argument

gnus-score-customize should accept universal argument

[Alex Schroeder]

I just decided that I want to change my all.SCORE file.  There seems
no way to do this using V C.  How about making gnus-score-customize
detect a universal argument and then prompt the user for a file (with
completion?).

Here's my feeble attempt...

Alex.

cd /home/alex/tmp/
diff -c /home/alex/tmp/gnus-cus.el\~ /home/alex/tmp/gnus-cus.el
*** /home/alex/tmp/gnus-cus.el~	Fri Feb  9 20:10:50 2001
--- /home/alex/tmp/gnus-cus.el	Fri Feb  9 20:11:23 2001
***************
*** 683,689 ****
  
  (defun gnus-score-customize (file)
    "Customize score file FILE."
!   (interactive (list gnus-current-score-file))
    (let ((scores (gnus-score-load file))
  	(types (mapcar (lambda (entry)
  			 `(group :format "%v%h\n"
--- 683,700 ----
  
  (defun gnus-score-customize (file)
    "Customize score file FILE."
!   (interactive "P")
!   ;; (interactive (list gnus-current-score-file))
!   (if (equal file '(4))
!       (setq file 
! 	    (expand-file-name
! 	     (read-file-name (concat "Score File ("
! 				     (file-name-nondirectory gnus-current-score-file)
! 				     ") ")
! 			     (file-name-directory gnus-current-score-file)
! 			     gnus-current-score-file)))
!     (when (null file)
!       (setq file gnus-current-score-file)))
    (let ((scores (gnus-score-load file))
  	(types (mapcar (lambda (entry)
  			 `(group :format "%v%h\n"

Diff finished at Fri Feb  9 20:12:01

Re: gnus-score-customize should accept universal argument

[Kai Großjohann]

Does it work to say `V c' to choose the score file, then `V C' to
customize it?
kai
-- 
Be indiscrete.  Do it continuously.

Re: gnus-score-customize should accept universal argument

[Andreas Fuchs]

Today, Kai Großjohann <Kai.Grossjohann@CS.Uni-Dortmund.DE> wrote:
> Does it work to say `V c' to choose the score file, then `V C' to
> customize it?

BTW: is there a special reason for the "Bwahahah" button in the "V C"
screen? Not that it's not funny and all, but I'd really like to know
how and why it got there... (-:

-- 
Andreas Fuchs, <asf@acm.org>, <d96001@htlwrn.ac.at>, antifuchs

Re: gnus-score-customize should accept universal argument

[Kai Großjohann]

On Fri, 09 Feb 2001, Andreas Fuchs wrote:

> BTW: is there a special reason for the "Bwahahah" button in the "V
> C" screen? Not that it's not funny and all, but I'd really like to
> know how and why it got there... (-:

Me, too.  Btw, how does one find out what these buttons do?  `C-h c
RET' just tells me `widget-button-press', and `M-x
list-text-properties-at RET' keeps saying None.

kai
-- 
Be indiscrete.  Do it continuously.

Re: gnus-score-customize should accept universal argument

[Per Abrahamsen]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> On Fri, 09 Feb 2001, Andreas Fuchs wrote:
> 
> > BTW: is there a special reason for the "Bwahahah" button in the "V
> > C" screen? Not that it's not funny and all, but I'd really like to
> > know how and why it got there... (-:
> 
> Me, too.  

The idea was to make sure nobody forgot to check those checkboxes.   

> Btw, how does one find out what these buttons do? 

Use

        M-x widget-browse-at <ret>

and look at the :action property.

Re: gnus-score-customize should accept universal argument

[Kai Großjohann]

On 10 Feb 2001, Per Abrahamsen wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
>> On Fri, 09 Feb 2001, Andreas Fuchs wrote:
>> 
>> > BTW: is there a special reason for the "Bwahahah" button in the
>> > "V C" screen? Not that it's not funny and all, but I'd really
>> > like to know how and why it got there... (-:
>> 
>> Me, too.  
> 
> The idea was to make sure nobody forgot to check those checkboxes.

Ah, now I see what's going on!  I wonder if something could be done to
support us people who don't have a sound card.  That way, I wouldn't
feel so left out...  (The message function is probably sufficient.)

kai
-- 
Be indiscrete.  Do it continuously.

Re: gnus-score-customize should accept universal argument

[Karl Kleinpaste]

Per Abrahamsen <abraham@dina.kvl.dk> writes:
>> Btw, how does one find out what these buttons do? 

>         M-x widget-browse-at <ret>

/mumble/

V C  (Why does this leave the cursor at the _bottom_ of the buffer?)
[ position cursor at end of line containing "bwahaha" box. ]
M-x widget-browse-at RET
"This is unidentified text"
C-b
M-x widget-browse-at RET
"Stack overflow in copy tree: #1"

Also, side effect: It seems that having ever done `V C' means my
followup and reply buffers don't get fontified at all.  But I'm not
quite sure it's strictly `V C'-related -- it might instead be
"widget-browe-at"-related.

Re: gnus-score-customize should accept universal argument

[Per Abrahamsen]

Karl Kleinpaste <karl@charcoal.com> writes:

> V C  (Why does this leave the cursor at the _bottom_ of the buffer?)

Nobody have bothered to send in a patch to goto the beginning of the
buffer.

> M-x widget-browse-at RET
> "Stack overflow in copy tree: #1"

Works fine here, maybe it is broken in XEmacs?

> Also, side effect: It seems that having ever done `V C' means my
> followup and reply buffers don't get fontified at all.  But I'm not
> quite sure it's strictly `V C'-related -- it might instead be
> "widget-browe-at"-related.

I cannot see any possible connection between any of the three things. 

Re: gnus-score-customize should accept universal argument

[Alex Schroeder]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> Does it work to say `V c' to choose the score file, then `V C' to
> customize it?

Sure does.  :)

Alex.
-- 
http://www.geocities.com/kensanata/
Coffee should be black as hell, strong as death and sweet as love.
	-- Turkish proverb

Re: gnus-score-customize should accept universal argument

[Kai Großjohann]

On 11 Feb 2001, Alex Schroeder wrote:

> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
>> Does it work to say `V c' to choose the score file, then `V C' to
>> customize it?
> 
> Sure does.  :)

I wasn't so sure at all.  So the arg is not needed anymore?

kai
-- 
Be indiscrete.  Do it continuously.

Re: gnus-score-customize should accept universal argument

[Alex Schroeder]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> I wasn't so sure at all.  So the arg is not needed anymore?

No, it is not needed anymore.  But perhaps V c should be mentioned in
the doc string of V C?

Alex.
-- 
http://www.geocities.com/kensanata/
Coffee should be black as hell, strong as death and sweet as love.
	-- Turkish proverb

Re: gnus-score-customize should accept universal argument

[Kai Großjohann]

On 12 Feb 2001, Alex Schroeder wrote:
> Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> 
>> I wasn't so sure at all.  So the arg is not needed anymore?
> 
> No, it is not needed anymore.  But perhaps V c should be mentioned
> in the doc string of V C?

Like this?

/----
| V C runs the command gnus-score-customize
|    which is an interactive Lisp function in `gnus-cus.elc'.
| (gnus-score-customize FILE)
| 
| Customize score file FILE.
| FILE defaults to the current score file.  This can be changed using
| the `V c' command.
\----

Will commit in a jiffy.

kai
-- 
Be indiscrete.  Do it continuously.