Patch to show `To' header

Patch to show `To' header

[Stefan Waldherr]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]


Hi,

attached is a patch (that works also for pgnus) that shows the content of the
`To' field instead of one's own name in the Summary buffer if the mail is from
oneself. This feature is very convenient and ought to be integrated into pgnus
(in this form or another). 

I don't remember where I found this patch originally -- it may have been
submitted to the ding list before.


[-- Attachment #2: tofrom.patch --]
[-- Type: application/octet-stream, Size: 1320 bytes --]

--- ../../gnus-5.6.38/lisp/nnheader.el	Fri Jun 26 04:26:47 1998
+++ nnheader.el	Sun Aug 16 19:11:48 1998
@@ -54,6 +54,14 @@
 
 \(setq nnheader-file-name-translation-alist '((?: . ?_)))")
 
+(defvar nnheader-user-address-regexp (user-full-name)
+  "*Regexp matching the user's name and/or address as it appears in the
+\"From:\" header.")
+
+(defvar nnheader-nov-uses-to nil
+  "*If nnheader-nov-uses-to is t, the recipient will be listed in the summary
+if the \"From:\" field matches nnheader-user-address-regexp.")
+
 (eval-and-compile
  (autoload 'nnmail-message-id "nnmail")
  (autoload 'mail-position-on-field "sendmail")
@@ -205,8 +213,19 @@
 	   ;; From.
 	   (progn
 	     (goto-char p)
-	     (if (search-forward "\nfrom: " nil t)
-		 (nnheader-header-value) "(nobody)"))
+             (goto-char p)
+	     (let (from)
+	       (setq from (if (search-forward "\nfrom: " nil t)
+			      (nnheader-header-value) "(nobody)"))
+	       (cond ((and nnheader-nov-uses-to
+			   (string-match nnheader-user-address-regexp from))
+		      (goto-char p)
+		      (if (search-forward "\nto: " nil t)
+			  (concat "To:" (nnheader-header-value))
+			"To:(nobody)"))
+		     (t from))))
+;	     (if (search-forward "\nfrom: " nil t)
+;		 (nnheader-header-value) "(nobody)"))
 	   ;; Date.
 	   (progn
 	     (goto-char p)

[-- Attachment #3: Type: text/plain, Size: 193 bytes --]


cu
Stefan.

-- 
Stefan Waldherr                   fax +49 431 8058 136
                               e-Mail stefan@waldherr.org
                                  www http://www.waldherr.org/

Re: Patch to show `To' header

[George J McNinch]

>>>>> "Stefan" == Stefan Waldherr <stefan@waldherr.org> writes:

    Stefan> Hi,

    Stefan> attached is a patch (that works also for pgnus) that shows
    Stefan> the content of the `To' field instead of one's own name in
    Stefan> the Summary buffer if the mail is from oneself. This
    Stefan> feature is very convenient and ought to be integrated into
    Stefan> pgnus (in this form or another).

I get this behavior now via

(setq gnus-ignored-from-addresses
      "<regexp matching me>")

The summary buffer then uses 

[-> to-field]

instead of the From field for mails from me.

Best,
george

Re: Patch to show `To' header

[Justin Sheehy]

Stefan Waldherr <stefan@waldherr.org> writes:

> attached is a patch (that works also for pgnus) that shows the
> content of the `To' field instead of one's own name in the Summary
> buffer if the mail is from oneself. This feature is very convenient
> and ought to be integrated into pgnus

This feature has already been integrated into pgnus for a while now.

-Justin

Re: Patch to show `To' header

[Hrvoje Niksic]

Justin Sheehy <justin@linus.mitre.org> writes:

> Stefan Waldherr <stefan@waldherr.org> writes:
> 
> > attached is a patch (that works also for pgnus) that shows the
> > content of the `To' field instead of one's own name in the Summary
> > buffer if the mail is from oneself. This feature is very convenient
> > and ought to be integrated into pgnus
> 
> This feature has already been integrated into pgnus for a while now.

Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
"niksic", I see no change in how my messages are displayed in Summary
buffers.

Re: Patch to show `To' header

[Colin Rafferty]

Hrvoje Niksic writes:
> Justin Sheehy <justin@linus.mitre.org> writes:
>> Stefan Waldherr <stefan@waldherr.org> writes:
>> 
>> > attached is a patch (that works also for pgnus) that shows the
>> > content of the `To' field instead of one's own name in the Summary
>> > buffer if the mail is from oneself. This feature is very convenient
>> > and ought to be integrated into pgnus
>> 
>> This feature has already been integrated into pgnus for a while now.

> Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
> "niksic", I see no change in how my messages are displayed in Summary
> buffers.

Not for nothing, but don't you use BBDB, and have %uB in your
`gnus-summary-line-format'?

-- 
Colin

Re: Patch to show `To' header

[Stefan Waldherr]

>>>>> "Colin" == Colin Rafferty <craffert@ms.com> writes:

  >> Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
  >> "niksic", I see no change in how my messages are displayed in Summary
  >> buffers.

  Colin> Not for nothing, but don't you use BBDB, and have %uB in your
  Colin> `gnus-summary-line-format'?

Well, I didn't get it to work. Here is what I did:

(setq gnus-summary-line-format "%B%R%z%I%(%[%d: %-24,24n%]%) %-4,4i%s\n")
(setq gnus-extra-headers '(Keywords To Newsgroups)
      nnmail-extra-headers '(Keywords To Newsgroups))
(setq gnus-ignored-from-addresses
      ".*\\(swa\\|aldherr\\)")

then I fiddled with the %B thingie in gnus-summary-line-format. And I
regenerated the entire overview database with nnml-generate-nov-databases a
couple of times. All to no avail. Any hints?

Thanks,
Stefan.
-- 
Stefan Waldherr                   fax +49 431 8058 136
                               e-Mail stefan@waldherr.org
                                  www http://www.waldherr.org/

Re: Patch to show `To' header

[Karl Kleinpaste]

Stefan Waldherr <stefan@waldherr.org> writes:
> Well, I didn't get it to work. Here is what I did:
> (setq gnus-summary-line-format "%B%R%z%I%(%[%d: %-24,24n%]%) %-4,4i%s\n")

You want "%...f" to get the alternate forms, not "%...n".  See doc
string.  `f' should probably be made default, since it defaults to `n'
behavior in the absence of sufficient overview clues.

> then I fiddled with the %B thingie in gnus-summary-line-format.

`B'?  That's not one of the specifiers in gnus-summary-line-format.
Perhaps it's a defunctitude from an older incantation of Gnus?

See gnus-summary-line-format-alist in gnus-sum.el, and the defcustom
in gnus.el.

Re: Patch to show `To' header

[Stefan Waldherr]

>>>>> "Karl" == Karl Kleinpaste <karl@justresearch.com> writes:

  Karl> You want "%...f" to get the alternate forms, not "%...n".  See doc
  Karl> string.  `f' should probably be made default, since it defaults to `n'
  Karl> behavior in the absence of sufficient overview clues.

Exactly. I commented out the line in my .emacs to fall back to the default
value of the summary-line and I too had no luck with the `To' field. But after
explicitly setting "%...f", everything is cool now. So, I think that gnus
should default to the "%...f" setting in gnus-summary-line-format.

Thanks a lot,
Stefan.
-- 
Stefan Waldherr                   fax +49 431 8058 136
                               e-Mail stefan@waldherr.org
                                  www http://www.waldherr.org/

Re: Patch to show `To' header

[Lars Magne Ingebrigtsen]

Stefan Waldherr <stefan@waldherr.org> writes:

> Exactly. I commented out the line in my .emacs to fall back to the
> default value of the summary-line and I too had no luck with the
> `To' field. But after explicitly setting "%...f", everything is cool
> now. So, I think that gnus should default to the "%...f" setting in
> gnus-summary-line-format.

Most people, believe it or not, just use Gnus as a newsreader.  :-)
%f is slower than %n, and has no effect when reading Usenet
newsgroups, so I don't think that's a good default.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Patch to show `To' header

[Kai.Grossjohann]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

  > Most people, believe it or not, just use Gnus as a newsreader.  :-)
  > %f is slower than %n, and has no effect when reading Usenet
  > newsgroups, so I don't think that's a good default.

I think this is something that should be easily customizable, and I
don't count putting all these % escapes in a longish string as being
easy.

Hm.

OT1H, IWBNI there was a variable gnus-summary-display-user-function
which could be set to something which gives us %n and to something
else which gives us %f and then a % escape which uses that.

OTOH, down this path (creating lots and lots of customization
variables like this) lies madness.

Does this mean you can't have your cake and eat it, too?

kai
-- 
Just because I'm paranoid doesn't mean they're not out there to get me!

Re: Patch to show `To' header

[Justin Sheehy]

Stefan Waldherr <stefan@waldherr.org> writes:

> Well, I didn't get it to work. Here is what I did:
> 
> (setq gnus-summary-line-format "%B%R%z%I%(%[%d: %-24,24n%]%) %-4,4i%s\n")

> then I fiddled with the %B thingie in gnus-summary-line-format. 

What is the %B specifier?  I don't see it referenced in the manual.
The one that I use for the from/to header is:

%f   Contents of the From: or To: headers (string)

Since you seem to be using %n instead of %f, you won't see the To header.

-Justin

Re: Patch to show `To' header

[Kai.Grossjohann]

Justin Sheehy <justin@linus.mitre.org> writes:

  > What is the %B specifier?  I don't see it referenced in the manual.

I think %Bu should have been %uB.

kai
-- 
Just because I'm paranoid doesn't mean they're not out there to get me!

Re: Patch to show `To' header

[Hrvoje Niksic]

Colin Rafferty <craffert@ms.com> writes:

> > Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
> > "niksic", I see no change in how my messages are displayed in Summary
> > buffers.
> 
> Not for nothing, but don't you use BBDB, and have %uB in your
> `gnus-summary-line-format'?

I've never gotten around to trying BBDB.

I don't need that feature particularly, but if Gnus already have it,
yes, I'd like to use it.

Re: Patch to show `To' header

[Karl Kleinpaste]

Hrvoje Niksic <hniksic@srce.hr> writes:
> Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
> "niksic", I see no change in how my messages are displayed in Summary
> buffers.

It works, but minimally you must also

(setq gnus-extra-headers '(To)
      nnmail-extra-headers '(To))

in order that the To: address land in .overview.  Personally, I use

(setq gnus-extra-headers '(Keywords To Newsgroups)
      nnmail-extra-headers '(Keywords To Newsgroups))

so that I can do useful things with Keywords headers, generally, and
so that Newsgroups is also a *Summary* display possibility.

I suspect the manual doesn't really discuss this as completely as it
ought.  I'll take a look.

Re: Patch to show `To' header

[Hrvoje Niksic]

Karl Kleinpaste <karl@justresearch.com> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> > Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
> > "niksic", I see no change in how my messages are displayed in Summary
> > buffers.
> 
> It works, but minimally you must also
> 
> (setq gnus-extra-headers '(To)
>       nnmail-extra-headers '(To))

Grmbljh.  Does that mean that the whole feat won't work for my old
messages?  It doesn't appear to.

> so that I can do useful things with Keywords headers, generally, and
> so that Newsgroups is also a *Summary* display possibility.
> 
> I suspect the manual doesn't really discuss this as completely as it
> ought.  I'll take a look.

The manual does mention it, but it doesn't /discuss/ it.

Re: Patch to show `To' header

[Justin Sheehy]

Hrvoje Niksic <hniksic@srce.hr> writes:

> > (setq gnus-extra-headers '(To)
> >       nnmail-extra-headers '(To))
> 
> Grmbljh.  Does that mean that the whole feat won't work for my old
> messages?  It doesn't appear to.

You need to regenerate your NOV files.

After setting the above variables (and gnus-ignored-from-addresses)
and regerating the NOV stuff, it worked marvelously for me.

-Justin

Re: Patch to show `To' header

[Karl Kleinpaste]

Hrvoje Niksic <hniksic@srce.hr> writes:
> Grmbljh.  Does that mean that the whole feat won't work for my old
> messages?  It doesn't appear to.

Sorry, I should have also mentioned: Regenerate overviews with
nnml-generate-nov-databases to reconstruct them all, or
nnml-generate-nov-databases-1 to pick on single groups.

I've got ~250Mbytes of mail dating back to 1989 in 120 nnml groups,
and regeneration didn't take all that long, even for this pile of
stuff.

Re: Patch to show `To' header

[Karl Kleinpaste]

Hrvoje Niksic <hniksic@srce.hr> writes:
> Grmbljh.

BTW, exactly how do you pronounce that? :-)

Re: Patch to show `To' header

[Hrvoje Niksic]

Karl Kleinpaste <karl@justresearch.com> writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> > Grmbljh.
> 
> BTW, exactly how do you pronounce that? :-)

Why, the way I wrote it!  :-)

Re: Patch to show `To' header

[Kai.Grossjohann]

Hrvoje Niksic <hniksic@srce.hr> writes:

  > Karl Kleinpaste <karl@justresearch.com> writes:
  > 
  > > Hrvoje Niksic <hniksic@srce.hr> writes:
  > > > Grmbljh.
  > > 
  > > BTW, exactly how do you pronounce that? :-)
  > 
  > Why, the way I wrote it!  :-)

By tapping your fingers on a keyboard?  That's strange, and what do
you do when you don't have a keyboard handy?

kai
-- 
Just because I'm paranoid doesn't mean they're not out there to get me!

Re: Patch to show `To' header

[Hrvoje Niksic]

Kai.Grossjohann@CS.Uni-Dortmund.DE writes:

> Hrvoje Niksic <hniksic@srce.hr> writes:
> 
>   > Karl Kleinpaste <karl@justresearch.com> writes:
>   > 
>   > > Hrvoje Niksic <hniksic@srce.hr> writes:
>   > > > Grmbljh.
>   > > 
>   > > BTW, exactly how do you pronounce that? :-)
>   > 
>   > Why, the way I wrote it!  :-)
> 
> By tapping your fingers on a keyboard?

No.  Grmbljh is answered by first pronouncing `g', then `r', then `m', 
then `b', then `lj' (don't ask), then `h' -- but as a single word.

> and what do you do when you don't have a keyboard handy?

I sleep on a real pillow.

Re: Patch to show `To' header

[Kai.Grossjohann]

Hrvoje Niksic <hniksic@srce.hr> writes:

  > Grmbljh.  Does that mean that the whole feat won't work for my old
  > messages?  It doesn't appear to.

M-x nnml-generate-nov-databases RET should do the trick for old
messages.  It did for me.

kai
-- 
Just because I'm paranoid doesn't mean they're not out there to get me!

Re: Patch to show `To' header

[Lars Magne Ingebrigtsen]

Karl Kleinpaste <karl@justresearch.com> writes:

> I suspect the manual doesn't really discuss this as completely as it
> ought.  I'll take a look.

I've now made the %f thing explicit.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Patch to show `To' header

[Kai.Grossjohann]

Hrvoje Niksic <hniksic@srce.hr> writes:

  > Yes, but does it work?  When I set `gnus-ignored-from-addresses' to
  > "niksic", I see no change in how my messages are displayed in Summary
  > buffers.

Hm.  Maybe it fails because gnus-ignored-from-addresses is assumed to
be a word?

kai
-- 
Just because I'm paranoid doesn't mean they're not out there to get me!