From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/54625
Path: main.gmane.org!not-for-mail
From: Norbert Koch <viteno@xemacs.org>
Newsgroups: gmane.emacs.gnus.general
Subject: Re: Scoring out of bounds
Date: Sun, 02 Nov 2003 13:17:57 +0100
Sender: ding-owner@lists.math.uh.edu
Message-ID: <vz3cd7c6bu.fsf@redqueen.bytechase.cx>
References: <vzwuajcfro.fsf@redqueen.bytechase.cx>
NNTP-Posting-Host: deer.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1067775450 20762 80.91.224.253 (2 Nov 2003 12:17:30 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 2 Nov 2003 12:17:30 +0000 (UTC)
Original-X-From: ding-owner+M3166@lists.math.uh.edu Sun Nov 02 13:17:28 2003
Return-path: <ding-owner+M3166@lists.math.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AGHAd-0004AP-00
	for <ding-account@gmane.org>; Sun, 02 Nov 2003 13:17:28 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by malifon.math.uh.edu with smtp (Exim 3.20 #1)
	id 1AGH98-0003qG-00; Sun, 02 Nov 2003 06:15:54 -0600
Original-Received: from justine.libertine.org ([66.139.78.221])
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 1AGH8z-0003q8-00
	for ding@lists.math.uh.edu; Sun, 02 Nov 2003 06:15:45 -0600
Original-Received: from mail.LF.net (mail.LF.net [212.9.160.2])
	by justine.libertine.org (Postfix) with ESMTP id 4DB243A004C
	for <ding@gnus.org>; Sun,  2 Nov 2003 06:15:44 -0600 (CST)
Original-Received: from pd9518de5.dip.t-dialin.net ([217.81.141.229] helo=redqueen.bytechase.cx)
	by mail.LF.net with esmtp (Exim 4.22)
	id 1AGH8x-00007K-EK
	for ding@gnus.org; Sun, 02 Nov 2003 13:15:43 +0100
Original-Received: from nk by redqueen.bytechase.cx with local (Exim 4.22)
	id 1AGHB7-000BcK-OT
	for ding@gnus.org; Sun, 02 Nov 2003 13:17:57 +0100
Original-To: Ding Mailing List <ding@gnus.org>
X-Face: 9,{UOz`879Gt1t?~vOo"iN!BBRwO<t[L3HO!M@<pekF,!8m&1UuUTYeb44x!$5jghAECeE<
 I\~$c?.4Ti'Ls^!*r]7j&_e<0/.}xmzj/kiN\]|*^n&FX)`A`YD~z!ob;QshZi.*A2GX~kq8c?"r<(
 @YnvNer}=kY
Mail-Followup-To: Ding Mailing List <ding@gnus.org>
In-Reply-To: <vzwuajcfro.fsf@redqueen.bytechase.cx> (Norbert Koch's message
 of "Sun, 02 Nov 2003 09:54:03 +0100")
User-Agent: Gnus/5.1003 (Gnus v5.10.3) XEmacs/21.4 (Reasonable Discussion,
 berkeley-unix)
Precedence: bulk
Xref: main.gmane.org gmane.emacs.gnus.general:54625
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:54625

Norbert Koch <viteno@xemacs.org> writes:

> Something's pushing scores up too high (my bad), but maybe it should
> be bound in gnus-decay-score to prevent such errors?

Here's a possible fix

Index: gnus-score.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-score.el,v
retrieving revision 6.35
diff -u -u -r6.35 gnus-score.el
--- gnus-score.el	13 Aug 2003 16:34:46 -0000	6.35
+++ gnus-score.el	2 Nov 2003 12:14:46 -0000
@@ -2918,13 +2918,15 @@
 
 (defun gnus-decay-score (score)
   "Decay SCORE according to `gnus-score-decay-constant' and `gnus-score-decay-scale'."
-  (floor
-   (- score
-      (* (if (< score 0) -1 1)
-	 (min (abs score)
-	      (max gnus-score-decay-constant
-		   (* (abs score)
-		      gnus-score-decay-scale)))))))
+  (condition-case nil
+      (floor
+       (- score
+	  (* (if (< score 0) -1 1)
+	     (min (abs score)
+		  (max gnus-score-decay-constant
+		       (* (abs score)
+			  gnus-score-decay-scale))))))
+    (arith-error most-positive-fixnum)))
 
 (defun gnus-decay-scores (alist day)
   "Decay non-permanent scores in ALIST."