Gnus registry woes

Gnus registry woes

[Norbert Koch]

Hi!

I've had a go at the registry today.  Now, I'm no longer able to save
my Gnus buffers.  I get the following error:

Signaling: (wrong-type-argument natnump -2497)
  gnus-registry-trim((("<20040629090742.GE74930@atrbg11.informatik.tu-muenchen.de>" (...) "nnml:bsd-current") ("<1152675CA9EDD71187130002B3CE5ADA090BA9F4@hoexc010.ukrtelecom.net>" (...) "nnml:bsd-current") ("<87n02msp6d.fsf@free.fr>" (...) "nnml:lilypond")))
  gnus-registry-save()
  run-hooks(gnus-registry-save)
  apply(run-hooks gnus-registry-save)
  gnus-run-hooks(gnus-save-newsrc-hook)
  gnus-save-newsrc-file(nil)
  gnus-group-save-newsrc(nil)
  call-interactively(gnus-group-save-newsrc)


This is the latest and greatest Gnus on a 21.4 (patch 15) "Security
Through Obscurity" XEmacs Lucid.

Any pointers are very welcome,
norbert.

Re: Gnus registry woes

[Ted Zlatanov]

On Tue, 29 Jun 2004, viteno@xemacs.org wrote:

> I've had a go at the registry today.  Now, I'm no longer able to save
> my Gnus buffers.  I get the following error:
> 
> Signaling: (wrong-type-argument natnump -2497)
>   gnus-registry-trim((("<20040629090742.GE74930@atrbg11.informatik.tu-muenchen.de>"
>   	(...) "nnml:bsd-current")
>   	("<1152675CA9EDD71187130002B3CE5ADA090BA9F4@hoexc010.ukrtelecom.net>"
>   	(...) "nnml:bsd-current") ("<87n02msp6d.fsf@free.fr>" (...)
>   	"nnml:lilypond")))
>   gnus-registry-save()
>   run-hooks(gnus-registry-save)
>   apply(run-hooks gnus-registry-save)
>   gnus-run-hooks(gnus-save-newsrc-hook)
>   gnus-save-newsrc-file(nil)
>   gnus-group-save-newsrc(nil)
>   call-interactively(gnus-group-save-newsrc)

Here's the function in question:

(defun gnus-registry-trim (alist)
  "Trim alist to size, using gnus-registry-max-entries."
  (if (null gnus-registry-max-entries)
      alist				; just return the alist
    ;; else, when given max-entries, trim the alist
    (let ((timehash (make-hash-table 			    
		     :size 4096
		     :test 'equal)))
      (maphash
       (lambd a(key value)
	 (puthash key (gnus-registry-fetch-extra key 'mtime) timehash))
       gnus-registry-hashtb)

      ;; we use the return value of this setq, which is the trimmed alist
      (setq alist
	    (nthcdr
	     (- (length alist) gnus-registry-max-entries)
	     (sort alist 
		   (lambda (a b)
		     (time-less-p 
		      (cdr (gethash (car a) timehash))
		      (cdr (gethash (car b) timehash))))))))))

So basically we sort the alist and then take only the needed number
of entries from it.

I would guess the natnump error, which I have never seen before, is
coming from an invalid mtime.  Can you trace the error deeper with
(debug) statements inside the lambda function above?  Alternatively,
can you send me your registry file, if the error is repeatable from
it?

Thanks
Ted

Re: Gnus registry woes

[Norbert Koch]

"Ted Zlatanov" <tzz@lifelogs.com> writes:

> I would guess the natnump error, which I have never seen before, is
> coming from an invalid mtime.  Can you trace the error deeper with
> (debug) statements inside the lambda function above?  Alternatively,
> can you send me your registry file, if the error is repeatable from
> it?

I think the problem is there *is* no registry file, yet.  Should I
create it (empty)?

I can try to step down expressions, though.

Thanks,
norbert.

Re: Gnus registry woes

[Norbert Koch]

Norbert Koch <viteno@xemacs.org> writes:

> "Ted Zlatanov" <tzz@lifelogs.com> writes:
>
>> I would guess the natnump error, which I have never seen before, is
>> coming from an invalid mtime.  Can you trace the error deeper with
>> (debug) statements inside the lambda function above?  Alternatively,
>> can you send me your registry file, if the error is repeatable from
>> it?

> I can try to step down expressions, though.

Okay, I've had a look at it.  The error occurs at the end of the sort
operation.

      (setq alist
	    (nthcdr
	     (- (length alist) gnus-registry-max-entries)
	     (sort alist 
		   (lambda (a b)
		     (time-less-p 
		      (cdr (gethash (car a) timehash))
		      (cdr (gethash (car b) timehash))))))))))
                                                         ^ stepping
                                                         over this paren

Here's my current timehash and alist

#<hash-table test equal size 2/8737 data ("<20040630141326.666947303F@freebsd-current.sentex.ca>" (mtime 16610 55105 533706) "<20040630140742.CAA057303F@freebsd-current.sentex.ca>" (mtime 16610 55105 533085)) 0x10ccb>

((<20040630140742.CAA057303F@freebsd-current.sentex.ca> ((mtime 16610 55105 533085)) nnml:bsd-current) (<20040630141326.666947303F@freebsd-current.sentex.ca> ((mtime 16610 55105 533706)) nnml:bsd-current))


Max entries is set to 2500, I've got two entries.  At this moment the error
is natnump, -2498.

norbert.

Re: Gnus registry woes

[Ted Zlatanov]

On Wed, 30 Jun 2004, viteno@xemacs.org wrote:

> Max entries is set to 2500, I've got two entries.  At this moment the error
> is natnump, -2498.

I think I figured out the problem, I don't know how come I never
realized it could happen that the trim length could be negative.
Oops!  It's fixed in CVS, let me know if it works OK for you.

Ted

Re: Gnus registry woes

[Norbert Koch]

"Ted Zlatanov" <tzz@lifelogs.com> writes:

> I think I figured out the problem, I don't know how come I never
> realized it could happen that the trim length could be negative.
> Oops!  It's fixed in CVS, let me know if it works OK for you.

Yes, it works.  Thanks for the fix,
norbert.

Re: Gnus registry woes

[Ted Zlatanov]

On Tue, 29 Jun 2004, viteno@xemacs.org wrote:

> "Ted Zlatanov" <tzz@lifelogs.com> writes:
> 
>> I would guess the natnump error, which I have never seen before, is
>> coming from an invalid mtime.  Can you trace the error deeper with
>> (debug) statements inside the lambda function above?  Alternatively,
>> can you send me your registry file, if the error is repeatable from
>> it?
> 
> I think the problem is there *is* no registry file, yet.  Should I
> create it (empty)?

You can, but many others have started with an empty registry and have
not had your error AFAIK.

Ted