Error in current CVS, last-coding-system-used

Error in current CVS, last-coding-system-used

[Norbert Koch]

Hi Jesper,

Your commit 

2003-04-06  Jesper Harder  <harder@ifa.au.dk>

	* mm-bodies.el (mm-decode-body): Set buffer-file-coding-system to
	last-coding-system-used.

break things for me:

Signaling: (void-variable last-coding-system-used)
  mm-decode-body(nil nil nil nil)
  article-decode-charset()
  run-hooks(article-decode-charset)
  gnus-request-article-this-buffer(53949 "nnml:bsd-cvs")
  gnus-article-prepare(53949 nil)
  gnus-summary-display-article(53949 nil)
  gnus-summary-select-article(nil nil pseudo)
  gnus-summary-scroll-up(1)
  call-interactively(gnus-summary-scroll-up)

on my 21.4 (patch 12) "Portable Code" XEmacs Lucid.  Is it just me or
slipped something by? 

Thanks,
norbert.

Re: Error in current CVS, last-coding-system-used

[Jesper Harder]

Norbert Koch <nk@viteno.net> writes:

> Your commit 
>
> 2003-04-06  Jesper Harder  <harder@ifa.au.dk>
>
> 	* mm-bodies.el (mm-decode-body): Set buffer-file-coding-system to
> 	last-coding-system-used.

> on my 21.4 (patch 12) "Portable Code" XEmacs Lucid.  Is it just me or
> slipped something by? 

Fixed.  GNU Emacs sets `last-coding-system-used' after decoding unibyte
text, but XEmacs doesn't.

Re: Error in current CVS, last-coding-system-used

[Mark Thomas]

Jesper Harder <harder@myrealbox.com> writes:

>> 	* mm-bodies.el (mm-decode-body): Set buffer-file-coding-system to
>> 	last-coding-system-used.
>
> Fixed.

No, it isn't.  Your patch is missing a ':

Index: lisp/mm-bodies.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-bodies.el,v
retrieving revision 6.19
diff -u -r6.19 mm-bodies.el
--- lisp/mm-bodies.el   6 Apr 2003 12:17:24 -0000       6.19
+++ lisp/mm-bodies.el   6 Apr 2003 13:26:30 -0000
@@ -278,7 +278,7 @@
            (mm-decode-coding-region-safely (point-min) (point-max)
                                            coding-system)))
        (setq buffer-file-coding-system
-             (if (boundp last-coding-system-used)
+             (if (boundp 'last-coding-system-used)
                  last-coding-system-used
                coding-system))))))
 

Re: Error in current CVS, last-coding-system-used

[Norbert Koch]

Mark Thomas <swoon@bellatlantic.net> writes:

> Jesper Harder <harder@myrealbox.com> writes:
>
>>> 	* mm-bodies.el (mm-decode-body): Set buffer-file-coding-system to
>>> 	last-coding-system-used.
>>
>> Fixed.
>
> No, it isn't.  Your patch is missing a ':

Thanks for fixing this,
norbert.