From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/6818 Path: main.gmane.org!not-for-mail From: Christopher Davis Newsgroups: gmane.emacs.gnus.general Subject: Re: 5.2.20 nits/fixes (with patches for most) Date: 19 Jun 1996 16:29:25 -0400 Message-ID: References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 (generated by tm-edit 7.68) Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1035147219 4846 80.91.224.250 (20 Oct 2002 20:53:39 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 20:53:39 +0000 (UTC) Return-Path: ding-request@ifi.uio.no Original-Received: from ifi.uio.no (ifi.uio.no [129.240.64.2]) by deanna.miranova.com (8.7.5/8.6.9) with SMTP id OAA07433 for ; Wed, 19 Jun 1996 14:18:36 -0700 Original-Received: from loiosh.kei.com (ckd@loiosh.kei.com [192.88.144.32]) by ifi.uio.no with ESMTP (8.6.11/ifi2.4) id for ; Wed, 19 Jun 1996 22:29:59 +0200 Original-Received: (from ckd@localhost) by loiosh.kei.com (8.7.5/8.7.3) id QAA01469; Wed, 19 Jun 1996 16:29:25 -0400 (EDT) Original-To: ding@ifi.uio.no X-Attribution: ckd In-Reply-To: larsi@ifi.uio.no's message of 19 Jun 96 16:36:55 GMT Original-Lines: 45 X-Mailer: Gnus v5.2.20/XEmacs 19.14 Xref: main.gmane.org gmane.emacs.gnus.general:6818 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:6818 LMI> == Lars Magne Ingebrigtsen ckd> - message-insert-signature adds a gratuitous blank line at the end ckd> of the text if the text already ends in a newline. LMI> An extra newline before the signature separator? Hm, yes... It LMI> removes all whitespace at the end of the message before inserting LMI> the signature, and it inserts a blank line before the separator. Actually, it backs up over all the whitespace, moves forward a line (so if there is a newline at the end of the text, point will be at the beginning of the next line), and then deletes from there to point-max (preserving said newline, if any). So there are three possibilities: - no newline at end of buffer. forward-line will silently fail, and message-insert-signature will insert \n-- \n and the signature. - one newline at end of buffer (my usual situation). forward-line will move past that newline, message-insert-signature will delete from there (point-max) to point-max (a no-op), then message-insert-signature will add another newline, leaving a blank line between the last line of text and the .signature file. - more than one newline (or other whitespace) at end of buffer. (Trailing whitespace on the last line of text not included.) forward-line will move past the first newline, the rest will be deleted, and then the scenario goes as for one newline (above). In order to fix the second and third scenarios without breaking the first, it suffices to check to make sure that you're not at bol before inserting a newline before the signature separator (as my patch does). LMI> This is slightly fascist. Should it do this or not? Maybe it should be part of the syntax checks, but I say yes! It should zap the whitespace (by default, anyway). Since so many people don't set next-line-add-newlines to nil, lots of posts could otherwise go out with 20 blank lines at the end. -- Christopher Davis "I conclude that the CDA is unconstitutional and that the First Amendment denies Congress the power to regulate protected speech on the Internet." -- Judge Stewart Dalzell in _ACLU v. Reno_