Re2: 0.28 and gnus-article-hide-boring-headers

Re2: 0.28 and gnus-article-hide-boring-headers

[Jari Aalto]

|Wed 17.1.96, Kai Grossjohann <grossjoh@dusty.informatik.uni-dortmund.de>
| Hi all,
| 
| in gnus.el, at line 13133 in function
| gnus-article-hide-boring-headers, I changed the code to read thusly:
| 
|            ((eq elem 'reply-to)
|               ;;- Kai added stringp tests here
|             (when (and (stringp (mail-fetch-field "from"))
|                          (stringp (mail-fetch-field "reply-to"))
|                          (equal (nth 1 (mail-extract-address-components
|                                         (mail-fetch-field "from")))
|                                 (nth 1 (mail-extract-address-components
|                                         (mail-fetch-field "reply-to")))))
|               (gnus-article-hide-header "reply-to")))

And one thing more, that I just heard. The function 'equal' does
not work correcly for strings in 19.30 . If two strings
have different text properties, it will fail.

Instead all string comparisons should be done with string-equal.

[I'm still 19.28 user...]

/jari

Re: Re2: 0.28 and gnus-article-hide-boring-headers

[Lars Magne Ingebrigtsen]

Jari Aalto <jaalto@tre.tele.nokia.fi> writes:

> |                          (equal (nth 1 (mail-extract-address-components
> |                                         (mail-fetch-field "from")))
> |                                 (nth 1 (mail-extract-address-components
> |                                         (mail-fetch-field "reply-to")))))

> And one thing more, that I just heard. The function 'equal' does
> not work correcly for strings in 19.30 . If two strings
> have different text properties, it will fail.
> 
> Instead all string comparisons should be done with string-equal.

`mail-fetch-field' returns strings stripped of their text properties,
so it doesn't much matter. 

-- 
Home is where the cat is.