Gnus development mailing list
 help / color / mirror / Atom feed
From: Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
Subject: Re: 5.2.20 nits/fixes (with patches for most)
Date: 19 Jun 1996 18:36:55 +0200	[thread overview]
Message-ID: <w8syblj92e0.fsf@aegir.ifi.uio.no> (raw)
In-Reply-To: Christopher Davis's message of (unknown date)

Christopher Davis <ckd@loiosh.kei.com> writes:

> - gnus-highlight-selected-summary is incorrectly highlighting the summary
>   line; it's highlighting only the part that's within the %( and %) [this
>   is fine, I can accept that] *except for the first and last characters*.

That's intentional, actually.  :-)  It's bootiful!  :-P

> message.el:
> 
> - I missed a spot when suggesting the addition of the signature separator
>   to the paragraph fill code in message.el; it needs to be added to both
>   paragraph-separate and paragraph-start.  [Oops.]

Yup.  Fix in Gnus v5.2.22.

> - message-insert-signature adds a gratuitous blank line at the end of the
>   text if the text already ends in a newline.

An extra newline before the signature separator?  Hm, yes...  It
removes all whitespace at the end of the message before inserting the
signature, and it inserts a blank line before the separator.  This is
slightly fascist.  Should it do this or not?

> - [semi-feature] message-insert-signature should accept a value for force
>   of 'if-not-present, which would look for a signature separator line in
>   the message and only insert a signature if that line is not present.
>   This allows manually adding a signature to a message that would normally
>   get one appended automatically by a hook.  I also think the interactive
>   use of message-insert-signature should try to prevent the user from
>   adding multiple signatures.

Thanks; I've applied your patch to Gnus 5.2.22.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@ifi.uio.no * Lars Ingebrigtsen


  reply	other threads:[~1996-06-19 16:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1996-06-19 15:52 Christopher Davis
1996-06-19 16:36 ` Lars Magne Ingebrigtsen [this message]
1996-06-19 20:29   ` Christopher Davis
1996-06-20  6:44     ` Lars Magne Ingebrigtsen
1996-06-20 14:24       ` Hallvard B Furuseth
1996-06-20 14:37         ` Lars Magne Ingebrigtsen
1996-06-19 23:00   ` Edward J. Sabol
1996-06-20  4:05     ` Firebeard
1996-06-21 15:35   ` Christopher Davis
1996-06-21 15:50     ` Lars Magne Ingebrigtsen
1996-06-21 17:24       ` Christopher Davis
1996-06-22  9:04         ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=w8syblj92e0.fsf@aegir.ifi.uio.no \
    --to=larsi@ifi.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).