Re: request feedback on new function gnus-dired-attach

[Benjamin Rutt <rutt+news@cis.ohio-state.edu>]

ShengHuo ZHU <zsh@cs.rochester.edu> writes:

>> (define-key dired-mode-map [(control c) (control a)] 'gnus-dired-attach)
>>
>>    is somewhat ugly, since we are defining a dired keymap in another
>>    area of code.  Paul Jarc, on the above g.e.g thread, suggested that
>>    we define a gnus-dired minor mode which can contain the keymap.
>>    But I'm not sure if that's better, since ultimately we're still
>>    stealing a possible future dired keybinding (C-c C-a currently
>>    isn't defined in dired-mode).  Maybe that last line should simply
>>    go in users ~/.gnus so the users control the keybinding override?
>
> Why not do both?  We can steal a special (or customizable) prefix for
> gnus-dired minor mode.  Users still can set C-c C-a in dired-mode-map
> to the function.  This would be less intrusive.

OK, I'll work on defining a gnus-dired minor mode.

>> 3) whether you think this should exist as a separate file that isn't
>>    included in gnus.
>
> It is better to add a separate file, say gnus-dired.el, for gnus-dired
> minor mode. If you'd like to add your code to Gnus package, you'd
> better send an assignment form to FSF (unless you've signed the form).
> I can send you the request form.

Yes, I'd like it to be included with gnus.  I will be happy to sign
the assignment request form for the FSF, just let me know what I need
to do to get that accomplished.

> In addition, I have a piece of code to open file (in dired-mode)
> according to mailcap.  I'd like to include it too.

Sure, please send your code to me and I will integrate it into the new
file gnus-dired.el.  The file can then be used for any purpose where
gnus and dired meet.

> How about use files-to-attach as an argument? So the function can be
> called from other codes too. 
>
> (defun gnus-dired-attach (files-to-attach)
>    "Attach dired's marked files to a gnus message composition."
>    (interactive
>       (list
>  	 (delq nil
>  	      (mapcar
>  		 (lambda (f) (if (file-directory-p f) nil f))
>  		 (nreverse (dired-map-over-marks (dired-get-filename) nil))))))
>     ...)

That looks very nice, I will make that change.  Thanks,
-- 
Benjamin