Re: request feedback on new function gnus-dired-attach

[Benjamin Rutt <rutt+news@cis.ohio-state.edu>]

Benjamin Rutt <rutt+news@cis.ohio-state.edu> writes:

> (defun gnus-dired-attach ()

One minor fix.  I realized that it shouldn't start attaching if no
dired files have been marked.  So, here's the code again with that bug
squashed:

(defun gnus-dired-attach ()
  "Attach dired's marked files to a gnus message composition."
  (interactive)
  (let ((files-to-attach
	 ;; don't attach directories
	 (delq nil
	       (mapcar
		(lambda (f) (if (file-directory-p f) nil f))
		(nreverse (dired-map-over-marks (dired-get-filename) nil)))))
	(destination nil)
	(files-str nil)
	(bufs nil))
    ;; warn if user tries to attach without any files marked 
    (if (null files-to-attach)
	(message "No files marked to attach")
      (setq files-str
	    (mapconcat
	     (lambda (f) (file-name-nondirectory f))
	     files-to-attach ", "))
      (setq bufs (message-buffers))
    
      ;; set up destination message buffer
      (if (and bufs
	       (y-or-n-p "Attach files to existing message buffer? "))
	  (setq destination
		(if (= (length bufs) 1)
		    (get-buffer (car bufs))
		  (completing-read "Attach to which message buffer: "
				   (mapcar
				    (lambda (b)
				      (cons b (get-buffer b)))
				    bufs)
				   nil t)))
	;; setup a new gnus message buffer
	(gnus-setup-message 'message (message-mail))
	(setq destination (current-buffer)))

      ;; set buffer to destination buffer, and attach files
      (set-buffer destination)
      (goto-char (point-max))		;attach at end of buffer
      (while files-to-attach
	(mml-attach-file (car files-to-attach)
			 (or (mm-default-file-encoding (car files-to-attach))
			     "application/octet-stream") nil)
	(setq files-to-attach (cdr files-to-attach)))
      (message "attached files %s" files-str))))
(define-key dired-mode-map [(control c) (control a)] 'gnus-dired-attach)


-- 
Benjamin