* .overview file when using gnus-agent.
@ 1998-08-28 8:32 Tatsuya Ichikawa
1998-08-29 10:50 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Tatsuya Ichikawa @ 1998-08-28 8:32 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
I've post gnus-agent.el's patch to expire correctly connecting to
News server which does not return Xref field.
But in gnus-5.6.41 , these code removed. Why??
Any reason??
Here is a patch.
;; Oops , Please correct comment ... Semi-gnus -> Gnus.
;; Sorry...
[-- Attachment #2: gnus-agent.el.diff --]
[-- Type: application/octet-stream, Size: 4193 bytes --]
*** gnus-agent.el Thu Aug 27 18:03:58 1998
--- /ichikawa/emacs-lisp/semi-gnus-ichikawa/lisp/gnus-agent.el Thu Aug 27 21:30:54 1998
***************
*** 1,4 ****
! ;;; gnus-agent.el --- unplugged support for Gnus
;; Copyright (C) 1997,98 Free Software Foundation, Inc.
;; Author: Lars Magne Ingebrigtsen <larsi@gnus.org>
--- 1,4 ----
! ;;; gnus-agent.el --- unplugged support for Semi-gnus
;; Copyright (C) 1997,98 Free Software Foundation, Inc.
;; Author: Lars Magne Ingebrigtsen <larsi@gnus.org>
***************
*** 129,135 ****
"Load FILE and do a `read' there."
(nnheader-temp-write nil
(ignore-errors
! (insert-file-contents file)
(goto-char (point-min))
(read (current-buffer)))))
--- 129,135 ----
"Load FILE and do a `read' there."
(nnheader-temp-write nil
(ignore-errors
! (nnheader-insert-file-contents file)
(goto-char (point-min))
(read (current-buffer)))))
***************
*** 539,545 ****
(gnus-make-directory (file-name-directory file))
(nnheader-temp-write file
(when (file-exists-p file)
! (insert-file-contents file))
(goto-char (point-min))
(if nntp-server-list-active-group
(progn
--- 539,545 ----
(gnus-make-directory (file-name-directory file))
(nnheader-temp-write file
(when (file-exists-p file)
! (nnheader-insert-file-contents file))
(goto-char (point-min))
(if nntp-server-list-active-group
(progn
***************
*** 728,734 ****
(when (= (point-max) (point-min))
(push (cons group (current-buffer)) gnus-agent-buffer-alist)
(ignore-errors
! (insert-file-contents
(gnus-agent-article-name ".overview" group))))
(nnheader-find-nov-line (string-to-number (cdar crosses)))
(insert (string-to-number (cdar crosses)))
--- 728,734 ----
(when (= (point-max) (point-min))
(push (cons group (current-buffer)) gnus-agent-buffer-alist)
(ignore-errors
! (nnheader-insert-file-contents
(gnus-agent-article-name ".overview" group))))
(nnheader-find-nov-line (string-to-number (cdar crosses)))
(insert (string-to-number (cdar crosses)))
***************
*** 762,767 ****
--- 762,772 ----
(set-buffer nntp-server-buffer)
(unless (eq 'nov (gnus-retrieve-headers articles group))
(nnvirtual-convert-headers))
+ (goto-char (point-min))
+ (while (not (eobp))
+ (goto-char (point-at-eol))
+ (insert "\t")
+ (forward-line 1))
;; Save these headers for later processing.
(copy-to-buffer gnus-agent-overview-buffer (point-min) (point-max))
(let (file)
***************
*** 795,801 ****
(goto-char (point-min))
(set-buffer nntp-server-buffer)
(erase-buffer)
! (insert-file-contents file)
(goto-char (point-max))
(if (or (= (point-min) (point-max))
(progn
--- 800,806 ----
(goto-char (point-min))
(set-buffer nntp-server-buffer)
(erase-buffer)
! (nnheader-insert-file-contents file)
(goto-char (point-max))
(if (or (= (point-min) (point-max))
(progn
***************
*** 1302,1315 ****
(cdr (assq 'dormant
(gnus-info-marks info)))))
nov-file (gnus-agent-article-name ".overview" group))
! (gnus-agent-load-alist group)
(gnus-message 5 "Expiring articles in %s" group)
(set-buffer overview)
(erase-buffer)
(when (file-exists-p nov-file)
! (insert-file-contents nov-file))
(goto-char (point-min))
! (setq article 0)
(while (setq elem (pop articles))
(setq article (car elem))
(when (or (null low)
--- 1307,1320 ----
(cdr (assq 'dormant
(gnus-info-marks info)))))
nov-file (gnus-agent-article-name ".overview" group))
! (gnus-agent-load-alist group)
(gnus-message 5 "Expiring articles in %s" group)
(set-buffer overview)
(erase-buffer)
(when (file-exists-p nov-file)
! (nnheader-insert-file-contents nov-file))
(goto-char (point-min))
! (setq article 0)
(while (setq elem (pop articles))
(setq article (car elem))
(when (or (null low)
[-- Attachment #3: Type: text/plain, Size: 106 bytes --]
--
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp>
# PGP Public Key : See X-Info header in this message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: .overview file when using gnus-agent.
1998-08-28 8:32 .overview file when using gnus-agent Tatsuya Ichikawa
@ 1998-08-29 10:50 ` Lars Magne Ingebrigtsen
1998-08-29 15:09 ` Tatsuya Ichikawa
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 1998-08-29 10:50 UTC (permalink / raw)
Tatsuya Ichikawa <ichikawa@hv.epson.co.jp> writes:
> I've post gnus-agent.el's patch to expire correctly connecting to
> News server which does not return Xref field.
>
> But in gnus-5.6.41 , these code removed. Why??
> Any reason??
This is the first I've seen of this patch.
I've applies the nnheader-insert-file-contents part of the patch, but
this:
> + (goto-char (point-min))
> + (while (not (eobp))
> + (goto-char (point-at-eol))
> + (insert "\t")
> + (forward-line 1))
Does not do the right thing. Adding spurious tabs even to lines that
do not need them is not a good thing.
Anyway -- what problem are you trying to fix? All the NOV parsing
functions should deal properly with lines that do not have Xref fields
included.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: .overview file when using gnus-agent.
1998-08-29 10:50 ` Lars Magne Ingebrigtsen
@ 1998-08-29 15:09 ` Tatsuya Ichikawa
0 siblings, 0 replies; 3+ messages in thread
From: Tatsuya Ichikawa @ 1998-08-29 15:09 UTC (permalink / raw)
>>>>> In <m3ogt412qi.fsf@sparky.gnus.org>
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> wrote:
Lars> This is the first I've seen of this patch.
You may forget this patch.
I've post about ... ? month ago , at Quassia v0.??
I can't remember the version.
Lars> Does not do the right thing. Adding spurious tabs even to lines
Lars> that do not need them is not a good thing.
Oh , really??
Lars> Anyway -- what problem are you trying to fix?
gnus-agent-expire work fine parsing NOV file that has no Xref
fields.
Lars> All the NOV parsing functions should deal properly with lines
Lars> that do not have Xref fields included.
Oh , really??
So this patch need not to apply.
Thanks.
--
Tatsuya Ichikawa : Shiojiri Internet... <t-ichi@po.shiojiri.ne.jp>
# PGP Public Key : See X-Info Header of this message. ;-p
# Meadow's Page : http://www.shiojiri.ne.jp/~t-ichi/meadow.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~1998-08-29 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1998-08-28 8:32 .overview file when using gnus-agent Tatsuya Ichikawa
1998-08-29 10:50 ` Lars Magne Ingebrigtsen
1998-08-29 15:09 ` Tatsuya Ichikawa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).