From: Dan Schmidt <dfan@harmonixmusic.com>
Subject: Two nnmail patches
Date: 09 Jan 1997 14:48:34 -0500 [thread overview]
Message-ID: <wkd8vesk8d.fsf@harmonixmusic.com> (raw)
I don't know whether either of these changes is globally a Good Thing,
or whether they're implemented in the best way, but I find them
essential and herewith present them for you to accept, improve, or
discard.
This is a patch to Red Gnus 0.80. I'm running GNU Emacs 19.34.1 under
Win95.
There are two changes in this patch. In order of appearance:
1. Ask for the password only once. Perhaps this should be modified to
throw it out if movemail signals a bad password error.
2. Put quotes around the password. In rgnus-0.80, if your password is
"holy smoke", only "holy" will be passed to movemail. This may not
be a problem on other systems.
Dan
Here's the patch:
*** c:/app/emacs-19.34/rgnus-0.80/lisp/old/nnmail.el Thu Jan 09 05:59:32 1997
--- c:/app/emacs-19.34/rgnus-0.80/lisp/nnmail.el Thu Jan 09 14:36:52 1997
***************
*** 512,518 ****
(setq nnmail-internal-password
(nnmail-read-passwd
(format "Password for %s: "
! (substring inbox (+ popmail 3))))))
(message "Getting mail from post office ..."))
(when (or (and (file-exists-p tofile)
(/= 0 (nnheader-file-size tofile)))
--- 512,519 ----
(setq nnmail-internal-password
(nnmail-read-passwd
(format "Password for %s: "
! (substring inbox (+ popmail 3)))))
! (setq nnmail-pop-password nnmail-internal-password)) ; only prompt once
(message "Getting mail from post office ..."))
(when (or (and (file-exists-p tofile)
(/= 0 (nnheader-file-size tofile)))
***************
*** 548,554 ****
exec-directory)
nil errors nil inbox tofile)
(when nnmail-internal-password
! (list nnmail-internal-password))))))
(if (not (buffer-modified-p errors))
;; No output => movemail won
(progn
--- 549,556 ----
exec-directory)
nil errors nil inbox tofile)
(when nnmail-internal-password
! ;; Quote in case the password has spaces
! (list (prin1-to-string nnmail-internal-password)))))))
(if (not (buffer-modified-p errors))
;; No output => movemail won
(progn
reply other threads:[~1997-01-09 19:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wkd8vesk8d.fsf@harmonixmusic.com \
--to=dfan@harmonixmusic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).