Two nnmail patches

Two nnmail patches

[Dan Schmidt]

I don't know whether either of these changes is globally a Good Thing,
or whether they're implemented in the best way, but I find them
essential and herewith present them for you to accept, improve, or
discard.

This is a patch to Red Gnus 0.80.  I'm running GNU Emacs 19.34.1 under
Win95.

There are two changes in this patch.  In order of appearance:

1. Ask for the password only once.  Perhaps this should be modified to
   throw it out if movemail signals a bad password error.

2. Put quotes around the password.  In rgnus-0.80, if your password is
   "holy smoke", only "holy" will be passed to movemail.  This may not
   be a problem on other systems.

Dan

Here's the patch:

*** c:/app/emacs-19.34/rgnus-0.80/lisp/old/nnmail.el	Thu Jan 09 05:59:32 1997
--- c:/app/emacs-19.34/rgnus-0.80/lisp/nnmail.el	Thu Jan 09 14:36:52 1997
***************
*** 512,518 ****
  		(setq nnmail-internal-password
  		      (nnmail-read-passwd
  		       (format "Password for %s: "
! 			       (substring inbox (+ popmail 3))))))
  	      (message "Getting mail from post office ..."))
  	  (when (or (and (file-exists-p tofile)
  			 (/= 0 (nnheader-file-size tofile)))
--- 512,519 ----
  		(setq nnmail-internal-password
  		      (nnmail-read-passwd
  		       (format "Password for %s: "
! 			       (substring inbox (+ popmail 3)))))
!               (setq nnmail-pop-password nnmail-internal-password)) ; only prompt once
  	      (message "Getting mail from post office ..."))
  	  (when (or (and (file-exists-p tofile)
  			 (/= 0 (nnheader-file-size tofile)))
***************
*** 548,554 ****
  					 exec-directory)
  		       nil errors nil inbox tofile)
  		      (when nnmail-internal-password
! 			(list nnmail-internal-password))))))
  		(if (not (buffer-modified-p errors))
  		    ;; No output => movemail won
  		    (progn
--- 549,556 ----
  					 exec-directory)
  		       nil errors nil inbox tofile)
  		      (when nnmail-internal-password
!                         ;; Quote in case the password has spaces
!                         (list (prin1-to-string nnmail-internal-password)))))))
  		(if (not (buffer-modified-p errors))
  		    ;; No output => movemail won
  		    (progn