From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/9346
Path: main.gmane.org!not-for-mail
From: Dan Schmidt <dfan@harmonixmusic.com>
Newsgroups: gmane.emacs.gnus.general
Subject: Two nnmail patches
Date: 09 Jan 1997 14:48:34 -0500
Sender: dfan%TURANGALILA@ifi.uio.no
Message-ID: <wkd8vesk8d.fsf@harmonixmusic.com>
NNTP-Posting-Host: coloc-standby.netfonds.no
X-Trace: main.gmane.org 1035149385 17923 80.91.224.250 (20 Oct 2002 21:29:45 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sun, 20 Oct 2002 21:29:45 +0000 (UTC)
Return-Path: <ding-request@ifi.uio.no>
Original-Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2])
          by deanna.miranova.com (8.8.4/8.8.4) with SMTP
	  id LAA07871 for <steve@miranova.com>; Thu, 9 Jan 1997 11:58:41 -0800
Original-Received: from ntserver.harmonixmusic.com (harmonix.ma.ultranet.com [146.115.237.55]) by ifi.uio.no with ESMTP (8.6.11/ifi2.4) 
	id <UAA14339@ifi.uio.no> for <ding@ifi.uio.no> ; Thu, 9 Jan 1997 20:45:38 +0100
Original-Received: from TURANGALILA ([146.115.90.78]) by ntserver.harmonixmusic.com
          (post.office MTA v2.0 0813 ID# 0-29126U35) with SMTP id AAA245;
          Thu, 9 Jan 1997 14:37:45 -0500
Original-To: ding@ifi.uio.no
Original-Lines: 59
X-Mailer: Red Gnus v0.80/Emacs 19.34
Xref: main.gmane.org gmane.emacs.gnus.general:9346
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:9346

I don't know whether either of these changes is globally a Good Thing,
or whether they're implemented in the best way, but I find them
essential and herewith present them for you to accept, improve, or
discard.

This is a patch to Red Gnus 0.80.  I'm running GNU Emacs 19.34.1 under
Win95.

There are two changes in this patch.  In order of appearance:

1. Ask for the password only once.  Perhaps this should be modified to
   throw it out if movemail signals a bad password error.

2. Put quotes around the password.  In rgnus-0.80, if your password is
   "holy smoke", only "holy" will be passed to movemail.  This may not
   be a problem on other systems.

Dan

Here's the patch:

*** c:/app/emacs-19.34/rgnus-0.80/lisp/old/nnmail.el	Thu Jan 09 05:59:32 1997
--- c:/app/emacs-19.34/rgnus-0.80/lisp/nnmail.el	Thu Jan 09 14:36:52 1997
***************
*** 512,518 ****
  		(setq nnmail-internal-password
  		      (nnmail-read-passwd
  		       (format "Password for %s: "
! 			       (substring inbox (+ popmail 3))))))
  	      (message "Getting mail from post office ..."))
  	  (when (or (and (file-exists-p tofile)
  			 (/= 0 (nnheader-file-size tofile)))
--- 512,519 ----
  		(setq nnmail-internal-password
  		      (nnmail-read-passwd
  		       (format "Password for %s: "
! 			       (substring inbox (+ popmail 3)))))
!               (setq nnmail-pop-password nnmail-internal-password)) ; only prompt once
  	      (message "Getting mail from post office ..."))
  	  (when (or (and (file-exists-p tofile)
  			 (/= 0 (nnheader-file-size tofile)))
***************
*** 548,554 ****
  					 exec-directory)
  		       nil errors nil inbox tofile)
  		      (when nnmail-internal-password
! 			(list nnmail-internal-password))))))
  		(if (not (buffer-modified-p errors))
  		    ;; No output => movemail won
  		    (progn
--- 549,556 ----
  					 exec-directory)
  		       nil errors nil inbox tofile)
  		      (when nnmail-internal-password
!                         ;; Quote in case the password has spaces
!                         (list (prin1-to-string nnmail-internal-password)))))))
  		(if (not (buffer-modified-p errors))
  		    ;; No output => movemail won
  		    (progn